Skip to contentSkip to conversation

Fix PCI HyperV device error handling

PATCH Applied Wei Hu 3 participants 4 messages May 7, 2020 – May 21, 2020

Subsystems (3)
lore
Share & tools
lore

Wei Hu

author maintainer
#0 lore raw

v3 cover Fix PCI HyperV device error handling

This series better handles some PCI HyperV error cases in general and for kdump case. Some of review comments from previous individual patch reviews, including splitting into separate patches, have already been incorporated. Thanks Lorenzo Pieralisi for the review and suggestions, as well as Michael Kelley's contribution to the commit log.

Thanks,
Wei

Wei Hu (2):
PCI: hv: Fix the PCI HyperV probe failure path to release resource
properly
PCI: hv: Retry PCI bus D0 entry when the first attempt failed with
invalid device state

 drivers/pci/controller/pci-hyperv.c | 60 ++++++++++++++++++++++++++---
 1 file changed, 54 insertions(+), 6 deletions(-)
Signature · 1 line
2.20.1
#1 lore raw
Quoted 11 lines · Wei Hu

This series better handles some PCI HyperV error cases in general and for kdump case. Some of review comments from previous individual patch reviews, including splitting into separate patches, have already been incorporated. Thanks Lorenzo Pieralisi for the review and suggestions, as well as Michael Kelley's contribution to the commit log.

Thanks,
Wei

Quoted 8 lines

Wei Hu (2):
PCI: hv: Fix the PCI HyperV probe failure path to release resource
properly
PCI: hv: Retry PCI bus D0 entry when the first attempt failed with
invalid device state

 drivers/pci/controller/pci-hyperv.c | 60 ++++++++++++++++++++++++++---
 1 file changed, 54 insertions(+), 6 deletions(-)

Applied to pci/hv, thanks.

Lorenzo

#2 lore raw

From: Lorenzo Pieralisi <[email protected]> Sent: Monday, May 11, 2020 4:22 AM

Quoted 19 lines · Wei Hu
Quoted 17 lines

This series better handles some PCI HyperV error cases in general and for kdump case. Some of review comments from previous individual patch reviews, including splitting into separate patches, have already been incorporated. Thanks Lorenzo Pieralisi for the review and suggestions, as well as Michael Kelley's contribution to the commit log.

Thanks,
Wei

Wei Hu (2):
PCI: hv: Fix the PCI HyperV probe failure path to release resource
properly
PCI: hv: Retry PCI bus D0 entry when the first attempt failed with
invalid device state

Quoted 5 lines
Quoted 2 lines
 drivers/pci/controller/pci-hyperv.c | 60 ++++++++++++++++++++++++++---
 1 file changed, 54 insertions(+), 6 deletions(-)

Applied to pci/hv, thanks.

Lorenzo --

Will you be bringing these fixes into 5.7? The main fix is the 2nd patch, but there wasn't a clear "Fixes:" tag to add because the problem is due more to how Hyper-V operates than a bug in a previous Linux commit. We have a customer experiencing the problem, so getting the fix into the main tree sooner rather than later is helpful.

Thx,

Michael

#3 lore raw
Quoted 26 lines · Michael Kelley

From: Lorenzo Pieralisi <[email protected]> Sent: Monday, May 11, 2020 4:22 AM

Quoted 19 lines · Wei Hu
Quoted 17 lines

This series better handles some PCI HyperV error cases in general and for kdump case. Some of review comments from previous individual patch reviews, including splitting into separate patches, have already been incorporated. Thanks Lorenzo Pieralisi for the review and suggestions, as well as Michael Kelley's contribution to the commit log.

Thanks,
Wei

Wei Hu (2):
PCI: hv: Fix the PCI HyperV probe failure path to release resource
properly
PCI: hv: Retry PCI bus D0 entry when the first attempt failed with
invalid device state

Quoted 5 lines
Quoted 2 lines
 drivers/pci/controller/pci-hyperv.c | 60 ++++++++++++++++++++++++++---
 1 file changed, 54 insertions(+), 6 deletions(-)

Applied to pci/hv, thanks.

Quoted 7 lines

Lorenzo --

Will you be bringing these fixes into 5.7? The main fix is the 2nd patch, but there wasn't a clear "Fixes:" tag to add because the problem is due more to how Hyper-V operates than a bug in a previous Linux commit. We have a customer experiencing the problem, so getting the fix into the main tree sooner rather than later is helpful.

We usually send fixes at -rc* if the bug was introduced in the previous release, at the moment this is v5.8 material not planned for such a late -rc* (ie -rc7). We can send patches to stable and/or apply a Fixes: tag if that can help when the commits hit mainline.

Lorenzo