Skip to contentSkip to conversation

powerpc/mpc85xx: Add Cyrus HDD LED

PATCH In review Darren Stevens 2 participants 2 messages May 7, 2020 – May 8, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 4/5 powerpc/mpc85xx: Add Cyrus HDD LED

The Cyrus board has its HDD LED connected to a GPIO pin. Add a device tree entry for this.

---
 arch/powerpc/boot/dts/fsl/cyrus_p5020.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)
(quoted diff) +0 -0

b/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts index f0548fe..74c100f 100644 --- a/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts +++ b/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts
@@ -83,6 +83,16 @@
gpios = <&gpio0 2 1>;
};

+ leds {
+ compatible = "gpio-leds";
+
+ hdd {
+ label = "Disk Activity";
+ gpios = <&gpio0 5 0>;
+ linux,default-trigger =
"disk-activity";
+ };
+ };
+
fman@400000 {
mdio@e1120 {
phy3: ethernet-phy@3 {

#1 lore raw
Quoted 16 lines · Darren Stevens

The Cyrus board has its HDD LED connected to a GPIO pin. Add a device tree entry for this.

---
 arch/powerpc/boot/dts/fsl/cyrus_p5020.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)
(quoted diff) +0 -0

b/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts index f0548fe..74c100f 100644 --- a/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts +++ b/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts

(quoted diff) +0 -0
@@ -83,6 +83,16 @@
 			gpios = <&gpio0 2 1>;
 		};

Review line 94

Quoted 10 lines
(quoted diff) +8 -0
 
+		leds {
+			compatible = "gpio-leds";
+
+			hdd {
+				label = "Disk Activity";
+				gpios = <&gpio0 5 0>;
+				linux,default-trigger =
 "disk-activity";
+			};

Documentation/devicetree/bindings/leds/common.yaml says that label is deprecated, and to "use 'function' and 'color' properties instead".

Also, please CC [email protected] on these patches.

-Scott