Skip to contentSkip to conversation

PCI: endpoint: use kmemdup_nul() in pci_epf_create()

PATCH In review Chen Zhou 2 participants 2 messages May 8, 2020

Subsystems (2)
lore
Share & tools
lore

Chen Zhou

author
#0 lore raw

PATCH 1/1 PCI: endpoint: use kmemdup_nul() in pci_epf_create()

It is more efficient to use kmemdup_nul() if the size is known exactly.

The doc in kernel:
"Note: Use kmemdup_nul() instead if the size is known exactly."

---
 drivers/pci/endpoint/pci-epf-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/endpoint/pci-epf-core.c +1 -1
index 244e00f48c5c..f035d2ebcae5 100644
@@ -252,7 +252,7 @@ struct pci_epf *pci_epf_create(const char *name)
 		return ERR_PTR(-ENOMEM);
 
 	len = strchrnul(name, '.') - name;
-	epf->name = kstrndup(name, len, GFP_KERNEL);
+	epf->name = kmemdup_nul(name, len, GFP_KERNEL);
 	if (!epf->name) {
 		kfree(epf);
 		return ERR_PTR(-ENOMEM);
Signature · 1 line
2.20.1
#1 lore raw
Quoted 4 lines · Chen Zhou

It is more efficient to use kmemdup_nul() if the size is known exactly.

The doc in kernel:
"Note: Use kmemdup_nul() instead if the size is known exactly."

If you want to do this, I want to do at least the entire drivers/pci directory at once so we don't have a bunch of onesy-twosy patches. It looks like there's at least one more potential change in pci_dev_str_match_path().

Also, please mention that the doc is from the kstrndup() function comment.

Quoted 21 lines
---
 drivers/pci/endpoint/pci-epf-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/endpoint/pci-epf-core.c +1 -1
index 244e00f48c5c..f035d2ebcae5 100644
@@ -252,7 +252,7 @@ struct pci_epf *pci_epf_create(const char *name)
 		return ERR_PTR(-ENOMEM);
 
 	len = strchrnul(name, '.') - name;
-	epf->name = kstrndup(name, len, GFP_KERNEL);
+	epf->name = kmemdup_nul(name, len, GFP_KERNEL);
 	if (!epf->name) {
 		kfree(epf);
 		return ERR_PTR(-ENOMEM);
Signature · 1 line
2.20.1