f2fs: remove blk_plugging in block_operations
Jaegeuk Kim
maintainerPATCH 1/1 f2fs: remove blk_plugging in block_operations
blk_plugging doesn't seem to give any benefit.
Signed-off-by Jaegeuk Kim <[email protected]>
--- fs/f2fs/checkpoint.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
fs/f2fs/checkpoint.c +3 -7
@@ -1169,8 +1169,6 @@ static int block_operations(struct f2fs_sb_info *sbi)struct blk_plug plug;int err =0 , cnt =0 ; -blk_start_plug (&plug); - retry_flush_quotas:f2fs_lock_all (sbi);if (__need_flush_quota (sbi)) {
@@ -1198,7 +1196,7 @@ static int block_operations(struct f2fs_sb_info *sbi)f2fs_unlock_all (sbi); err =f2fs_sync_dirty_inodes (sbi,DIR_INODE );if (err) - goto out; +return err;cond_resched (); goto retry_flush_quotas; }
@@ -1214,7 +1212,7 @@ static int block_operations(struct f2fs_sb_info *sbi)f2fs_unlock_all (sbi); err =f2fs_sync_inode_meta (sbi);if (err) - goto out; +return err;cond_resched (); goto retry_flush_quotas; }
@@ -1229,7 +1227,7 @@ static int block_operations(struct f2fs_sb_info *sbi) err =f2fs_sync_node_pages (sbi, &wbc, false,FS_CP_NODE_IO );atomic_dec (&sbi->wb_sync_req[NODE ]);if (err) - goto out; +return err;cond_resched (); goto retry_flush_quotas; }
@@ -1240,8 +1238,6 @@ static int block_operations(struct f2fs_sb_info *sbi)*/ __prepare_cp_block (sbi);up_write (&sbi->node_change); -out: -blk_finish_plug (&plug);return err; }
Signature · 1 line
2.26.2.645.ge9eca65c58-goog