Skip to contentSkip to conversation

drm/amd/powerplay: skip judging if baco support for Arcturus sriov

PATCH In review Jane Jian 2 participants 3 messages May 9, 2020 – May 11, 2020

Subsystems (2)
lore
Share & tools
lore

Jane Jian

author
#0 lore raw

PATCH 1/1 drm/amd/powerplay: skip judging if baco support for Arcturus sriov

since for sriov, baco happens on host side, no need and meaning to judge is baco.
also, since kiq reads strap0 in here, if kiq is not ready or gpu reset(kiq resume) happens after this read, would fail to read and wrongly set baco as true(1).

Change-Id Ib67f837edfbf09263133d5614f6dbb890cf27b12
---
 drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c +1 -1
index 1c66b7d7139c..cfae4bcaf32e 100644
@@ -2251,7 +2251,7 @@ static bool arcturus_is_baco_supported(struct smu_context *smu)
 	struct amdgpu_device *adev = smu->adev;
 	uint32_t val;
 
-	if (!smu_v11_0_baco_is_support(smu))
+	if (!smu_v11_0_baco_is_support(smu) || amdgpu_sriov_vf(adev))
 		return false;
 
 	val = RREG32_SOC15(NBIO, 0, mmRCC_BIF_STRAP0);
Signature · 6 lines
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
author
#1 lore raw

[AMD Official Use Only - Internal Distribution Only]

Hi @Quan, Evan,
Could you please help to review this patch?
Since this is previously your patch here.
Thanks,
Jane

-----Original Message-----
From: Jane Jian <[email protected]>
Sent: Saturday, May 9, 2020 4:07 PM
To: [email protected]; Quan, Evan <[email protected]>
Cc: Jian, Jane <[email protected]>; Min, Frank <[email protected]>
Subject: [PATCH] drm/amd/powerplay: skip judging if baco support for Arcturus sriov

since for sriov, baco happens on host side, no need and meaning to judge is baco.
also, since kiq reads strap0 in here, if kiq is not ready or gpu reset(kiq resume) happens after this read, would fail to read and wrongly set baco as true(1).

Change-Id Ib67f837edfbf09263133d5614f6dbb890cf27b12
---
 drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c +1 -1
index 1c66b7d7139c..cfae4bcaf32e 100644
@@ -2251,7 +2251,7 @@ static bool arcturus_is_baco_supported(struct smu_context *smu)
 	struct amdgpu_device *adev = smu->adev;
 	uint32_t val;
 
-	if (!smu_v11_0_baco_is_support(smu))
+	if (!smu_v11_0_baco_is_support(smu) || amdgpu_sriov_vf(adev))
 		return false;
 
 	val = RREG32_SOC15(NBIO, 0, mmRCC_BIF_STRAP0);

--
2.17.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Acked-by
#2 lore raw

-----Original Message-----
From: Jian, Jane <[email protected]>
Sent: Monday, May 11, 2020 2:26 PM
To: Jian, Jane <[email protected]>; [email protected]; Quan, Evan <[email protected]>
Cc: Min, Frank <[email protected]>
Subject: RE: [PATCH] drm/amd/powerplay: skip judging if baco support for Arcturus sriov

[AMD Official Use Only - Internal Distribution Only]

Hi @Quan, Evan,
Could you please help to review this patch?
Since this is previously your patch here.
Thanks,
Jane

-----Original Message-----
From: Jane Jian <[email protected]>
Sent: Saturday, May 9, 2020 4:07 PM
To: [email protected]; Quan, Evan <[email protected]>
Cc: Jian, Jane <[email protected]>; Min, Frank <[email protected]>
Subject: [PATCH] drm/amd/powerplay: skip judging if baco support for Arcturus sriov

since for sriov, baco happens on host side, no need and meaning to judge is baco.
also, since kiq reads strap0 in here, if kiq is not ready or gpu reset(kiq resume) happens after this read, would fail to read and wrongly set baco as true(1).

Change-Id Ib67f837edfbf09263133d5614f6dbb890cf27b12
---
 drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c +1 -1
index 1c66b7d7139c..cfae4bcaf32e 100644
@@ -2251,7 +2251,7 @@ static bool arcturus_is_baco_supported(struct smu_context *smu)
 	struct amdgpu_device *adev = smu->adev;
 	uint32_t val;
 
-	if (!smu_v11_0_baco_is_support(smu))
+	if (!smu_v11_0_baco_is_support(smu) || amdgpu_sriov_vf(adev))
 		return false;
 
 	val = RREG32_SOC15(NBIO, 0, mmRCC_BIF_STRAP0);

--
2.17.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx