Skip to contentSkip to conversation

drm/i915: Make intel_timeline_init static

PATCH New Mika Kuoppala 2 participants 2 messages May 11, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Make intel_timeline_init static

Commit fb5970da1b42 ("drm/i915/gt: Use the kernel_context to measure the breadcrumb size") removed the last external user for intel_timeline_init. Mark it static.

---
 drivers/gpu/drm/i915/gt/intel_timeline.c | 8 ++++----
 drivers/gpu/drm/i915/gt/intel_timeline.h | 5 -----
 2 files changed, 4 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/gt/intel_timeline.c +4 -4
index e1fac1b38f27..4546284fede1 100644
@@ -211,9 +211,9 @@ static void cacheline_free(struct intel_timeline_cacheline *cl)
 	i915_active_release(&cl->active);
 }
 
-int intel_timeline_init(struct intel_timeline *timeline,
-			struct intel_gt *gt,
-			struct i915_vma *hwsp)
+static int intel_timeline_init(struct intel_timeline *timeline,
+			       struct intel_gt *gt,
+			       struct i915_vma *hwsp)
 {
 	void *vaddr;
 
@@ -280,7 +280,7 @@ void intel_gt_init_timelines(struct intel_gt *gt)
 	INIT_LIST_HEAD(&timelines->hwsp_free_list);
 }
 
-void intel_timeline_fini(struct intel_timeline *timeline)
+static void intel_timeline_fini(struct intel_timeline *timeline)
 {
 	GEM_BUG_ON(atomic_read(&timeline->pin_count));
 	GEM_BUG_ON(!list_empty(&timeline->requests));
drivers/gpu/drm/i915/gt/intel_timeline.h +0 -5
index c8e59a333182..4298b9ac7327 100644
@@ -31,11 +31,6 @@
 #include "i915_syncmap.h"
 #include "gt/intel_timeline_types.h"
 
-int intel_timeline_init(struct intel_timeline *tl,
-			struct intel_gt *gt,
-			struct i915_vma *hwsp);
-void intel_timeline_fini(struct intel_timeline *tl);
-
 struct intel_timeline *
 intel_timeline_create(struct intel_gt *gt, struct i915_vma *global_hwsp);
 
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Make intel_timeline_init static

== Series Details ==

== Series Details ==

Series: drm/i915: Make intel_timeline_init static
URL : https://patchwork.freedesktop.org/series/77149/
State : failure

== Summary ==

Applying: drm/i915: Make intel_timeline_init static Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/gt/intel_timeline.c
M drivers/gpu/drm/i915/gt/intel_timeline.h
Falling back to patching base and 3-way merge... No changes -- Patch already applied.

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx