net: dsa: tag_sja1105: appease sparse checks for ethertype accessors
Subsystems (3)
Vladimir Oltean
maintainerPATCH 1/1 net: dsa: tag_sja1105: appease sparse checks for ethertype accessors
A comparison between a value from the packet and an integer constant value needs to be done by converting the value from the packet from net->host, or the constant from host->net. Not the other way around. Even though it makes no practical difference, correct that.
Fixes 38b5beeae7a4 ("net: dsa: sja1105: prepare tagger for handling DSA tags and VLAN simultaneously")
Signed-off-by Vladimir Oltean <[email protected]>
--- net/dsa/tag_sja1105.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/dsa/tag_sja1105.c +2 -2
@@ -73,10 +73,10 @@ static bool sja1105_can_use_vlan_as_tags(const struct sk_buff *skb) {struct vlan_ethhdr *hdr =vlan_eth_hdr (skb); -if (hdr->h_vlan_proto ==ntohs (ETH_P_SJA1105 )) +if (hdr->h_vlan_proto ==htons (ETH_P_SJA1105 ))return true; -if (hdr->h_vlan_proto !=ntohs (ETH_P_8021Q )) +if (hdr->h_vlan_proto !=htons (ETH_P_8021Q ))return false;return vid_is_dsa_8021q (ntohs (hdr->h_vlan_TCI) &VLAN_VID_MASK );
Signature · 1 line
2.17.1
David Miller
AppliedFrom: Vladimir Oltean <[email protected]>
Date: Wed, 13 May 2020 03:23:27 +0300
Quoted 7 lines
A comparison between a value from the packet and an integer constant value needs to be done by converting the value from the packet from
net->host, or the constant fromhost->net. Not the other way around. Even though it makes no practical difference, correct that.Fixes 38b5beeae7a4 ("net: dsa: sja1105: prepare tagger for handling DSA tags and VLAN simultaneously")Signed-off-by Vladimir Oltean <[email protected]>
Applied.