RDMA/mlx5: Fix query_srq_cmd() function
Subsystems (2)
PATCH 1/1 RDMA/mlx5: Fix query_srq_cmd() function
From: Leon Romanovsky <[email protected]>
The output buffer used in mlx5_cmd_exec_inout() was wrongly changed from pre-allocated srq_out pointer to an input "out" point. That leads to unpredictable results in the get_srqc() call later.
Fixes 31578defe4eb ("RDMA/mlx5: Update mlx5_ib to use new cmd interface")
Reported-by Dan Carpenter <[email protected]>
Signed-off-by Leon Romanovsky <[email protected]>
--- drivers/infiniband/hw/mlx5/srq_cmd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/infiniband/hw/mlx5/srq_cmd.c +3 -3
@@ -169,16 +169,16 @@ static int query_srq_cmd(struct mlx5_ib_dev *dev, struct mlx5_core_srq *srq,MLX5_SET (query_srq_in, in, opcode,MLX5_CMD_OP_QUERY_SRQ );MLX5_SET (query_srq_in, in, srqn, srq->srqn); - err =mlx5_cmd_exec_inout (dev->mdev, query_srq, in, out); + err =mlx5_cmd_exec_inout (dev->mdev, query_srq, in, srq_out);if (err) goto out; - srqc =MLX5_ADDR_OF (query_srq_out, out, srq_context_entry); + srqc =MLX5_ADDR_OF (query_srq_out, srq_out, srq_context_entry);get_srqc (srqc, out);if (MLX5_GET (srqc, srqc, state) !=MLX5_SRQC_STATE_GOOD ) out->flags |=MLX5_SRQ_FLAG_ERR ; out: -kvfree (out); +kvfree (srq_out);return err; }
Signature · 1 line
2.26.2
Jason Gunthorpe
AppliedQuoted 6 lines · Leon Romanovsky
From: Leon Romanovsky <[email protected]>
The output buffer used in
mlx5_cmd_exec_inout()was wrongly changed from pre-allocatedsrq_outpointer to an input "out" point. That leads to unpredictable results in theget_srqc()call later.
Quoted 6 lines
Fixes 31578defe4eb ("RDMA/mlx5: Update mlx5_ib to use new cmd interface")Reported-by Dan Carpenter <[email protected]>Signed-off-by Leon Romanovsky <[email protected]>--- drivers/infiniband/hw/mlx5/srq_cmd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Applied to for-next, thanks
Jason