Skip to contentSkip to conversation

kernel/reproducibility: use specified environment settings

PATCH In review Bruce Ashfield 2 participants 2 messages May 13, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel/reproducibility: use specified environment settings

From: Bruce Ashfield <[email protected]>

The routine to get the timestamp of the kernel commits should specify LC_ALL to ensure consistent behaviour. We were making a copy of the env, adding the setting .. and then not using it on the call.

We specifiy the env in the subprocess call to ensure the variable is available.

---

This is the incremental patch to my previous series. Squash as required!

Bruce

 meta/classes/kernel.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/kernel.bbclass +1 -1
index f31084948f..3ac91fbd4f 100644
@@ -164,7 +164,7 @@ def get_kernel_source_date_epoch(d):
 
     env = os.environ.copy()
     env['LC_ALL'] = 'C'
-    ts = subprocess.check_output(['date', '-d @%s' % s_d_e]).decode('utf-8')
+    ts = subprocess.check_output(['date', '-d @%s' % s_d_e], env=env).decode('utf-8')
 
     return ts
 
Signature · 1 line
2.19.1
#1 lore raw

✗ patchtest: failure for kernel/reproducibility: use specified environment settings

== Series Details ==

Series: kernel/reproducibility: use specified environment settings
Revision: 1
URL : https://patchwork.openembedded.org/series/24133/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at a223691739)

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe