Skip to contentSkip to conversation

valgrind: Do not use outline-atomics on aarch64

PATCH In review Khem Raj 2 participants 3 messages May 14, 2020

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/2 valgrind: Do not use outline-atomics on aarch64

This avoids the __getauxval undefined reference error seen with gcc10 on doing static linking with -nodefaultlibs, which is uncommon usecase anyway, disabling outline-atomics is not a huge deal for OE in terms of performance as we already use -mcpu which is tuned enough to the SOC the code is being generated for

---
 meta/recipes-devtools/valgrind/valgrind_3.15.0.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-devtools/valgrind/valgrind_3.15.0.bb +2 -0
index 7954437a1a..25837e4b44 100644
@@ -74,6 +74,8 @@ EXTRA_OECONF += "${@['--enable-only32bit','--enable-only64bit'][d.getVar('SITEIN
 # valgrind checks host_cpu "armv7*)", so we need to over-ride the autotools.bbclass default --host option
 EXTRA_OECONF_append_arm = " --host=armv7${HOST_VENDOR}-${HOST_OS}"
 
+CFLAGS_append_aarch64 = " -mno-outline-atomics "
+
 EXTRA_OEMAKE = "-w"
 
 CACHED_CONFIGUREVARS += "ac_cv_path_PERL='/usr/bin/env perl'"
Signature · 1 line
2.26.2
author
#1 lore raw

PATCH 2/2 gcc: Drop reverting __getauxval patch

Issue has been fixed in valgrind itself

---
 meta/recipes-devtools/gcc/gcc-10.1.inc        |  3 +-
 ...se-__getauxval-instead-of-getauxval-.patch | 47 -------------------
 ...mic-Do-not-enforce-march-on-aarch64.patch} |  2 +-
 3 files changed, 2 insertions(+), 50 deletions(-)
 delete mode 100644 meta/recipes-devtools/gcc/gcc-10.1/0038-Revert-AArch64-Use-__getauxval-instead-of-getauxval-.patch
 rename meta/recipes-devtools/gcc/gcc-10.1/{0039-libatomic-Do-not-enforce-march-on-aarch64.patch => 0038-libatomic-Do-not-enforce-march-on-aarch64.patch} (96%)
meta/recipes-devtools/gcc/gcc-10.1.inc +1 -2
index 82b5a20a42..041d426187 100644
@@ -65,8 +65,7 @@ SRC_URI = "\
            file://0035-gentypes-genmodes-Do-not-use-__LINE__-for-maintainin.patch \
            file://0036-Enable-CET-in-cross-compiler-if-possible.patch \
            file://0037-mingw32-Enable-operation_not_supported.patch \
-           file://0038-Revert-AArch64-Use-__getauxval-instead-of-getauxval-.patch \
-           file://0039-libatomic-Do-not-enforce-march-on-aarch64.patch \
+           file://0038-libatomic-Do-not-enforce-march-on-aarch64.patch \
 "
 SRC_URI[sha256sum] = "b6898a23844b656f1b68691c5c012036c2e694ac4b53a8918d4712ad876e7ea2"
 
meta/recipes-devtools/gcc/gcc-10.1/0038-Revert-AArch64-Use-__getauxval-instead-of-getauxval-.patch deleted +0 -47

47 lines not on this page · raw message

meta/recipes-devtools/gcc/gcc-10.1/0038-libatomic-Do-not-enforce-march-on-aarch64.patch renamed from meta/recipes-devtools/gcc/gcc-10.1/0039-libatomic-Do-not-enforce-march-on-aarch64.patch +1 -1
similarity index 96%
rename from meta/recipes-devtools/gcc/gcc-10.1/0039-libatomic-Do-not-enforce-march-on-aarch64.patch
rename to meta/recipes-devtools/gcc/gcc-10.1/0038-libatomic-Do-not-enforce-march-on-aarch64.patch
index fecb562f51..3946acea11 100644
@@ -1,4 +1,4 @@
-From 411fc85c14bb14b07c0db807c55d25ce3f3e507f Mon Sep 17 00:00:00 2001
+From 38d262bfe7c0c894c364dc6e4dc7971e78a73974 Mon Sep 17 00:00:00 2001
 From: Khem Raj <[email protected]>
 Date: Wed, 13 May 2020 15:10:38 -0700
 Subject: [PATCH] libatomic: Do not enforce march on aarch64
Signature · 1 line
2.26.2
#2 lore raw

✗ patchtest: failure for "valgrind: Do not use outline-a..." and 1 more

In reply to Khem Raj

== Series Details ==

Series: "valgrind: Do not use outline-a..." and 1 more
Revision: 1
URL : https://patchwork.openembedded.org/series/24151/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at ce6c50ea68)

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe