Skip to contentSkip to conversation

fsinfo: Fix uninitialized variable in fsinfo_generic_mount_all()

PATCH In review Dan Carpenter 2 participants 2 messages May 15, 2020 – May 19, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fsinfo: Fix uninitialized variable in fsinfo_generic_mount_all()

The "conn" variable is never set to false.

Fixes f2494de388bd ("fsinfo: Add an attribute that lists all the visible mounts in a namespace")

---
The buggy commit looks like preliminary stuff not pushed to anywhere so probably this can just be folded in.

 fs/namespace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/namespace.c +1 -1
index 3fd24575756b..ae489cbac467 100644
@@ -4433,7 +4433,7 @@ int fsinfo_generic_mount_all(struct path *path, struct fsinfo_context *ctx)
 	struct mnt_namespace *ns;
 	struct mount *m, *p;
 	struct path chroot;
-	bool conn;
+	bool conn = false;
 
 	m = real_mount(path->mnt);
 	ns = m->mnt_ns;
Signature · 1 line
2.26.2
#1 lore raw
Quoted 7 lines · Dan Carpenter

The "conn" variable is never set to false.

Fixes f2494de388bd ("fsinfo: Add an attribute that lists all the visible mounts in a namespace")

---
The buggy commit looks like preliminary stuff not pushed to anywhere so probably this can just be folded in.

I folded in someone else's equivalent patch, thanks.

David