kvx: do not include empty <config.h>
PATCH 1/1 kvx: do not include empty <config.h>
<config.h> is per-board config file, which is only allowed for old boards.
For new boards, the top Makefile creates an empty include/config.h
kvx does not have config.h, so #include <config.h> is useless.
Also, remove meaningless board-$(CONFIG_GENERIC).
---
arch/kvx/Makefile | 2 -- arch/kvx/cpu/barebox.lds.S | 1 - arch/kvx/cpu/start.S | 1 - 3 files changed, 4 deletions(-)
arch/kvx/Makefile +0 -2
@@ -2,8 +2,6 @@ KBUILD_DEFCONFIG := generic_defconfig KBUILD_CPPFLAGS += -fno-strict-aliasing -board-$(CONFIG_GENERIC) := generic - KALLSYMS += --symbol-prefix=_ ifeq ($(CROSS_COMPILE),)
arch/kvx/cpu/barebox.lds.S +0 -1
@@ -3,7 +3,6 @@ * Copyright (C) 2019 Kalray Inc. */ -#include <config.h> #include <asm/common.h> #include <asm/sys_arch.h> #include <asm-generic/barebox.lds.h>
arch/kvx/cpu/start.S +0 -1
@@ -3,7 +3,6 @@ * Copyright (C) 2019 Kalray Inc. */ -#include <config.h> #include <linux/linkage.h> #include <asm/privilege.h> #include <asm/sys_arch.h>
Signature · 7 lines
2.25.1 _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Quoted 8 lines · ----- On 15 May, 2020, at 17:22, Masahiro Yamada [email protected] wrote:
<
config.h> is per-board config file, which is only allowed for old boards.For new boards, the top
Makefilecreates an emptyinclude/config.hkvx does not have
config.h, so #include <config.h> is useless.Also, remove meaningless board-$(CONFIG_GENERIC).
Hi Masahiro,
Thanks for spotting that.
FWIW:
Clément
Quoted 50 lines
Signed-off-by Masahiro Yamada <[email protected]>---
arch/kvx/Makefile | 2 -- arch/kvx/cpu/barebox.lds.S | 1 - arch/kvx/cpu/start.S | 1 - 3 files changed, 4 deletions(-)arch/kvx/Makefile +0
-0@@ -2,8 +2,6 @@ KBUILD_DEFCONFIG := generic_defconfig
KBUILD_CPPFLAGS+= -fno-strict-aliasingarch/kvx/Makefile +0
-2-board-$(CONFIG_GENERIC) := generic -KALLSYMS += --symbol-prefix=_
ifeq ($(CROSS_COMPILE),)
arch/kvx/cpu/barebox.lds.S +0
-1@@ -3,7 +3,6 @@ * Copyright (C) 2019 Kalray Inc. */ -#include <config.h> #include <asm/common.h> #include <asm/sys_arch.h> #include <asm-generic/barebox.lds.h>arch/kvx/cpu/start.S +0
-2@@ -3,7 +3,6 @@ * Copyright (C) 2019 Kalray Inc. */ -#include <config.h> #include <linux/linkage.h> #include <asm/privilege.h> #include <asm/sys_arch.h> --2.25.1
Quoted 4 lines
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Sascha Hauer
AppliedQuoted 11 lines · Masahiro Yamada
<
config.h> is per-board config file, which is only allowed for old boards.For new boards, the top
Makefilecreates an emptyinclude/config.hkvx does not have
config.h, so #include <config.h> is useless.Also, remove meaningless board-$(CONFIG_GENERIC).
Signed-off-by Masahiro Yamada <[email protected]>---
Applied, thanks
Sascha
Quoted 52 lines
arch/kvx/Makefile | 2 -- arch/kvx/cpu/barebox.lds.S | 1 - arch/kvx/cpu/start.S | 1 - 3 files changed, 4 deletions(-)arch/kvx/Makefile +0
-2@@ -2,8 +2,6 @@ KBUILD_DEFCONFIG := generic_defconfig KBUILD_CPPFLAGS += -fno-strict-aliasing -board-$(CONFIG_GENERIC) := generic - KALLSYMS += --symbol-prefix=_ ifeq ($(CROSS_COMPILE),)arch/kvx/cpu/barebox.lds.S +0
-1@@ -3,7 +3,6 @@ * Copyright (C) 2019 Kalray Inc. */ -#include <config.h> #include <asm/common.h> #include <asm/sys_arch.h> #include <asm-generic/barebox.lds.h>arch/kvx/cpu/start.S +0
-1@@ -3,7 +3,6 @@ * Copyright (C) 2019 Kalray Inc. */ -#include <config.h> #include <linux/linkage.h> #include <asm/privilege.h> #include <asm/sys_arch.h>Signature · 7 lines
2.25.1 _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Signature · 9 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox