Skip to contentSkip to conversation

vhost: fix zero-copy cannot be enabled

PATCH Superseded Xuan Ding 1 participant 1 message May 19, 2020

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Xuan Ding

author
#0 lore raw

PATCH v3 1/1 vhost: fix zero-copy cannot be enabled

This patch fixes the situation where vhost-user cannot start as server with dequeue_zero_copy enabled.

Using flag instead of vsocket->is_server to determine whether vhost-user is in client mode. Because vsocket->is_server is not ready at this time.

Fixes 715070ea10e6 ("vhost: prevent zero-copy with incompatible client mode")

---

v3:
* Removed Cc to stable and added fixes label.

v2:
* Added the description of problem solved in commit log.

---
 lib/librte_vhost/socket.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_vhost/socket.c +1 -1
index bb8d0d780..0a66ef976 100644
@@ -926,7 +926,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
 			ret = -1;
 			goto out_mutex;
 		}
-		if (!vsocket->is_server) {
+		if ((flags & RTE_VHOST_USER_CLIENT) != 0) {
 			VHOST_LOG_CONFIG(ERR,
 			"error: zero copy is incompatible with vhost client mode\n");
 			ret = -1;
Signature · 1 line
2.17.1