block/rnbd: Fix an IS_ERR() vs NULL check in find_or_create_sess()

The alloc_sess() function returns error pointers, it never returns NULL.

Fixes f7a7a5c228d4 ("block/rnbd: client: main functionality")

Signed-off-by Dan Carpenter <[email protected]>

---
 drivers/block/rnbd/rnbd-clt.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

drivers/block/rnbd/rnbd-clt.c +4 -6

index 55bff3b1be71..a033247281da 100644
@@ -923,13 +923,12 @@ rnbd_clt_session *find_or_create_sess(const char *sessname, bool *first)
        sess = __find_and_get_sess(sessname);
        if (!sess) {
                sess = alloc_sess(sessname);
-               if (sess) {
-                       list_add(&sess->list, &sess_list);
-                       *first = true;
-               } else {
+               if (IS_ERR(sess)) {
                        mutex_unlock(&sess_lock);
-                       return ERR_PTR(-ENOMEM);
+                       return sess;
                }
+               list_add(&sess->list, &sess_list);
+               *first = true;
        } else
                *first = false;
        mutex_unlock(&sess_lock);
--

2.26.2

Quoted 5 lines · Dan Carpenter

The alloc_sess() function returns error pointers, it never returns NULL.

Fixes f7a7a5c228d4 ("block/rnbd: client: main functionality")

Signed-off-by Dan Carpenter <[email protected]>

Thanks Dan,

Reviewed-by Jack Wang <[email protected]>

Quoted 5 lines · Jinpu Wang

Quoted 3 lines · Dan Carpenter

The alloc_sess() function returns error pointers, it never returns NULL.

Quoted 4 lines

Quoted 2 lines

Fixes f7a7a5c228d4 ("block/rnbd: client: main functionality")

Signed-off-by Dan Carpenter <[email protected]>

Thanks Dan,

Reviewed-by Jack Wang <[email protected]>

Hi Jason,

Could you also queue this fix for for-next?

Quoted 8 lines · Jinpu Wang

Quoted 7 lines · Jinpu Wang

Quoted 5 lines · Dan Carpenter

The alloc_sess() function returns error pointers, it never returns NULL.

Fixes f7a7a5c228d4 ("block/rnbd: client: main functionality")

Signed-off-by Dan Carpenter <[email protected]>

Quoted 6 lines

Quoted 2 lines

Thanks Dan,

Reviewed-by Jack Wang <[email protected]>

Hi Jason,

Could you also queue this fix for for-next?

Uhh.. Yes OK, but if it doesn't get cc'd to linux-rdma I won't see it..

Quoted 14 lines · Jason Gunthorpe

Quoted 13 lines · Jinpu Wang

Quoted 9 lines · Jinpu Wang

Quoted 5 lines · Dan Carpenter

The alloc_sess() function returns error pointers, it never returns NULL.

Fixes f7a7a5c228d4 ("block/rnbd: client: main functionality")

Signed-off-by Dan Carpenter <[email protected]>

Thanks Dan,

Reviewed-by Jack Wang <[email protected]>

Hi Jason,

Quoted 4 lines

Quoted 1 line

Could you also queue this fix for for-next?

Uhh.. Yes OK, but if it doesn't get cc'd to linux-rdma I won't see it..

I suspect that we should update MAINTAINERS so that ./scripts/get_maintainer.pl gives the right lists. Proabably all drivers/block/rnbd/ patches are supposed to go through you?