clocksource/drivers/timer-ti-dm: Fix warning for set but not used
PATCH 1/1 clocksource/drivers/timer-ti-dm: Fix warning for set but not used
We can get a warning for dmtimer_clocksource_init() with 'pa' set but not used. This was used in the earlier revisions of the code but no longer needed, so let's remove the unused pa and of_translate_address(). Let's also do it for dmtimer_clockevent_init() that has a similar issue.
--- drivers/clocksource/timer-ti-dm-systimer.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/clocksource/timer-ti-dm-systimer.c +0 -4
@@ -514,7 +514,6 @@ static int __init dmtimer_clockevent_init(struct device_node *np)struct clock_event_device *dev;struct dmtimer_systimer *t;int error; -u32 pa; clkevt =kzalloc (sizeof (*clkevt),GFP_KERNEL );if (!clkevt)
@@ -563,7 +562,6 @@ static int __init dmtimer_clockevent_init(struct device_node *np)writel_relaxed (OMAP_TIMER_INT_OVERFLOW , t->base + t->irq_ena);writel_relaxed (OMAP_TIMER_INT_OVERFLOW , t->base + t->wakeup); - pa =of_translate_address (np,of_get_address (np,0 ,NULL ,NULL ));pr_info ("TI gptimer clockevent: %s%lu Hz at %pOF\n" ,of_find_property (np,"ti,timer-alwon" ,NULL ) ?"always-on " :"" , t->rate, np->parent);
@@ -637,7 +635,6 @@ static int __init dmtimer_clocksource_init(struct device_node *np)struct dmtimer_systimer *t;struct clocksource *dev;int error; -u32 pa; clksrc =kzalloc (sizeof (*clksrc),GFP_KERNEL );if (!clksrc)
@@ -666,7 +663,6 @@ static int __init dmtimer_clocksource_init(struct device_node *np)writel_relaxed (OMAP_TIMER_CTRL_ST |OMAP_TIMER_CTRL_AR , t->base + t->ctrl); - pa =of_translate_address (np,of_get_address (np,0 ,NULL ,NULL ));pr_info ("TI gptimer clocksource: %s%pOF\n" ,of_find_property (np,"ti,timer-alwon" ,NULL ) ?"always-on " :"" , np->parent);
Signature · 1 line
2.26.2
Daniel Lezcano
AppliedQuoted 8 lines · Tony Lindgren
We can get a warning for
dmtimer_clocksource_init()with 'pa' set but not used. This was used in the earlier revisions of the code but no longer needed, so let's remove the unused pa andof_translate_address(). Let's also do it fordmtimer_clockevent_init()that has a similar issue.Reported-by kbuild test robot <[email protected]>Signed-off-by Tony Lindgren <[email protected]>---
Applied, thanks
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Quoted 11 lines · Daniel Lezcano
Quoted 8 lines · Tony Lindgren
We can get a warning for
dmtimer_clocksource_init()with 'pa' set but not used. This was used in the earlier revisions of the code but no longer needed, so let's remove the unused pa andof_translate_address(). Let's also do it fordmtimer_clockevent_init()that has a similar issue.Reported-by kbuild test robot <[email protected]>Signed-off-by Tony Lindgren <[email protected]>---
Applied, thanks
Thanks! Do you already have some immutable commit I can use as the base for the SoC and dts changes? Or do you want to wait a bit for that?
Regards,
Tony
Quoted 11 lines · Tony Lindgren
Quoted 10 lines · Daniel Lezcano
Quoted 8 lines · Tony Lindgren
We can get a warning for
dmtimer_clocksource_init()with 'pa' set but not used. This was used in the earlier revisions of the code but no longer needed, so let's remove the unused pa andof_translate_address(). Let's also do it fordmtimer_clockevent_init()that has a similar issue.Reported-by kbuild test robot <[email protected]>Signed-off-by Tony Lindgren <[email protected]>---
Quoted 5 lines
Quoted 1 line
Applied, thanks
Thanks! Do you already have some immutable commit I can use as the base for the SoC and dts changes? Or do you want to wait a bit for that?
Hi Tony,
https://git.linaro.org/people/daniel.lezcano/linux.git/log/?h=timers/drivers/timer-ti
it contains the two patches + the warning fix
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
Quoted 18 lines · Daniel Lezcano
Quoted 11 lines · Tony Lindgren
Quoted 10 lines · Daniel Lezcano
Quoted 8 lines · Tony Lindgren
We can get a warning for
dmtimer_clocksource_init()with 'pa' set but not used. This was used in the earlier revisions of the code but no longer needed, so let's remove the unused pa andof_translate_address(). Let's also do it fordmtimer_clockevent_init()that has a similar issue.Reported-by kbuild test robot <[email protected]>Signed-off-by Tony Lindgren <[email protected]>---
Quoted 5 lines
Quoted 1 line
Applied, thanks
Thanks! Do you already have some immutable commit I can use as the base for the SoC and dts changes? Or do you want to wait a bit for that?
Quoted 5 lines
Hi Tony,
https://git.linaro.org/people/daniel.lezcano/linux.git/log/?h=timers/drivers/timer-ti
it contains the two patches + the warning fix
OK thanks a lot! Will use that as the base then.
Regards,
Tony
The following commit has been merged into the timers/core branch of tip:
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 6d15120b282e49811a47f2f6d6b749d178be7e99 Gitweb: https://git.kernel.org/tip/6d15120b282e49811a47f2f6d6b749d178be7e99 Author: Tony Lindgren <[email protected]> AuthorDate: Tue, 19 May 2020 08:51:57 -07:00 Committer: Daniel Lezcano <[email protected]> CommitterDate: Tue, 19 May 2020 18:23:50 +02:00
clocksource/drivers/timer-ti-dm: Fix warning for set but not used
We can get a warning for dmtimer_clocksource_init() with 'pa' set but not used. This was used in the earlier revisions of the code but no longer needed, so let's remove the unused pa and of_translate_address(). Let's also do it for dmtimer_clockevent_init() that has a similar issue.
--- drivers/clocksource/timer-ti-dm-systimer.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/clocksource/timer-ti-dm-systimer.c +0 -4
@@ -514,7 +514,6 @@ static int __init dmtimer_clockevent_init(struct device_node *np)struct clock_event_device *dev;struct dmtimer_systimer *t;int error; -u32 pa; clkevt =kzalloc (sizeof (*clkevt),GFP_KERNEL );if (!clkevt)
@@ -563,7 +562,6 @@ static int __init dmtimer_clockevent_init(struct device_node *np)writel_relaxed (OMAP_TIMER_INT_OVERFLOW , t->base + t->irq_ena);writel_relaxed (OMAP_TIMER_INT_OVERFLOW , t->base + t->wakeup); - pa =of_translate_address (np,of_get_address (np,0 ,NULL ,NULL ));pr_info ("TI gptimer clockevent: %s%lu Hz at %pOF\n" ,of_find_property (np,"ti,timer-alwon" ,NULL ) ?"always-on " :"" , t->rate, np->parent);
@@ -637,7 +635,6 @@ static int __init dmtimer_clocksource_init(struct device_node *np)struct dmtimer_systimer *t;struct clocksource *dev;int error; -u32 pa; clksrc =kzalloc (sizeof (*clksrc),GFP_KERNEL );if (!clksrc)
@@ -666,7 +663,6 @@ static int __init dmtimer_clocksource_init(struct device_node *np)writel_relaxed (OMAP_TIMER_CTRL_ST |OMAP_TIMER_CTRL_AR , t->base + t->ctrl); - pa =of_translate_address (np,of_get_address (np,0 ,NULL ,NULL ));pr_info ("TI gptimer clocksource: %s%pOF\n" ,of_find_property (np,"ti,timer-alwon" ,NULL ) ?"always-on " :"" , np->parent);
The following commit has been merged into the timers/core branch of tip:
The following commit has been merged into the timers/core branch of tip:
Commit-ID: c177e2975430cec296aa52a0d413e447417d6cf9 Gitweb: https://git.kernel.org/tip/c177e2975430cec296aa52a0d413e447417d6cf9 Author: Tony Lindgren <[email protected]> AuthorDate: Tue, 19 May 2020 08:51:57 -07:00 Committer: Daniel Lezcano <[email protected]> CommitterDate: Sat, 23 May 2020 00:01:05 +02:00
clocksource/drivers/timer-ti-dm: Fix warning for set but not used
We can get a warning for dmtimer_clocksource_init() with 'pa' set but not used. This was used in the earlier revisions of the code but no longer needed, so let's remove the unused pa and of_translate_address(). Let's also do it for dmtimer_clockevent_init() that has a similar issue.
--- drivers/clocksource/timer-ti-dm-systimer.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/clocksource/timer-ti-dm-systimer.c +0 -4
@@ -514,7 +514,6 @@ static int __init dmtimer_clockevent_init(struct device_node *np)struct clock_event_device *dev;struct dmtimer_systimer *t;int error; -u32 pa; clkevt =kzalloc (sizeof (*clkevt),GFP_KERNEL );if (!clkevt)
@@ -563,7 +562,6 @@ static int __init dmtimer_clockevent_init(struct device_node *np)writel_relaxed (OMAP_TIMER_INT_OVERFLOW , t->base + t->irq_ena);writel_relaxed (OMAP_TIMER_INT_OVERFLOW , t->base + t->wakeup); - pa =of_translate_address (np,of_get_address (np,0 ,NULL ,NULL ));pr_info ("TI gptimer clockevent: %s%lu Hz at %pOF\n" ,of_find_property (np,"ti,timer-alwon" ,NULL ) ?"always-on " :"" , t->rate, np->parent);
@@ -637,7 +635,6 @@ static int __init dmtimer_clocksource_init(struct device_node *np)struct dmtimer_systimer *t;struct clocksource *dev;int error; -u32 pa; clksrc =kzalloc (sizeof (*clksrc),GFP_KERNEL );if (!clksrc)
@@ -666,7 +663,6 @@ static int __init dmtimer_clocksource_init(struct device_node *np)writel_relaxed (OMAP_TIMER_CTRL_ST |OMAP_TIMER_CTRL_AR , t->base + t->ctrl); - pa =of_translate_address (np,of_get_address (np,0 ,NULL ,NULL ));pr_info ("TI gptimer clocksource: %s%pOF\n" ,of_find_property (np,"ti,timer-alwon" ,NULL ) ?"always-on " :"" , np->parent);