i915/gem_tiled_wb: skip on devices without mappable aperture

PATCH In review Ashutosh Dixit 3 participants 4 messages May 19, 2020 – May 20, 2020

lore

Share & tools

lore

Ashutosh Dixit

author

2020-05-19 19:02 UTC #0 lore raw

PATCH 1/1 i915/gem_tiled_wb: skip on devices without mappable aperture

From: Vanshidhar Konda <[email protected]>

Skip on devices without mappable aperture.

Signed-off-by Vanshidhar Konda <[email protected]>

Signed-off-by Ashutosh Dixit <[email protected]>

---
 tests/i915/gem_tiled_wb.c | 1 +
 1 file changed, 1 insertion(+)

tests/i915/gem_tiled_wb.c +1 -0

index b7f352fc7..b61a1b2e8 100644
@@ -139,6 +139,7 @@ igt_simple_main
 	uint32_t handle;
 
 	fd = drm_open_driver(DRIVER_INTEL);
+	gem_require_mappable_ggtt(fd);
 
 	handle = create_bo(fd);
 	get_tiling(fd, handle, &tiling, &swizzle);

Signature · 6 lines

2.26.2.593.gb994622632

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Chris Wilson

2020-05-19 19:47 UTC #1 lore raw

Quoting Ashutosh Dixit (2020-05-19 20:02:57)

Quoted 15 lines

From: Vanshidhar Konda <[email protected]>
Skip on devices without mappable aperture.
Signed-off-by Vanshidhar Konda <[email protected]>
Signed-off-by Ashutosh Dixit <[email protected]>
---
 tests/i915/gem_tiled_wb.c | 1 +
 1 file changed, 1 insertion(+)
tests/i915/gem_tiled_wb.c +0 -0
index b7f352fc7..b61a1b2e8 100644

tests/i915/gem_tiled_wb.c igt_simple_main · line 142

Quoted 4 lines

tests/i915/gem_tiled_wb.c +1 -0

@@ -139,6 +139,7 @@ igt_simple_main
        uint32_t handle;
 
        fd = drm_open_driver(DRIVER_INTEL);
+       gem_require_mappable_ggtt(fd);

To be precise, also

	igt_require(gem_available_fences() > 0);

and the ability to WB mmap. You'll note that even the mmap used here is not yet supported on mmap-offset only HW.
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2020-05-19 20:03 UTC #2 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for i915/gem_tiled_wb: skip on devices without mappable aperture

In reply to Ashutosh Dixit

== Series Details ==

Series: i915/gem_tiled_wb: skip on devices without mappable aperture
URL : https://patchwork.freedesktop.org/series/77432/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8506 -> IGTPW_4593
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/index.html

Known issues
------------

Here are the changes found in IGTPW_4593 that come from known issues:

### IGT changes ###

#### Possible fixes ####

* igt@i915_selftest@live@execlists:
- fi-kbl-8809g: [INCOMPLETE][1] ([i915#1874]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/fi-kbl-8809g/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/fi-kbl-8809g/igt@i915_selftest@[email protected]

[i915#1874]: https://gitlab.freedesktop.org/drm/intel/issues/1874

Participating hosts (49 -> 42)
------------------------------

Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-hsw-4770 fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5661 -> IGTPW_4593

CI-20190529: 20190529
CI_DRM_8506: d6a73e9084ff6adfabbad014bc294d254484f304 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4593: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/index.html
IGT_5661: a772a7c7a761c6125bc0af5284ad603478107737 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2020-05-20 06:17 UTC #3 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for i915/gem_tiled_wb: skip on devices without mappable aperture

In reply to Ashutosh Dixit

== Series Details ==

Series: i915/gem_tiled_wb: skip on devices without mappable aperture
URL : https://patchwork.freedesktop.org/series/77432/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_8506_full -> IGTPW_4593_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_4593_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_4593_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_4593_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_fbcon_fbt@psr:
- shard-tglb: [PASS][1] -> [FAIL][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-tglb2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-tglb1/igt@[email protected]

* igt@runner@aborted:
- shard-tglb: NOTRUN -> [FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-tglb6/igt@[email protected]

#### Warnings ####

* igt@i915_pm_dc@dc6-psr:
- shard-tglb: [FAIL][4] ([i915#454]) -> [FAIL][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-tglb3/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-tglb7/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_4593_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_softpin@noreloc-s3:
- shard-tglb: [PASS][6] -> [INCOMPLETE][7] ([i915#1602] / [i915#456])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-tglb1/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-tglb6/igt@[email protected]

* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [PASS][8] -> [DMESG-WARN][9] ([i915#180])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-kbl7/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-kbl6/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][10] -> [FAIL][11] ([i915#1899]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-iclb3/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-iclb1/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen:
- shard-kbl: [PASS][12] -> [FAIL][13] ([i915#54] / [i915#93] / [i915#95])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-kbl7/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-kbl2/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-crc-atomic:
- shard-kbl: [PASS][14] -> [FAIL][15] ([i915#1566] / [i915#93] / [i915#95])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-kbl7/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-kbl2/igt@[email protected]

* igt@kms_flip_tiling@flip-changes-tiling-y:
- shard-apl: [PASS][16] -> [FAIL][17] ([i915#95])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-apl4/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-apl4/igt@[email protected]

* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][18] -> [SKIP][19] ([fdo#109441]) +2 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-iclb1/igt@kms_psr@psr2_primary_page_flip.html

#### Possible fixes ####

* igt@gen9_exec_parse@allowed-all:
- shard-apl: [DMESG-WARN][20] ([i915#1436] / [i915#716]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-apl6/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-apl1/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen:
- shard-kbl: [FAIL][22] ([i915#54] / [i915#93] / [i915#95]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-kbl1/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-kbl6/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-untiled:
- shard-kbl: [FAIL][24] ([fdo#108145] / [i915#177] / [i915#52] / [i915#54] / [i915#93] / [i915#95]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-kbl2/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-kbl4/igt@[email protected]
- shard-apl: [FAIL][26] ([fdo#108145] / [i915#52] / [i915#54] / [i915#95]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-apl7/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-apl6/igt@[email protected]

* {igt@kms_flip@flip-vs-suspend-interruptible@c-dp1}:
- shard-apl: [DMESG-WARN][28] ([i915#180]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-apl4/igt@kms_flip@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-apl4/igt@kms_flip@[email protected]

* {igt@kms_flip@flip-vs-suspend@a-dp1}:
- shard-kbl: [DMESG-WARN][30] ([i915#180]) -> [PASS][31] +4 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-kbl1/igt@kms_flip@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-kbl2/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-cpu:
- shard-snb: [SKIP][32] ([fdo#109271]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-snb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-cpu.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-snb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-cpu.html

* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-apl: [FAIL][34] ([fdo#108145] / [i915#265] / [i915#95]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-apl8/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-apl7/igt@[email protected]

* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][36] ([fdo#109441]) -> [PASS][37] +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-iclb7/igt@kms_psr@psr2_no_drrs.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-iclb2/igt@kms_psr@psr2_no_drrs.html

* igt@kms_setmode@basic:
- shard-apl: [FAIL][38] ([i915#31]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-apl6/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-apl8/igt@[email protected]
- shard-kbl: [FAIL][40] ([i915#31]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-kbl6/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-kbl2/igt@[email protected]

* {igt@prime_vgem@sync@rcs0}:
- shard-iclb: [INCOMPLETE][42] ([i915#409]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-iclb8/igt@prime_vgem@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-iclb6/igt@prime_vgem@[email protected]

#### Warnings ####

* igt@kms_content_protection@lic:
- shard-apl: [FAIL][44] ([fdo#110321]) -> [FAIL][45] ([fdo#110321] / [i915#95])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-apl6/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-apl2/igt@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [DMESG-FAIL][46] ([i915#180] / [i915#95]) -> [FAIL][47] ([i915#1121] / [i915#93] / [i915#95])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-kbl1/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-kbl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: [FAIL][48] ([fdo#108145] / [i915#265]) -> [FAIL][49] ([fdo#108145] / [i915#265] / [i915#95])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-apl3/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-apl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-kbl: [FAIL][50] ([fdo#108145] / [i915#265] / [i915#93] / [i915#95]) -> [FAIL][51] ([fdo#108145] / [i915#265])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-kbl6/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-kbl7/igt@[email protected]
- shard-apl: [FAIL][52] ([fdo#108145] / [i915#265] / [i915#95]) -> [FAIL][53] ([fdo#108145] / [i915#265])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8506/shard-apl4/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4593/shard-apl7/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (11 -> 8)
------------------------------

Missing (3): pig-skl-6260u pig-glk-j5005 pig-icl-1065g7

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5661 -> IGTPW_4593
* Piglit: piglit_4509 -> None

== Logs ==