qla2xxx: Remove an unused function
Subsystems (2)
PATCH 1/1 qla2xxx: Remove an unused function
This was detected by building the qla2xxx driver with clang. See also commit a9083016a531 ("[SCSI] qla2xxx: Add ISP82XX support").
--- drivers/scsi/qla2xxx/qla_nx.c | 41 ----------------------------------- 1 file changed, 41 deletions(-)
drivers/scsi/qla2xxx/qla_nx.c +0 -41
@@ -380,47 +380,6 @@ qla82xx_pci_set_crbwindow_2M(struct qla_hw_data *ha, ulong off_in, *off_out = (off_in &MASK (16 )) +CRB_INDIRECT_2M + ha->nx_pcibase; } -static inline unsigned long -qla82xx_pci_set_crbwindow (struct qla_hw_data *ha,u64 off) -{ -scsi_qla_host_t *vha =pci_get_drvdata (ha->pdev); -/* See if we are currently pointing to the region we want to use next */ -if ((off >=QLA82XX_CRB_PCIX_HOST ) && (off <QLA82XX_CRB_DDR_NET )) { -/* No need to change window. PCIX and PCIEregs are in both -* regs are in both windows. -*/ -return off; - } - -if ((off >=QLA82XX_CRB_PCIX_HOST ) && (off <QLA82XX_CRB_PCIX_HOST2 )) { -/* We are in first CRB window */ -if (ha->curr_window !=0 ) -WARN_ON (1 ); -return off; - } - -if ((off >QLA82XX_CRB_PCIX_HOST2 ) && (off <QLA82XX_CRB_MAX )) { -/* We are in second CRB window */ - off = off -QLA82XX_CRB_PCIX_HOST2 +QLA82XX_CRB_PCIX_HOST ; - -if (ha->curr_window !=1 ) -return off; - -/* We are in the QM or direct access -* register region - do nothing -*/ -if ((off >=QLA82XX_PCI_DIRECT_CRB ) && - (off <QLA82XX_PCI_CAMQM_MAX )) -return off; - } -/* strange address given */ -ql_dbg (ql_dbg_p3p, vha,0xb001 , -"%s: Warning: unm_nic_pci_set_crbwindow " -"called with an unknown address(%llx).\n" , -QLA2XXX_DRIVER_NAME , off); -return off; -} -static int qla82xx_pci_get_crb_addr_2M (struct qla_hw_data *ha,ulong off_in,void __iomem **off_out)
Quoted 11 lines · Bart Van Assche
This was detected by building the qla2xxx driver with clang. See also commit
a9083016a531("[SCSI] qla2xxx: Add ISP82XX support").Cc Arun Easi <[email protected]>Cc Nilesh Javali <[email protected]>Cc Himanshu Madhani <[email protected]>Cc Hannes Reinecke <[email protected]>Cc Daniel Wagner <[email protected]>Cc Martin Wilck <[email protected]>Cc Roman Bolshakov <[email protected]>Signed-off-by Bart Van Assche <[email protected]>
Quoted 58 lines · Bart Van Assche
This was detected by building the qla2xxx driver with clang. See also commit
a9083016a531("[SCSI] qla2xxx: Add ISP82XX support").Cc Arun Easi <[email protected]>Cc Nilesh Javali <[email protected]>Cc Himanshu Madhani <[email protected]>Cc Hannes Reinecke <[email protected]>Cc Daniel Wagner <[email protected]>Cc Martin Wilck <[email protected]>Cc Roman Bolshakov <[email protected]>Signed-off-by Bart Van Assche <[email protected]>--- drivers/scsi/qla2xxx/qla_nx.c | 41 ----------------------------------- 1 file changed, 41 deletions(-)drivers/scsi/qla2xxx/qla_nx.c +0
-34@@ -380,47 +380,6 @@ qla82xx_pci_set_crbwindow_2M(struct qla_hw_data *ha, ulong off_in, *off_out = (off_in &MASK (16 )) +CRB_INDIRECT_2M + ha->nx_pcibase; } -static inline unsigned long -qla82xx_pci_set_crbwindow (struct qla_hw_data *ha,u64 off) -{ -scsi_qla_host_t *vha =pci_get_drvdata (ha->pdev); -/* See if we are currently pointing to the region we want to use next */ -if ((off >=QLA82XX_CRB_PCIX_HOST ) && (off <QLA82XX_CRB_DDR_NET )) { -/* No need to change window. PCIX and PCIEregs are in both -* regs are in both windows. -*/ -return off; - } - -if ((off >=QLA82XX_CRB_PCIX_HOST ) && (off <QLA82XX_CRB_PCIX_HOST2 )) { -/* We are in first CRB window */ -if (ha->curr_window !=0 ) -WARN_ON (1 ); -return off; - } - -if ((off >QLA82XX_CRB_PCIX_HOST2 ) && (off <QLA82XX_CRB_MAX )) { -/* We are in second CRB window */ - off = off -QLA82XX_CRB_PCIX_HOST2 +QLA82XX_CRB_PCIX_HOST ; - -if (ha->curr_window !=1 ) -return off; - -/* We are in the QM or direct access -* register region - do nothing -*/ -if ((off >=QLA82XX_PCI_DIRECT_CRB ) && - (off <QLA82XX_PCI_CAMQM_MAX )) -return off; - } -/* strange address given */
drivers/scsi/qla2xxx/qla_nx.c qla82xx_pci_set_crbwindow_2M(struct qla_hw_data *ha, ulong off_in, · line 385
Quoted 10 lines
drivers/scsi/qla2xxx/qla_nx.c +0
-7-ql_dbg (ql_dbg_p3p, vha,0xb001 , -"%s: Warning: unm_nic_pci_set_crbwindow " -"called with an unknown address(%llx).\n" , -QLA2XXX_DRIVER_NAME , off); -return off; -} -static int qla82xx_pci_get_crb_addr_2M (struct qla_hw_data *ha,ulong off_in,void __iomem **off_out)
Signature · 1 line
Himanshu Madhani Oracle Linux Engineering
Quoted 57 lines · Bart Van Assche
This was detected by building the qla2xxx driver with clang. See also commit
a9083016a531("[SCSI] qla2xxx: Add ISP82XX support").Cc Arun Easi <[email protected]>Cc Nilesh Javali <[email protected]>Cc Himanshu Madhani <[email protected]>Cc Hannes Reinecke <[email protected]>Cc Daniel Wagner <[email protected]>Cc Martin Wilck <[email protected]>Cc Roman Bolshakov <[email protected]>Signed-off-by Bart Van Assche <[email protected]>--- drivers/scsi/qla2xxx/qla_nx.c | 41 ----------------------------------- 1 file changed, 41 deletions(-)drivers/scsi/qla2xxx/qla_nx.c +0
-34@@ -380,47 +380,6 @@ qla82xx_pci_set_crbwindow_2M(struct qla_hw_data *ha, ulong off_in, *off_out = (off_in &MASK (16 )) +CRB_INDIRECT_2M + ha->nx_pcibase; } -static inline unsigned long -qla82xx_pci_set_crbwindow (struct qla_hw_data *ha,u64 off) -{ -scsi_qla_host_t *vha =pci_get_drvdata (ha->pdev); -/* See if we are currently pointing to the region we want to use next */ -if ((off >=QLA82XX_CRB_PCIX_HOST ) && (off <QLA82XX_CRB_DDR_NET )) { -/* No need to change window. PCIX and PCIEregs are in both -* regs are in both windows. -*/ -return off; - } - -if ((off >=QLA82XX_CRB_PCIX_HOST ) && (off <QLA82XX_CRB_PCIX_HOST2 )) { -/* We are in first CRB window */ -if (ha->curr_window !=0 ) -WARN_ON (1 ); -return off; - } - -if ((off >QLA82XX_CRB_PCIX_HOST2 ) && (off <QLA82XX_CRB_MAX )) { -/* We are in second CRB window */ - off = off -QLA82XX_CRB_PCIX_HOST2 +QLA82XX_CRB_PCIX_HOST ; - -if (ha->curr_window !=1 ) -return off; - -/* We are in the QM or direct access -* register region - do nothing -*/ -if ((off >=QLA82XX_PCI_DIRECT_CRB ) && - (off <QLA82XX_PCI_CAMQM_MAX )) -return off; - } -/* strange address given */
drivers/scsi/qla2xxx/qla_nx.c qla82xx_pci_set_crbwindow_2M(struct qla_hw_data *ha, ulong off_in, · line 385
Quoted 10 lines
drivers/scsi/qla2xxx/qla_nx.c +0
-7-ql_dbg (ql_dbg_p3p, vha,0xb001 , -"%s: Warning: unm_nic_pci_set_crbwindow " -"called with an unknown address(%llx).\n" , -QLA2XXX_DRIVER_NAME , off); -return off; -} -static int qla82xx_pci_get_crb_addr_2M (struct qla_hw_data *ha,ulong off_in,void __iomem **off_out)
Hi Bart,
Thanks,
Roman
Martin K. Petersen
AppliedQuoted 2 lines · Bart Van Assche
This was detected by building the qla2xxx driver with clang. See also commit
a9083016a531("[SCSI] qla2xxx: Add ISP82XX support").
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: qla2xxx: Remove an unused function
https://git.kernel.org/mkp/scsi/c/ce9a9321c118
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering