Skip to contentSkip to conversation

ptrace01: Fix missing format string

PATCH New Khem Raj 2 participants 2 messages May 20, 2020

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 ptrace01: Fix missing format string

Fixes
| ptrace01.c:89:2: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]

|         tst_res(TINFO, tc->message);
|         ^              ~~~~~~~~~~~
---
 testcases/kernel/syscalls/ptrace/ptrace01.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
testcases/kernel/syscalls/ptrace/ptrace01.c +1 -1
index 87a99e4150..9071bbabaf 100644
@@ -86,7 +86,7 @@ static void run(unsigned int i)
 
 	got_signal = 0;
 
-	tst_res(TINFO, tc->message);
+	tst_res(TINFO, "%s", tc->message);
 
 	if (tc->handler == 1) {
 		parent_act.sa_handler = parent_handler;
Signature · 1 line
2.26.2
#1 lore raw

PATCH 1/1 ptrace01: Fix missing format string

Quoted 8 lines · Khem Raj

Fixes
| ptrace01.c:89:2: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]

|         tst_res(TINFO, tc->message);
|         ^              ~~~~~~~~~~~

Pushed.

Signature · 5 lines
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20200520/12284054/attachment.htm>