Bluetooth: hci_qca: Enable WBS support for wcn3991
Hello Abhishek Pandit-Subedi,
The patch a228f7a41029: "Bluetooth: hci_qca: Enable WBS support for wcn3991" from May 14, 2020, leads to the following static checker warning:
drivers/bluetooth/hci_qca.c:1960 qca_serdev_probe() error: uninitialized symbol 'hdev'.
drivers/bluetooth/hci_qca.c
1948 }
1949
1950 if (power_ctrl_enabled) {
1951 hdev = qcadev->serdev_hu.hdev;
^^^^hdev is only initialized here.
1952 set_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, &hdev->quirks);
1953 hdev->shutdown = qca_power_off;
1954 }
1955
1956 /* Wideband speech support must be set per driver since it can't be
1957 * queried via hci.
1958 */
1959 if (data && (data->capabilities & QCA_CAP_WIDEBAND_SPEECH))
1960 set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, &hdev->quirks);
^^^^Potentially uninitialized here.
1961
1962 return 0;
1963 }
regards,
dan carpenter
Thanks for the heads-up Dan. Patch incoming to fix this.
Abhishek
Quoted 36 lines · Dan Carpenter
Hello Abhishek Pandit-Subedi,
The patch
a228f7a41029: "Bluetooth:hci_qca: Enable WBS support for wcn3991" from May 14, 2020, leads to the following static checker warning:
drivers/bluetooth/hci_qca.c:1960qca_serdev_probe()
error: uninitialized symbol 'hdev'.
drivers/bluetooth/hci_qca.c
1948 }
1949
1950 if (power_ctrl_enabled) {1951 hdev = qcadev->serdev_hu.hdev; ^^^^hdev is only initialized here.
1952
set_bit(HCI_QUIRK_NON_PERSISTENT_SETUP, &hdev->quirks);
1953hdev->shutdown=qca_power_off;
1954 }
1955
1956 /* Wideband speech support must be set per driver since it can't be
1957 * queried via hci.
1958 */
1959 if (data && (data->capabilities&QCA_CAP_WIDEBAND_SPEECH))1960 set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, &hdev->quirks); ^^^^Potentially uninitialized here.
1961
1962 return 0;
1963 }regards,
dan carpenter