qla2xxx: Remove return value from qla_nvme_ls()
Subsystems (2)
PATCH 1/1 qla2xxx: Remove return value from qla_nvme_ls()
The function always returns QLA_SUCCESS and the caller qla2x00_start_sp() doesn't even evalute the return value. So there is no point in returning a status.
--- drivers/scsi/qla2xxx/qla_iocb.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/scsi/qla2xxx/qla_iocb.c +1 -4
@@ -3607,11 +3607,10 @@ static void qla2x00_send_notify_ack_iocb(srb_t *sp,/* * Build NVME LS request */ -static int +static void qla_nvme_ls (srb_t *sp,struct pt_ls4_request *cmd_pkt) {struct srb_iocb *nvme; -int rval =QLA_SUCCESS ; nvme = &sp->u.iocb_cmd; cmd_pkt->entry_type =PT_LS4_REQUEST ;
@@ -3631,8 +3630,6 @@ qla_nvme_ls(srb_t *sp, struct pt_ls4_request *cmd_pkt) cmd_pkt->rx_byte_count =cpu_to_le32 (nvme->u.nvme.rsp_len); cmd_pkt->dsd[1 ].length =cpu_to_le32 (nvme->u.nvme.rsp_len);put_unaligned_le64 (nvme->u.nvme.rsp_dma, &cmd_pkt->dsd[1 ].address); - -return rval; } static void
Signature · 1 line
2.16.4
Looks good,
Quoted 3 lines · Daniel Wagner
The function always returns
QLA_SUCCESSand the callerqla2x00_start_sp()doesn't even evalute the return value. So there is no point in returning a status.
Quoted 38 lines · Daniel Wagner
The function always returns
QLA_SUCCESSand the callerqla2x00_start_sp()doesn't even evalute the return value. So there is no point in returning a status.Signed-off-by Daniel Wagner <[email protected]>--- drivers/scsi/qla2xxx/qla_iocb.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)drivers/scsi/qla2xxx/qla_iocb.c +1
-4@@ -3607,11 +3607,10 @@ static void qla2x00_send_notify_ack_iocb(srb_t *sp,/* * Build NVME LS request */ -static int +static void qla_nvme_ls (srb_t *sp,struct pt_ls4_request *cmd_pkt) {struct srb_iocb *nvme; -int rval =QLA_SUCCESS ; nvme = &sp->u.iocb_cmd; cmd_pkt->entry_type =PT_LS4_REQUEST ;@@ -3631,8 +3630,6 @@ qla_nvme_ls(srb_t *sp, struct pt_ls4_request *cmd_pkt) cmd_pkt->rx_byte_count =cpu_to_le32 (nvme->u.nvme.rsp_len); cmd_pkt->dsd[1 ].length =cpu_to_le32 (nvme->u.nvme.rsp_len);put_unaligned_le64 (nvme->u.nvme.rsp_dma, &cmd_pkt->dsd[1 ].address); - -return rval; } static voidSignature · 1 line
2.16.4
Thanks,
Roman
Daniel,
Quoted 6 lines · Daniel Wagner
The function always returns
QLA_SUCCESSand the callerqla2x00_start_sp()doesn't even evalute the return value. So there is no point in returning a status.Signed-off-by Daniel Wagner<[email protected]>---
Good Catch.
Signature · 1 line
Himanshu Madhani Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 3 lines · Daniel Wagner
The function always returns
QLA_SUCCESSand the callerqla2x00_start_sp()doesn't even evalute the return value. So there is no point in returning a status.
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: qla2xxx: Remove return value from qla_nvme_ls()
https://git.kernel.org/mkp/scsi/c/ac988c49367a
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering