Skip to contentSkip to conversation

ceph: flush release queue when handling caps for unknown inode

PATCH New Jeff Layton 1 participant 1 message May 20, 2020 Ceph client

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ceph: flush release queue when handling caps for unknown inode

It's possible for the VFS to completely forget about an inode, but for it to still be sitting on the cap release queue. If the MDS sends the client a cap message for such an inode, it just ignores it today, which can lead to a stall of up to 5s until the cap release queue is flushed.

If we get a cap message for an inode that can't be located, then go ahead and flush the cap release queue.

Fixes 1e9c2eb6811e ("ceph: delete stale dentry when last reference is dropped")
---
 fs/ceph/caps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ceph/caps.c +1 -1
index 27c2e60f33dc..41eb999dadf0 100644
@@ -4070,7 +4070,7 @@ void ceph_handle_caps(struct ceph_mds_session *session,
 			__ceph_queue_cap_release(session, cap);
 			spin_unlock(&session->s_cap_lock);
 		}
-		goto done;
+		goto flush_cap_releases;
 	}
 
 	/* these will work even if we don't have a cap yet */
Signature · 1 line
2.26.2