Restore support for running tests without prior test results
PATCH 1/1 Restore support for running tests without prior test results
This patch fixes the following runtime error:
./check: line 245: LAST_TEST_RUN: unbound variable
--- check | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
check +7 -1
@@ -240,9 +240,15 @@ _output_last_test_run() { } _output_test_run() { + local param_count if [[ -t 1 ]]; then # Move the cursor back up to the status. - tput cuu $((${#LAST_TEST_RUN[@]} + 1)) + if [ -n "${LAST_TEST_RUN+set}" ]; then + param_count=${#LAST_TEST_RUN[@]} + else + param_count=0 + fi + tput cuu $((param_count + 1)) fi local status=${TEST_RUN["status"]}
Quoted 22 lines · Bart Van Assche
This patch fixes the following runtime error:
./check: line 245:
LAST_TEST_RUN: unbound variableFixes 203b5723a28e ("Show last run for skipped tests")Signed-off-by Bart Van Assche <[email protected]>--- check | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)check +1
-0@@ -240,9 +240,15 @@ _output_last_test_run() { } _output_test_run() { + local param_count if [[ -t 1 ]]; then # Move the cursor back up to the status.
check _output_last_test_run() { · line 254
Quoted 10 lines
check +6
-1- tput cuu $((${#LAST_TEST_RUN[@]} + 1)) + if [ -n "${LAST_TEST_RUN+set}" ]; then + param_count=${#LAST_TEST_RUN[@]} + else + param_count=0 + fi + tput cuu $((param_count + 1)) fi local status=${TEST_RUN["status"]}
Omar, ping?
Quoted 15 lines · Bart Van Assche
This patch fixes the following runtime error:
./check: line 245:
LAST_TEST_RUN: unbound variableFixes 203b5723a28e ("Show last run for skipped tests")Signed-off-by Bart Van Assche <[email protected]>--- check | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)check +0
-0
check _output_last_test_run() { · line 243
Quoted 4 lines
check +1
-0@@ -240,9 +240,15 @@ _output_last_test_run() { } _output_test_run() { + local param_count
Is there any particular reason why new line is not added after variable declaration ? (I see that check file is not strict about that, which it should be to start with).
check _output_last_test_run() { · line 254
Quoted 12 lines
check +5
-1if [[ -t 1 ]]; then # Move the cursor back up to the status. - tput cuu $((${#LAST_TEST_RUN[@]} + 1)) + if [ -n "${LAST_TEST_RUN+set}" ]; then + param_count=${#LAST_TEST_RUN[@]} + else + param_count=0 > + fi + tput cuu $((param_count + 1)) fi local status=${TEST_RUN["status"]}
Overall patch looks good, I've tested it with nvme group which works fine.
Quoted 31 lines · Bart Van Assche
Quoted 30 lines · Bart Van Assche
This patch fixes the following runtime error:
./check: line 245:
LAST_TEST_RUN: unbound variableFixes 203b5723a28e ("Show last run for skipped tests")Signed-off-by Bart Van Assche <[email protected]>--- check | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)check +7
-1@@ -240,9 +240,15 @@ _output_last_test_run() { } _output_test_run() { + local param_count if [[ -t 1 ]]; then # Move the cursor back up to the status. - tput cuu $((${#LAST_TEST_RUN[@]} + 1)) + if [ -n "${LAST_TEST_RUN+set}" ]; then + param_count=${#LAST_TEST_RUN[@]} + else + param_count=0 + fi + tput cuu $((param_count + 1)) fi
Quoted 4 lines
check _output_last_test_run() { · line 254
Quoted 2 lines
check +0
-0local status=${TEST_RUN["status"]}Omar, ping?
Sorry Bart, I had a family emergency so I've been away for a few weeks. This fix didn't work for me for the same reason that Li Zhijian reported in https://github.com/osandov/blktests/pull/64. For now I'm going to apply that fix instead. If you'd like blktests to work with set -u, please do so by adding it to the main check script and modifying the rest of the framework.