tunes: Add new tune files for cortexa55 and cortexa73-cortexa53
PATCH 1/10 tunes: Add new tune files for cortexa55 and cortexa73-cortexa53
--- meta/conf/machine/include/tune-cortexa55.inc | 17 ++++++++++++++ .../include/tune-cortexa73-cortexa53.inc | 23 +++++++++++++++++++ 2 files changed, 40 insertions(+) create mode 100644 meta/conf/machine/include/tune-cortexa55.inc create mode 100644 meta/conf/machine/include/tune-cortexa73-cortexa53.inc
meta/conf/machine/include/tune-cortexa55.inc new file +17 -0
@@ -0,0 +1,17 @@ +DEFAULTTUNE ?= "cortexa55" + +TUNEVALID[cortexa55] = "Enable Cortex-A55 specific processor optimizations" +TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'cortexa55', ' -mcpu=cortex-a55', '', d)}" + +require conf/machine/include/arm/arch-armv8a.inc + +# Little Endian base configs +AVAILTUNES += "cortexa55 cortexa55-crypto" +ARMPKGARCH_tune-cortexa55 = "cortexa55" +ARMPKGARCH_tune-cortexa55-crypto = "cortexa55" +TUNE_FEATURES_tune-cortexa55 = "aarch64 cortexa55 crc" +TUNE_FEATURES_tune-cortexa55-crypto = "aarch64 cortexa55 crc crypto" +PACKAGE_EXTRA_ARCHS_tune-cortexa55 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa55" +PACKAGE_EXTRA_ARCHS_tune-cortexa55-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa55 cortexa55-crypto" +BASE_LIB_tune-cortexa55 = "lib64" +BASE_LIB_tune-cortexa55-crypto = "lib64"
meta/conf/machine/include/tune-cortexa73-cortexa53.inc new file +23 -0
@@ -0,0 +1,23 @@ +DEFAULTTUNE ?= "cortexa73-cortexa53" + +require conf/machine/include/arm/arch-armv8a.inc + +TUNEVALID[cortexa73-cortexa53] = "Enable big.LITTLE Cortex-A73.Cortex-A53 specific processor optimizations" + +TUNECONFLICTS[aarch64] = "armv4 armv5 armv6 armv7 armv7a" + +MACHINEOVERRIDES =. "${@bb.utils.contains("TUNE_FEATURES", "cortexa73-cortexa53", "cortexa73-cortexa53:", "" ,d)}" + +TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "cortexa73-cortexa53", " -mtune=cortex-a73.cortex-a53", "", d)}" + +# cortexa73.cortexa53 implies crc support +AVAILTUNES += "cortexa73-cortexa53 cortexa73-cortexa53-crypto" +ARMPKGARCH_tune-cortexa73-cortexa53 = "cortexa73-cortexa53" +ARMPKGARCH_tune-cortexa73-cortexa53-crypto = "cortexa73-cortexa53" +TUNE_FEATURES_tune-cortexa73-cortexa53 = "${TUNE_FEATURES_tune-armv8a-crc} cortexa73-cortexa53" +TUNE_FEATURES_tune-cortexa73-cortexa53-crypto = "${TUNE_FEATURES_tune-armv8a-crc-crypto} cortexa73-cortexa53" +PACKAGE_EXTRA_ARCHS_tune-cortexa73-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa73-cortexa53" +PACKAGE_EXTRA_ARCHS_tune-cortexa73-cortexa53-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa73-cortexa53 cortexa73-cortexa53-crypto" +BASE_LIB_tune-cortexa73-cortexa53 = "lib64" +BASE_LIB_tune-cortexa73-cortexa53-crypto = "lib64" +
Signature · 1 line
2.26.2
PATCH 2/10 gcc-runtime: Avoid march conflicts with newer cortex-a55 CPUs
gcc-runtime/libatomic explicitly add -march=armv8-a+lse for all arch64 but cortex-a55 is armv8.2-a, which essentially conflicts, so let gcc override it by not forcing the -mcpu option from TUNE_CCARGS
--- meta/recipes-devtools/gcc/gcc-runtime.inc | 4 ++++ 1 file changed, 4 insertions(+)
meta/recipes-devtools/gcc/gcc-runtime.inc +4 -0
@@ -18,6 +18,10 @@ EXTRA_OECONF_append_linuxstdbase = " --enable-clocale=gnu" EXTRA_OECONF_append = " --cache-file=${B}/config.cache" EXTRA_OECONF_append_libc-newlib = " --with-newlib" +# cortex-a55 is ARMv8.2-a based but libatomic explicitly asks for -march=armv8.1-a +# which caused -march conflicts in gcc +TUNE_CCARGS_remove = "-mcpu=cortex-a55+crc -mcpu=cortex-a55 -mcpu=cortex-a55+crc+crypto" + # Disable ifuncs for libatomic on arm conflicts -march/-mcpu EXTRA_OECONF_append_arm = " libat_cv_have_ifunc=no " EXTRA_OECONF_append_armeb = " libat_cv_have_ifunc=no "
Signature · 1 line
2.26.2
PATCH 3/10 glibc: Update to latest on 2.31 branch
In reply to Khem RajThere are few fixes specifically for compiling with gcc10 that are good to have, before hitting them later
Backport build fix from master for aarch64 with gcc10
Drop CVE-2020-10029 patch its already applied on latest 2.31 branch
latest glibc 2.31 added fix for __getauxval/aarch64 issue
--- meta/recipes-core/glibc/glibc-version.inc | 2 +- .../0030-Improve-IFUNC-check-BZ-25506.patch | 47 ----- ...-with-GCC-10-when-long-double-double.patch | 170 ------------------ .../glibc/glibc/CVE-2020-10029.patch | 128 ------------- meta/recipes-core/glibc/glibc_2.31.bb | 3 - 5 files changed, 1 insertion(+), 349 deletions(-) delete mode 100644 meta/recipes-core/glibc/glibc/0030-Improve-IFUNC-check-BZ-25506.patch delete mode 100644 meta/recipes-core/glibc/glibc/0031-Fix-build-with-GCC-10-when-long-double-double.patch delete mode 100644 meta/recipes-core/glibc/glibc/CVE-2020-10029.patch
meta/recipes-core/glibc/glibc-version.inc +1 -1
@@ -1,6 +1,6 @@ SRCBRANCH ?= "release/2.31/master" PV = "2.31+git${SRCPV}" -SRCREV_glibc ?= "71f2b249a28e17eac0e47c53af44d5c5b65101aa" +SRCREV_glibc ?= "109474122400ca7d60782b131dc867a5c1f2fe55" SRCREV_localedef ?= "cd9f958c4c94a638fa7b2b4e21627364f1a1a655" GLIBC_GIT_URI ?= "git://sourceware.org/git/glibc.git"
meta/recipes-core/glibc/glibc/0030-Improve-IFUNC-check-BZ-25506.patch deleted +0 -47
47 lines not on this page · raw message
meta/recipes-core/glibc/glibc/0031-Fix-build-with-GCC-10-when-long-double-double.patch deleted +0 -170
170 lines not on this page · raw message
meta/recipes-core/glibc/glibc/CVE-2020-10029.patch deleted +0 -128
128 lines not on this page · raw message
meta/recipes-core/glibc/glibc_2.31.bb +0 -3
@@ -40,9 +40,6 @@ SRC_URI = "${GLIBC_GIT_URI};branch=${SRCBRANCH};name=glibc \ file://0027-intl-Emit-no-lines-in-bison-generated-files.patch \ file://0028-inject-file-assembly-directives.patch \ file://0029-locale-prevent-maybe-uninitialized-errors-with-Os-BZ.patch \ - file://CVE-2020-10029.patch \ - file://0030-Improve-IFUNC-check-BZ-25506.patch \ - file://0031-Fix-build-with-GCC-10-when-long-double-double.patch \ " S = "${WORKDIR}/git" B = "${WORKDIR}/build-${TARGET_SYS}"
Signature · 1 line
2.26.2
PATCH 4/10 wayland: fix condition for strndup detection
In reply to Khem Rajcurrent check does not work with gcc10
--- .../0001-build-Fix-strndup-detection-on-MinGW.patch | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
meta/recipes-graphics/wayland/wayland/0001-build-Fix-strndup-detection-on-MinGW.patch +1 -6
@@ -17,8 +17,6 @@ Upstream-Status: Submitted [https://gitlab.freedesktop.org/wayland/wayland/merge meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -diff --git a/meson.build b/meson.build -index 26b084f..c05d019 100644 --- a/meson.build +++ b/meson.build @@ -36,11 +36,11 @@ have_funcs = [
@@ -30,10 +28,7 @@ index 26b084f..c05d019 100644 foreach f: have_funcs config_h.set('HAVE_' + f.underscorify().to_upper(), cc.has_function(f)) endforeach -+config_h.set('HAVE_STRNDUP', cc.has_function('strndup', prefix:'#include <string.h>')) ++config_h.set('HAVE_STRNDUP', cc.has_function('strndup') and cc.has_header_symbol('string.h', 'strndup')) if get_option('libraries') ffi_dep = dependency('libffi') --- -2.17.1 -
Signature · 1 line
2.26.2
PATCH 5/10 tune-cortexa55.inc: crc and crypto extentions are default on cortex-a55
In reply to Khem Raj--- meta/conf/machine/include/tune-cortexa55.inc | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
meta/conf/machine/include/tune-cortexa55.inc +3 -7
@@ -6,12 +6,8 @@ TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'cortexa55', ' -mcpu=corte require conf/machine/include/arm/arch-armv8a.inc # Little Endian base configs -AVAILTUNES += "cortexa55 cortexa55-crypto" +AVAILTUNES += "cortexa55" ARMPKGARCH_tune-cortexa55 = "cortexa55" -ARMPKGARCH_tune-cortexa55-crypto = "cortexa55" -TUNE_FEATURES_tune-cortexa55 = "aarch64 cortexa55 crc" -TUNE_FEATURES_tune-cortexa55-crypto = "aarch64 cortexa55 crc crypto" -PACKAGE_EXTRA_ARCHS_tune-cortexa55 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa55" -PACKAGE_EXTRA_ARCHS_tune-cortexa55-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa55 cortexa55-crypto" +TUNE_FEATURES_tune-cortexa55 = "aarch64 cortexa55 crc crypto" +PACKAGE_EXTRA_ARCHS_tune-cortexa55 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa55" BASE_LIB_tune-cortexa55 = "lib64" -BASE_LIB_tune-cortexa55-crypto = "lib64"
Signature · 1 line
2.26.2
PATCH 6/10 tune-cortexa57.inc: Add new tune file
In reply to Khem Raj--- meta/conf/machine/include/tune-cortexa57.inc | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 meta/conf/machine/include/tune-cortexa57.inc
meta/conf/machine/include/tune-cortexa57.inc new file +17 -0
@@ -0,0 +1,17 @@ +DEFAULTTUNE ?= "cortexa57" + +TUNEVALID[cortexa57] = "Enable Cortex-A57 specific processor optimizations" +TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'cortexa57', ' -mcpu=cortex-a57', '', d)}" + +require conf/machine/include/arm/arch-armv8a.inc + +# Little Endian base configs +AVAILTUNES += "cortexa57 cortexa57-crypto" +ARMPKGARCH_tune-cortexa57 = "cortexa57" +ARMPKGARCH_tune-cortexa57-crypto = "cortexa57" +TUNE_FEATURES_tune-cortexa57 = "aarch64 cortexa57 crc" +TUNE_FEATURES_tune-cortexa57-crypto = "aarch64 cortexa57 crc crypto" +PACKAGE_EXTRA_ARCHS_tune-cortexa57 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa57" +PACKAGE_EXTRA_ARCHS_tune-cortexa57-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa57 cortexa57-crypto" +BASE_LIB_tune-cortexa57 = "lib64" +BASE_LIB_tune-cortexa57-crypto = "lib64"
Signature · 1 line
2.26.2
PATCH 7/10 aarch64: Adjust big.LITTLE tune files to use -mcpu
In reply to Khem Rajmcpu is more appropriate on aarch64 and generates more optimized code forr a given SOC, unlike -march/-mtune combination as decribed here [1]
--- .../conf/machine/include/tune-cortexa57-cortexa53.inc | 9 +++------ .../conf/machine/include/tune-cortexa72-cortexa53.inc | 11 ++++------- .../conf/machine/include/tune-cortexa73-cortexa53.inc | 11 ++++------- 3 files changed, 11 insertions(+), 20 deletions(-)
meta/conf/machine/include/tune-cortexa57-cortexa53.inc +3 -6
@@ -1,18 +1,15 @@ DEFAULTTUNE ?= "cortexa57-cortexa53" -require conf/machine/include/arm/arch-armv8a.inc TUNEVALID[cortexa57-cortexa53] = "Enable big.LITTLE Cortex-A57.Cortex-A53 specific processor optimizations" TUNECONFLICTS[aarch64] = "armv4 armv5 armv6 armv7 armv7a" - -TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "aarch64", " -march=armv8-a", "" ,d)}" - +TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "cortexa57-cortexa53", " -mcpu=cortex-a57.cortex-a53", "", d)}" MACHINEOVERRIDES =. "${@bb.utils.contains("TUNE_FEATURES", "cortexa57-cortexa53", "cortexa57-cortexa53:", "" ,d)}" -TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "cortexa57-cortexa53", " -mtune=cortex-a57.cortex-a53", "", d)}" +require conf/machine/include/arm/arch-armv8a.inc # Little Endian base configs AVAILTUNES += "cortexa57-cortexa53" ARMPKGARCH_tune-cortexa57-cortexa53 = "cortexa57-cortexa53" -TUNE_FEATURES_tune-cortexa57-cortexa53 = "${TUNE_FEATURES_tune-aarch64} cortexa57-cortexa53" +TUNE_FEATURES_tune-cortexa57-cortexa53 = "aarch64 cortexa57-cortexa53" PACKAGE_EXTRA_ARCHS_tune-cortexa57-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-aarch64} cortexa57-cortexa53" BASE_LIB_tune-cortexa57-cortexa53 = "lib64"
meta/conf/machine/include/tune-cortexa72-cortexa53.inc +4 -7
@@ -1,21 +1,18 @@ DEFAULTTUNE ?= "cortexa72-cortexa53" -require conf/machine/include/arm/arch-armv8a.inc - TUNEVALID[cortexa72-cortexa53] = "Enable big.LITTLE Cortex-A72.Cortex-A53 specific processor optimizations" - TUNECONFLICTS[aarch64] = "armv4 armv5 armv6 armv7 armv7a" - +TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", " -mcpu=cortex-a72.cortex-a53", "", d)}" MACHINEOVERRIDES =. "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", "cortexa72-cortexa53:", "" ,d)}" -TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", " -mtune=cortex-a72.cortex-a53", "", d)}" +require conf/machine/include/arm/arch-armv8a.inc # cortexa72.cortexa53 implies crc support AVAILTUNES += "cortexa72-cortexa53 cortexa72-cortexa53-crypto" ARMPKGARCH_tune-cortexa72-cortexa53 = "cortexa72-cortexa53" ARMPKGARCH_tune-cortexa72-cortexa53-crypto = "cortexa72-cortexa53" -TUNE_FEATURES_tune-cortexa72-cortexa53 = "${TUNE_FEATURES_tune-armv8a-crc} cortexa72-cortexa53" -TUNE_FEATURES_tune-cortexa72-cortexa53-crypto = "${TUNE_FEATURES_tune-armv8a-crc-crypto} cortexa72-cortexa53" +TUNE_FEATURES_tune-cortexa72-cortexa53 = "aarch64 crc cortexa72-cortexa53" +TUNE_FEATURES_tune-cortexa72-cortexa53-crypto = "aarch64 crc crypto cortexa72-cortexa53" PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa72-cortexa53" PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa72-cortexa53 cortexa72-cortexa53-crypto" BASE_LIB_tune-cortexa72-cortexa53 = "lib64"
meta/conf/machine/include/tune-cortexa73-cortexa53.inc +4 -7
@@ -1,21 +1,18 @@ DEFAULTTUNE ?= "cortexa73-cortexa53" -require conf/machine/include/arm/arch-armv8a.inc - TUNEVALID[cortexa73-cortexa53] = "Enable big.LITTLE Cortex-A73.Cortex-A53 specific processor optimizations" - TUNECONFLICTS[aarch64] = "armv4 armv5 armv6 armv7 armv7a" - MACHINEOVERRIDES =. "${@bb.utils.contains("TUNE_FEATURES", "cortexa73-cortexa53", "cortexa73-cortexa53:", "" ,d)}" +TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "cortexa73-cortexa53", " -mcpu=cortex-a73.cortex-a53", "", d)}" -TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "cortexa73-cortexa53", " -mtune=cortex-a73.cortex-a53", "", d)}" +require conf/machine/include/arm/arch-armv8a.inc # cortexa73.cortexa53 implies crc support AVAILTUNES += "cortexa73-cortexa53 cortexa73-cortexa53-crypto" ARMPKGARCH_tune-cortexa73-cortexa53 = "cortexa73-cortexa53" ARMPKGARCH_tune-cortexa73-cortexa53-crypto = "cortexa73-cortexa53" -TUNE_FEATURES_tune-cortexa73-cortexa53 = "${TUNE_FEATURES_tune-armv8a-crc} cortexa73-cortexa53" -TUNE_FEATURES_tune-cortexa73-cortexa53-crypto = "${TUNE_FEATURES_tune-armv8a-crc-crypto} cortexa73-cortexa53" +TUNE_FEATURES_tune-cortexa73-cortexa53 = "aarch64 crc cortexa73-cortexa53" +TUNE_FEATURES_tune-cortexa73-cortexa53-crypto = "aarch64 crc crypto cortexa73-cortexa53" PACKAGE_EXTRA_ARCHS_tune-cortexa73-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa73-cortexa53" PACKAGE_EXTRA_ARCHS_tune-cortexa73-cortexa53-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa73-cortexa53 cortexa73-cortexa53-crypto" BASE_LIB_tune-cortexa73-cortexa53 = "lib64"
Signature · 1 line
2.26.2
PATCH 8/10 armv8/tunes: Define TUNE_PKGARCH
In reply to Khem RajNow that they uses -mcpu, its better to have tune specific build directories, since aarch64 wont be appropriate any longer
--- meta/conf/machine/include/tune-cortexa53.inc | 4 ++++ meta/conf/machine/include/tune-cortexa55.inc | 1 + meta/conf/machine/include/tune-cortexa57-cortexa53.inc | 1 + meta/conf/machine/include/tune-cortexa57.inc | 2 ++ meta/conf/machine/include/tune-cortexa72-cortexa53.inc | 2 ++ meta/conf/machine/include/tune-cortexa72.inc | 1 + meta/conf/machine/include/tune-cortexa73-cortexa53.inc | 2 ++ 7 files changed, 13 insertions(+)
meta/conf/machine/include/tune-cortexa53.inc +4 -0
@@ -13,5 +13,9 @@ TUNE_FEATURES_tune-cortexa53 = "aarch64 cortexa53 crc" TUNE_FEATURES_tune-cortexa53-crypto = "aarch64 cortexa53 crc crypto" PACKAGE_EXTRA_ARCHS_tune-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa53" PACKAGE_EXTRA_ARCHS_tune-cortexa53-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa53 cortexa53-crypto" + +TUNE_PKGARCH_tune-cortexa53 = "cortexa53" +TUNE_PKGARCH_tune-cortexa53-crypto = "cortexa53-crypto" + BASE_LIB_tune-cortexa53 = "lib64" BASE_LIB_tune-cortexa53-crypto = "lib64"
meta/conf/machine/include/tune-cortexa55.inc +1 -0
@@ -9,5 +9,6 @@ require conf/machine/include/arm/arch-armv8a.inc AVAILTUNES += "cortexa55" ARMPKGARCH_tune-cortexa55 = "cortexa55" TUNE_FEATURES_tune-cortexa55 = "aarch64 cortexa55 crc crypto" +TUNE_PKGARCH_tune-cortexa55 = "cortexa55" PACKAGE_EXTRA_ARCHS_tune-cortexa55 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa55" BASE_LIB_tune-cortexa55 = "lib64"
meta/conf/machine/include/tune-cortexa57-cortexa53.inc +1 -0
@@ -11,5 +11,6 @@ require conf/machine/include/arm/arch-armv8a.inc AVAILTUNES += "cortexa57-cortexa53" ARMPKGARCH_tune-cortexa57-cortexa53 = "cortexa57-cortexa53" TUNE_FEATURES_tune-cortexa57-cortexa53 = "aarch64 cortexa57-cortexa53" +TUNE_PKGARCH_tune-cortexa57-cortexa53 = "cortexa57-cortexa53" PACKAGE_EXTRA_ARCHS_tune-cortexa57-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-aarch64} cortexa57-cortexa53" BASE_LIB_tune-cortexa57-cortexa53 = "lib64"
meta/conf/machine/include/tune-cortexa57.inc +2 -0
@@ -13,5 +13,7 @@ TUNE_FEATURES_tune-cortexa57 = "aarch64 cortexa57 crc" TUNE_FEATURES_tune-cortexa57-crypto = "aarch64 cortexa57 crc crypto" PACKAGE_EXTRA_ARCHS_tune-cortexa57 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa57" PACKAGE_EXTRA_ARCHS_tune-cortexa57-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa57 cortexa57-crypto" +TUNE_PKGARCH_tune-cortexa57 = "cortexa57" +TUNE_PKGARCH_tune-cortexa57-crypto = "cortexa57-crypto" BASE_LIB_tune-cortexa57 = "lib64" BASE_LIB_tune-cortexa57-crypto = "lib64"
meta/conf/machine/include/tune-cortexa72-cortexa53.inc +2 -0
@@ -15,6 +15,8 @@ TUNE_FEATURES_tune-cortexa72-cortexa53 = "aarch64 crc cortexa72-co TUNE_FEATURES_tune-cortexa72-cortexa53-crypto = "aarch64 crc crypto cortexa72-cortexa53" PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa72-cortexa53" PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa72-cortexa53 cortexa72-cortexa53-crypto" +TUNE_PKGARCH_tune-cortexa72-cortexa53 = "cortexa72-cortexa53" +TUNE_PKGARCH_tune-cortexa72-cortexa53-crypto = "cortexa72-cortexa53-crypto" BASE_LIB_tune-cortexa72-cortexa53 = "lib64" BASE_LIB_tune-cortexa72-cortexa53-crypto = "lib64"
meta/conf/machine/include/tune-cortexa72.inc +1 -0
@@ -10,4 +10,5 @@ AVAILTUNES += "cortexa72" ARMPKGARCH_tune-cortexa72 = "cortexa72" TUNE_FEATURES_tune-cortexa72 = "aarch64 cortexa72 crc crypto" PACKAGE_EXTRA_ARCHS_tune-cortexa72 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa72" +TUNE_PKGARCH_tune-cortexa72 = "cortexa72" BASE_LIB_tune-cortexa72 = "lib64"
meta/conf/machine/include/tune-cortexa73-cortexa53.inc +2 -0
@@ -15,6 +15,8 @@ TUNE_FEATURES_tune-cortexa73-cortexa53 = "aarch64 crc cortexa73-co TUNE_FEATURES_tune-cortexa73-cortexa53-crypto = "aarch64 crc crypto cortexa73-cortexa53" PACKAGE_EXTRA_ARCHS_tune-cortexa73-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa73-cortexa53" PACKAGE_EXTRA_ARCHS_tune-cortexa73-cortexa53-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa73-cortexa53 cortexa73-cortexa53-crypto" +TUNE_PKGARCH_tune-cortexa73-cortexa53 = "cortexa73-cortexa53" +TUNE_PKGARCH_tune-cortexa73-cortexa53-crypto = "cortexa73-cortexa53-crypto" BASE_LIB_tune-cortexa73-cortexa53 = "lib64" BASE_LIB_tune-cortexa73-cortexa53-crypto = "lib64"
Signature · 1 line
2.26.2
Re: [OE-core] [dunfell][ 08/10] armv8/tunes: Define TUNE_PKGARCH
Quoted 3 lines · Khem Raj
Now that they uses -mcpu, its better to have tune specific build directories, since aarch64 wont be appropriate any longer
I agree with Steve that this is a bit invasive for stable branch, but on the other hand it's long overdue and if we don't improve it in LTS branch then many people will need to carry local work arounds for multi-machine builds. +1 from me.
Once the LAYERVERSION_core is bumped because of those python modules, then BSPs will also be able to depend on newer version of oe-core when they start using one of new tune files.
Re: [OE-core] [dunfell][ 08/10] armv8/tunes: Define TUNE_PKGARCH
Quoted 9 lines · Martin Jansa
Quoted 2 lines · Khem Raj
Now that they uses -mcpu, its better to have tune specific build directories, since aarch64 wont be appropriate any longer
I agree with Steve that this is a bit invasive for stable branch, but on the other hand it's long overdue and if we don't improve it in LTS branch then many people will need to carry local work arounds for multi-machine builds. +1 from me.
But this is against the LTS/Stable branch policy. What is the point of having a policy if we are going to keep making exceptions? There'd be other changes as well for which people might be carrying work-arounds. Would we be willing to make exceptions for all?
Thanks,
Anuj
Re: [OE-core] [dunfell][ 08/10] armv8/tunes: Define TUNE_PKGARCH
Quoted 12 lines · Anuj
Quoted 9 lines · Martin Jansa
Quoted 2 lines · Khem Raj
Now that they uses -mcpu, its better to have tune specific build directories, since aarch64 wont be appropriate any longer
I agree with Steve that this is a bit invasive for stable branch, but on the other hand it's long overdue and if we don't improve it in LTS branch then many people will need to carry local work arounds for multi-machine builds. +1 from me.
Quoted 5 lines
But this is against the LTS/Stable branch policy. What is the point of having a policy if we are going to keep making exceptions? There'd be other changes as well for which people might be carrying work-arounds. Would we be willing to make exceptions for all?
Thanks for bringing this up. Policy exceptions are not common but they are not absent either
hence context is important for such changes, I am definitely interested to hear about how it is going to affect arm64 users at this early stage of release. if someone
is broken due to these changes that should be addressed.
Quoted 3 lines
Thanks,
Anuj
Re: [OE-core] [dunfell][ 08/10] armv8/tunes: Define TUNE_PKGARCH
Quoted 26 lines · Khem Raj
Quoted 15 lines · Anuj
Quoted 6 lines · Martin Jansa
Quoted 3 lines · Khem Raj
Now that they uses -mcpu, its better to have tune specific build
directories, since aarch64 wont be appropriate any longerQuoted 7 lines
I agree with Steve that this is a bit invasive for stable branch, but
on the other hand it's long overdue and if we don't improve it in LTS
branch then many people will need to carry local work arounds for multi-machine builds. +1 from me.Quoted 8 lines
But this is against the LTS/Stable branch policy. What is the point of
having a policy if we are going to keep making exceptions? There'd be
other changes as well for which people might be carrying work- arounds.
Would we be willing to make exceptions for all?
Quoted 2 lines
Thanks for bringing this up. Policy exceptions are not common but they
That's two exceptions in a week.
I am not against the change but I think the policy document should be modified to define how exceptions should/will be handled.
Quoted 5 lines
are not absent either
hence context is important for such changes, I am definitely interested to hear
about how it is going to affect arm64 users at this early stage of release.
The release has been made and I think the branch is assumed to be stable from the time it was released and policy should be applied? There's no early release stage defined where-in such changes would be acceptable.
Thanks,
Anuj
Re: [OE-core] [dunfell][ 08/10] armv8/tunes: Define TUNE_PKGARCH
Quoted 47 lines · Anuj
Quoted 32 lines · Khem Raj
On Thu, May 21, 2020 at 4:49 PM Mittal, Anuj <[email protected]
Quoted 1 line
Quoted 18 lines · wrote:
Quoted 6 lines · Martin Jansa
Quoted 3 lines · Khem Raj
Now that they uses -mcpu, its better to have tune specific build
directories, since aarch64 wont be appropriate any longerQuoted 10 lines
I agree with Steve that this is a bit invasive for stable branch,
but
on the other hand it's long overdue and if we don't improve it in
LTS
branch then many people will need to carry local work arounds for
multi-machine builds. +1 from me.Quoted 10 lines
But this is against the LTS/Stable branch policy. What is the point
of
having a policy if we are going to keep making exceptions? There'd
be
other changes as well for which people might be carrying work- arounds.
Would we be willing to make exceptions for all?Quoted 2 lines
Thanks for bringing this up. Policy exceptions are not common but they
That's two exceptions in a week.
I am not against the change but I think the policy document should be modified to define how exceptions should/will be handled.
Quoted 5 lines
are not absent either
hence context is important for such changes, I am definitely interested to hear
about how it is going to affect arm64 users at this early stage of release.
Quoted 4 lines
The release has been made and I think the branch is assumed to be stable from the time it was released and policy should be applied? There's no early release stage defined where-in such changes would be acceptable.
This series doesn't have a decision on it yet. If an exception were made, it would be two exceptions in the lifetime of the LTS so far, not just a week. The fact we'd like to make a point release is focusing the fact we need to make some decisions rather than a sudden stream of policy exceptions.
I'd also note its most likely we'd find issues just after release as people start using things, over time it becomes much less likely.
If such issues are identified, particularly now as people start using it, the question is what we do about it. If we can fix things to improve things for users and the risk is either low, or managed to a specific subset of users who can benefit, that does seem like a sensible thing to do.
I guess I'd hoped we could all be sensible about these things, the LTS policy is there as a set of 'guide rails' to make decisions against but as a maintainer, I know that not everything that makes sense neatly fits within a written set of rules. The LTS maintainer does need to have some ability to make decisions and I've always thought it was clear the TSCs are the ultimate decision makers for any technical decision the project faces should there not be consensus.
In the case of these patches I'm not seeing anyone arguing against them on technical grounds or saying they don't make sense other than some things I've said to Steve! The complaint is that they break policy.
I will discuss making a escalation and final decision path clearer with the YP TSC (who wrote/maintain the policy).
Cheers,
Richard
Re: [OE-core] [dunfell][ 08/10] armv8/tunes: Define TUNE_PKGARCH
Quoted 69 lines · Richard Purdie
Quoted 47 lines · Anuj
Quoted 32 lines · Khem Raj
On Thu, May 21, 2020 at 4:49 PM Mittal, Anuj <[email protected]
Quoted 1 line
Quoted 18 lines · wrote:
Quoted 6 lines · Martin Jansa
Quoted 3 lines · Khem Raj
Now that they uses -mcpu, its better to have tune specific build
directories, since aarch64 wont be appropriate any longerQuoted 10 lines
I agree with Steve that this is a bit invasive for stable branch,
but
on the other hand it's long overdue and if we don't improve it in
LTS
branch then many people will need to carry local work arounds for
multi-machine builds. +1 from me.Quoted 10 lines
But this is against the LTS/Stable branch policy. What is the point
of
having a policy if we are going to keep making exceptions? There'd
be
other changes as well for which people might be carrying work- arounds.
Would we be willing to make exceptions for all?Quoted 2 lines
Thanks for bringing this up. Policy exceptions are not common but they
That's two exceptions in a week.
I am not against the change but I think the policy document should be modified to define how exceptions should/will be handled.
Quoted 5 lines
are not absent either
hence context is important for such changes, I am definitely interested to hear
about how it is going to affect arm64 users at this early stage of release.Quoted 4 lines
The release has been made and I think the branch is assumed to be stable from the time it was released and policy should be applied? There's no early release stage defined where-in such changes would be acceptable.
This series doesn't have a decision on it yet. If an exception were made, it would be two exceptions in the lifetime of the LTS so far, not just a week. The fact we'd like to make a point release is focusing the fact we need to make some decisions rather than a sudden stream of policy exceptions.
I'd also note its most likely we'd find issues just after release as people start using things, over time it becomes much less likely.
If such issues are identified, particularly now as people start using it, the question is what we do about it. If we can fix things to improve things for users and the risk is either low, or managed to a specific subset of users who can benefit, that does seem like a sensible thing to do.
Quoted 7 lines
I guess I'd hoped we could all be sensible about these things, the LTS policy is there as a set of 'guide rails' to make decisions against but as a maintainer, I know that not everything that makes sense neatly fits within a written set of rules. The LTS maintainer does need to have some ability to make decisions and I've always thought it was clear the TSCs are the ultimate decision makers for any technical decision the project faces should there not be consensus.
downstream distros will require such things for supporting their products, in past it was done on their chosen release and they stayed with that release with their own delta, the hope is that they will use LTS and just from LTS to LTS in product cycles. IMO LTS will have to considerate to this fact, if we do not want downstream distros to diverge significantly and if we want to put hard conditions early on release then I guess users will have to devise their own plans regardless of LTS.
e.g. See the delta between ubuntu
LTS first point release ( 20.04 and 20.04.1 ), most users wait for first point release to migrate to next LTS there is a reason for that.
There is quite a bit of stabilization that happens
early on in LTS life.
Quoted 17 lines
In the case of these patches I'm not seeing anyone arguing against them on technical grounds or saying they don't make sense other than some things I've said to Steve! The complaint is that they break policy.
I will discuss making a escalation and final decision path clearer with the YP TSC (who wrote/maintain the policy).
Cheers,
Richard
Re: [OE-core] [dunfell][ 08/10] armv8/tunes: Define TUNE_PKGARCH
In reply to Anuj MittalQuoted 42 lines · Anuj
Quoted 26 lines · Khem Raj
Quoted 15 lines · Anuj
Quoted 6 lines · Martin Jansa
Quoted 3 lines · Khem Raj
Now that they uses -mcpu, its better to have tune specific build
directories, since aarch64 wont be appropriate any longerQuoted 7 lines
I agree with Steve that this is a bit invasive for stable branch, but
on the other hand it's long overdue and if we don't improve it in LTS
branch then many people will need to carry local work arounds for multi-machine builds. +1 from me.Quoted 8 lines
But this is against the LTS/Stable branch policy. What is the point of
having a policy if we are going to keep making exceptions? There'd be
other changes as well for which people might be carrying work- arounds.
Would we be willing to make exceptions for all?Quoted 2 lines
Thanks for bringing this up. Policy exceptions are not common but they
That's two exceptions in a week.
I am not against the change but I think the policy document should be modified to define how exceptions should/will be handled.
Quoted 5 lines
are not absent either
hence context is important for such changes, I am definitely interested to hear
about how it is going to affect arm64 users at this early stage of release.
Quoted 4 lines
The release has been made and I think the branch is assumed to be stable from the time it was released and policy should be applied? There's no early release stage defined where-in such changes would be acceptable.
we do have QA qualification criteria for releases and LTS is no different for meeting that requirement. so these patches if regressing should be found out before
point release.
LTS has to be useful for new SOCs and with the least amount of patching, I am yet
to hear technical downsides or concerns for this patchset. I have no problem in maintaining them in the downstream distro since they are already in master it really is fine since they will be in the next LTS and we will be fine. I was hoping the
experience better for others and have a bit of fewer patches to maintain.
Quoted 4 lines
Thanks,
Anuj
PATCH 9/10 gcc: Do not set -march for arm64 for libatomic
In reply to Khem Rajlibatomic has mind of its own when it comes to setting -march for arm64 which conflicts with -mcpu option we pass from environment in some cases since we always pass -march/-mcpu in OE, its safe to remove this option
mcpu removal from cortex-a55 is no longer needed since the option conflict is now removed from libatomic instead
--- meta/recipes-devtools/gcc/gcc-9.3.inc | 1 + ...omic-Do-not-enforce-march-on-aarch64.patch | 42 +++++++++++++++++++ meta/recipes-devtools/gcc/gcc-runtime.inc | 4 -- 3 files changed, 43 insertions(+), 4 deletions(-) create mode 100644 meta/recipes-devtools/gcc/gcc-9.3/0039-libatomic-Do-not-enforce-march-on-aarch64.patch
meta/recipes-devtools/gcc/gcc-9.3.inc +1 -0
@@ -67,6 +67,7 @@ SRC_URI = "\ file://0037-CVE-2019-14250-Check-zero-value-in-simple_object_elf.patch \ file://0038-gentypes-genmodes-Do-not-use-__LINE__-for-maintainin.patch \ file://0039-process_alt_operands-Don-t-match-user-defined-regs-o.patch \ + file://0039-libatomic-Do-not-enforce-march-on-aarch64.patch \ " S = "${TMPDIR}/work-shared/gcc-${PV}-${PR}/gcc-${PV}" SRC_URI[sha256sum] = "71e197867611f6054aa1119b13a0c0abac12834765fe2d81f35ac57f84f742d1"
meta/recipes-devtools/gcc/gcc-9.3/0039-libatomic-Do-not-enforce-march-on-aarch64.patch new file +42 -0
42 lines not on this page · raw message
meta/recipes-devtools/gcc/gcc-runtime.inc +0 -4
@@ -18,10 +18,6 @@ EXTRA_OECONF_append_linuxstdbase = " --enable-clocale=gnu" EXTRA_OECONF_append = " --cache-file=${B}/config.cache" EXTRA_OECONF_append_libc-newlib = " --with-newlib" -# cortex-a55 is ARMv8.2-a based but libatomic explicitly asks for -march=armv8.1-a -# which caused -march conflicts in gcc -TUNE_CCARGS_remove = "-mcpu=cortex-a55+crc -mcpu=cortex-a55 -mcpu=cortex-a55+crc+crypto" - # Disable ifuncs for libatomic on arm conflicts -march/-mcpu EXTRA_OECONF_append_arm = " libat_cv_have_ifunc=no " EXTRA_OECONF_append_armeb = " libat_cv_have_ifunc=no "
Signature · 1 line
2.26.2
PATCH 10/10 cve-check: Run it after do_fetch
In reply to Khem RajCertain recipes e.g. bash readline ( from meta-gplv2 ) download patches instead of having them in metadata, this could fail cve_check
ERROR: readline-5.2-r9 do_cve_check: File Not found: qemuarm/build/../downloads/readline52-001
This patch ensures that download is done before running CVE scan, even though these will be external patches and may not contain CVE tags as it expects, but it will fix the run failures as seen above
--- meta/classes/cve-check.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/cve-check.bbclass +1 -1
@@ -65,7 +65,7 @@ python do_cve_check () { } -addtask cve_check before do_build +addtask cve_check before do_build after do_fetch do_cve_check[depends] = "cve-update-db-native:do_populate_cve_db" do_cve_check[nostamp] = "1"
Signature · 1 line
2.26.2
Ping for this series.
Quoted 65 lines · Khem Raj
Signed-off-by Khem Raj <[email protected]>Signed-off-by Richard Purdie <[email protected]>--- meta/conf/machine/include/tune-cortexa55.inc | 17 ++++++++++++++ .../include/tune-cortexa73-cortexa53.inc | 23 +++++++++++++++++++ 2 files changed, 40 insertions(+) create mode 100644 meta/conf/machine/include/tune-cortexa55.inc create mode 100644 meta/conf/machine/include/tune-cortexa73-cortexa53.incmeta/conf/machine/include/tune-cortexa55.inc new file +17
-0@@ -0,0 +1,17 @@ +DEFAULTTUNE ?= "cortexa55" + +TUNEVALID[cortexa55] = "Enable Cortex-A55 specific processor optimizations" +TUNE_CCARGS .= "${@bb.utils.contains('TUNE_FEATURES', 'cortexa55', ' -mcpu=cortex-a55', '', d)}" + +require conf/machine/include/arm/arch-armv8a.inc + +# Little Endian base configs +AVAILTUNES += "cortexa55 cortexa55-crypto" +ARMPKGARCH_tune-cortexa55 = "cortexa55" +ARMPKGARCH_tune-cortexa55-crypto = "cortexa55" +TUNE_FEATURES_tune-cortexa55 = "aarch64 cortexa55 crc" +TUNE_FEATURES_tune-cortexa55-crypto = "aarch64 cortexa55 crc crypto" +PACKAGE_EXTRA_ARCHS_tune-cortexa55 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa55" +PACKAGE_EXTRA_ARCHS_tune-cortexa55-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa55 cortexa55-crypto" +BASE_LIB_tune-cortexa55 = "lib64" +BASE_LIB_tune-cortexa55-crypto = "lib64"meta/conf/machine/include/tune-cortexa73-cortexa53.inc new file +23
-1@@ -0,0 +1,23 @@ +DEFAULTTUNE ?= "cortexa73-cortexa53" + +require conf/machine/include/arm/arch-armv8a.inc + +TUNEVALID[cortexa73-cortexa53] = "Enable big.LITTLE Cortex-A73.Cortex-A53 specific processor optimizations" + +TUNECONFLICTS[aarch64] = "armv4 armv5 armv6 armv7 armv7a" + +MACHINEOVERRIDES =. "${@bb.utils.contains("TUNE_FEATURES", "cortexa73-cortexa53", "cortexa73-cortexa53:", "" ,d)}" + +TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "cortexa73-cortexa53", " -mtune=cortex-a73.cortex-a53", "", d)}" + +# cortexa73.cortexa53 implies crc support +AVAILTUNES += "cortexa73-cortexa53 cortexa73-cortexa53-crypto" +ARMPKGARCH_tune-cortexa73-cortexa53 = "cortexa73-cortexa53" +ARMPKGARCH_tune-cortexa73-cortexa53-crypto = "cortexa73-cortexa53" +TUNE_FEATURES_tune-cortexa73-cortexa53 = "${TUNE_FEATURES_tune-armv8a-crc} cortexa73-cortexa53" +TUNE_FEATURES_tune-cortexa73-cortexa53-crypto = "${TUNE_FEATURES_tune-armv8a-crc-crypto} cortexa73-cortexa53" +PACKAGE_EXTRA_ARCHS_tune-cortexa73-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc} cortexa73-cortexa53" +PACKAGE_EXTRA_ARCHS_tune-cortexa73-cortexa53-crypto = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa73-cortexa53 cortexa73-cortexa53-crypto" +BASE_LIB_tune-cortexa73-cortexa53 = "lib64" +BASE_LIB_tune-cortexa73-cortexa53-crypto = "lib64" + --2.26.2