Skip to contentSkip to conversation

m4: use test instead of []

PATCH Superseded Wei Liu 2 participants 2 messages May 22, 2020

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Wei Liu

author
#0 lore raw

PATCH 1/1 m4: use test instead of []

It is reported that [] was removed by autoconf, which caused the following error:

./configure: line 4681: -z: command not found

Switch to test. That's what is used throughout our configure scripts.

Fixes 8a6b1665d987 ("configure: also add EXTRA_PREFIX to {CPP/LD}FLAGS")

---
Run autogen.sh before committing.

Cc Bertrand Marquis <[email protected]>
Cc Roger Pau Monne <[email protected]>
---
 m4/set_cflags_ldflags.m4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
m4/set_cflags_ldflags.m4 +1 -1
index 08f5c983cc63..cd34c139bc94 100644
@@ -15,7 +15,7 @@ for ldflag in $APPEND_LIB
 do
     APPEND_LDFLAGS="$APPEND_LDFLAGS -L$ldflag"
 done
-if [ ! -z $EXTRA_PREFIX ]; then
+if test ! -z $EXTRA_PREFIX ; then
     CPPFLAGS="$CPPFLAGS -I$EXTRA_PREFIX/include"
     LDFLAGS="$LDFLAGS -L$EXTRA_PREFIX/lib"
 fi
Signature · 1 line
2.20.1
#1 lore raw

Wei Liu writes ("[PATCH] m4: use test instead of []"):

Quoted 6 lines

It is reported that [] was removed by autoconf, which caused the following error:

./configure: line 4681: -z: command not found

Switch to test. That's what is used throughout our configure scripts.

The reason for [ ] being removed is that configure.ac et al are processed by m4 with quote characters set to [ ].

m4/set_cflags_ldflags.m4 for ldflag in $APPEND_LIB · line 19

Quoted 5 lines

APPEND_LDFLAGS="$APPEND_LDFLAGS -L$ldflag"
done

m4/set_cflags_ldflags.m4 +1 -1
-if [ ! -z $EXTRA_PREFIX ]; then
+if test ! -z $EXTRA_PREFIX ; then
     CPPFLAGS="$CPPFLAGS -I$EXTRA_PREFIX/include"

If $EXTRA_PREFIX contains nothing (or just whitespace) this expands to
test ! -z
which only works by accident. It is parsed ax
if not (string_is_nonempty("-z"))

Variable expansions in test expressions should generally be in " ".

Ian.