Skip to contentSkip to conversation

efi/efivars: Add missing kobject_put() in sysfs entry creation error path

PATCH New Ard Biesheuvel 1 participant 1 message May 22, 2020

Subsystems (2)
Stable branch EFI
lore
Share & tools
lore

Ard Biesheuvel

author maintainer
#0 lore raw

PATCH 1/1 efi/efivars: Add missing kobject_put() in sysfs entry creation error path

The documentation provided by kobject_init_and_add() clearly spells out the need to call kobject_put() on the kobject if an error is returned. Add this missing call to the error path.

Cc <[email protected]>
Reported-by 亿一 <[email protected]>
Signed-off-by Ard Biesheuvel <[email protected]>
---
 drivers/firmware/efi/efivars.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/firmware/efi/efivars.c +3 -1
index 78ad1ba8c987..26528a46d99e 100644
@@ -522,8 +522,10 @@ efivar_create_sysfs_entry(struct efivar_entry *new_var)
 	ret = kobject_init_and_add(&new_var->kobj, &efivar_ktype,
 				   NULL, "%s", short_name);
 	kfree(short_name);
-	if (ret)
+	if (ret) {
+		kobject_put(&new_var->kobj);
 		return ret;
+	}
 
 	kobject_uevent(&new_var->kobj, KOBJ_ADD);
 	if (efivar_entry_add(new_var, &efivar_sysfs_list)) {
Signature · 1 line
2.17.1