HID: magicmouse: do not set up autorepeat
PATCH 1/1 HID: magicmouse: do not set up autorepeat
Neither the trackpad, nor the mouse want input core to generate autorepeat events for their buttons, so let's reset the bit (as hid-input sets it for these devices based on the usage vendor code).
---
Jiri, Benjamin, this is fixes jitter in event packets that became apparent when we moved the point at which timestamps are being generated, so maybe mark for stable?
Thanks!
drivers/hid/hid-magicmouse.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/hid/hid-magicmouse.c +6 -0
@@ -535,6 +535,12 @@ static int magicmouse_setup_input(struct input_dev *input, struct hid_device *hd__set_bit (MSC_RAW , input->mscbit); } +/* +* hit-input may mark device as using autorepeat, but neither +* the trackpad, nor the mouse actually want it. +*/ +__clear_bit (EV_REP , input->evbit); +return 0 ; }
Signature · 5 lines
2.27.0.rc0.183.gde8f92d652-goog -- Dmitry
Jiri Kosina
maintainerQuoted 4 lines · Dmitry Torokhov
Neither the trackpad, nor the mouse want input core to generate autorepeat events for their buttons, so let's reset the bit (as hid-input sets it for these devices based on the usage vendor code).
Quoted 8 lines
Reported-by Yariv <[email protected]>Tested-by Yariv <[email protected]>Signed-off-by Dmitry Torokhov <[email protected]>---
Jiri, Benjamin, this is fixes jitter in event packets that became apparent when we moved the point at which timestamps are being generated, so maybe mark for stable?
I've marked it for stable, fixed the typo in the comment, and applied, thanks.
Signature · 2 lines
Jiri Kosina SUSE Labs