Skip to contentSkip to conversation

x86: acpi: Drop _HID() where enumerated by _ADR()

PATCH New Andy Shevchenko 2 participants 3 messages May 26, 2020 – May 28, 2020 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: acpi: Drop _HID() where enumerated by _ADR()

ACPICA complains that either _HID() or _ADR() should be used. For General Purpose DMA we may not drop the _ADR() because the device is enumerated by PCI. Thus, simple drop _HID().

---
 arch/x86/include/asm/arch-tangier/acpi/southcluster.asl | 1 -
 1 file changed, 1 deletion(-)
arch/x86/include/asm/arch-tangier/acpi/southcluster.asl +0 -1
index eaf75c8c673d..01077293bb91 100644
@@ -531,7 +531,6 @@ Device (PCI0)
     Device (GDMA)
     {
         Name (_ADR, 0x00150000)
-        Name (_HID, "808611A2")
         Name (_UID, Zero)
 
         Method (_STA, 0, NotSerialized)
Signature · 1 line
2.26.2
#1 lore raw

PATCH 1/1 x86: acpi: Drop _HID() where enumerated by _ADR()

Quoted 3 lines · Andy Shevchenko

ACPICA complains that either _HID() or _ADR() should be used. For General Purpose DMA we may not drop the _ADR() because the device is enumerated by PCI. Thus, simple drop _HID().

Bin, since now all issues you found, being addressed, care to apply before v2020.07 release?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw

PATCH 1/1 x86: acpi: Drop _HID() where enumerated by _ADR()

Hi Andy,

Quoted 9 lines · Andy Shevchenko
Quoted 3 lines · Andy Shevchenko

ACPICA complains that either _HID() or _ADR() should be used. For General Purpose DMA we may not drop the _ADR() because the device is enumerated by PCI. Thus, simple drop _HID().

Bin, since now all issues you found, being addressed, care to apply before v2020.07 release?

Yes, this is planned in the next PR.

Regards,
Bin