net/netfilter/nf_conntrack_core.c:2068 __nf_conntrack_update() error: uninitialized symbol 'ctinfo'.
PATCH 11987/12912 net/netfilter/nf_conntrack_core.c:2068 __nf_conntrack_update() error: uninitialized symbol 'ctinfo'.
[ I'm always a bit concerned when I see that we are checking 12k patches
in the subject. -- dan ]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: b0523c7b1c9d0edcd6c0fe6d2cb558a9ad5c60a8 commit: ee04805ff54a63ffd90bc6749ebfe73473734ddb [11987/12912] netfilter: conntrack: make conntrack userspace helpers work again
config: i386-randconfig-m021-20200527 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
New smatch warnings:net/netfilter/nf_conntrack_core.c:2068 __nf_conntrack_update() error: uninitialized symbol 'ctinfo'. net/netfilter/nf_conntrack_core.c:2117 nf_confirm_cthelper() warn: unsigned 'protoff' is never less than zero.
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ee04805ff54a63ffd90bc6749ebfe73473734ddb
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout ee04805ff54a63ffd90bc6749ebfe73473734ddb
vim +/ctinfo +2068 net/netfilter/nf_conntrack_core.c
9fb9cbb1082d6b3 Yasuyuki Kozakai 2005-11-09 2018
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2019 static int __nf_conntrack_update(struct net *net, struct sk_buff *skb,
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2020 struct nf_conn *ct)
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2021 {
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2022 struct nf_conntrack_tuple_hash *h;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2023 struct nf_conntrack_tuple tuple;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2024 enum ip_conntrack_info ctinfo;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2025 struct nf_nat_hook *nat_hook;
6816d931cab0090 Florian Westphal 2018-06-29 2026 unsigned int status;
6816d931cab0090 Florian Westphal 2018-06-29 2027 int dataoff;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2028 u16 l3num;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2029 u8 l4num;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2030
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2031 l3num = nf_ct_l3num(ct);
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2032
6816d931cab0090 Florian Westphal 2018-06-29 2033 dataoff = get_l4proto(skb, skb_network_offset(skb), l3num, &l4num);
6816d931cab0090 Florian Westphal 2018-06-29 2034 if (dataoff <= 0)
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2035 return -1;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2036
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2037 if (!nf_ct_get_tuple(skb, skb_network_offset(skb), dataoff, l3num,
303e0c5589592e4 Florian Westphal 2019-01-15 2038 l4num, net, &tuple))
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2039 return -1;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2040
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2041 if (ct->status & IPS_SRC_NAT) {
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2042 memcpy(tuple.src.u3.all,
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2043 ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple.src.u3.all,
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2044 sizeof(tuple.src.u3.all));
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2045 tuple.src.u.all =
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2046 ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple.src.u.all;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2047 }
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2048
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2049 if (ct->status & IPS_DST_NAT) {
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2050 memcpy(tuple.dst.u3.all,
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2051 ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple.dst.u3.all,
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2052 sizeof(tuple.dst.u3.all));
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2053 tuple.dst.u.all =
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2054 ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple.dst.u.all;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2055 }
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2056
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2057 h = nf_conntrack_find_get(net, nf_ct_zone(ct), &tuple);
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2058 if (!h)
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2059 return 0;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2060
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2061 /* Store status bits of the conntrack that is clashing to re-do NAT
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2062 * mangling according to what it has been done already to this packet.
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2063 */
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2064 status = ct->status;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2065
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2066 nf_ct_put(ct);
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2067 ct = nf_ct_tuplehash_to_ctrack(h);
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 @2068 nf_ct_set(skb, ct, ctinfo);
^^^^^^Never initialized.
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2069
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2070 nat_hook = rcu_dereference(nf_nat_hook);
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2071 if (!nat_hook)
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2072 return 0;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2073
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2074 if (status & IPS_SRC_NAT &&
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2075 nat_hook->manip_pkt(skb, ct, NF_NAT_MANIP_SRC,
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2076 IP_CT_DIR_ORIGINAL) == NF_DROP)
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2077 return -1;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2078
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2079 if (status & IPS_DST_NAT &&
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2080 nat_hook->manip_pkt(skb, ct, NF_NAT_MANIP_DST,
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2081 IP_CT_DIR_ORIGINAL) == NF_DROP)
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2082 return -1;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2083
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2084 return 0;
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2085 }
368982cd7d1bd41 Pablo Neira Ayuso 2018-05-23 2086
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2087 /* This packet is coming from userspace via nf_queue, complete the packet
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2088 * processing after the helper invocation in nf_confirm().
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2089 */
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2090 static int nf_confirm_cthelper(struct sk_buff *skb, struct nf_conn *ct,
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2091 enum ip_conntrack_info ctinfo)
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2092 {
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2093 const struct nf_conntrack_helper *helper;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2094 const struct nf_conn_help *help;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2095 unsigned int protoff;
^^^^^^^^^^^^^^^^^^^^ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2096
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2097 help = nfct_help(ct);
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2098 if (!help)
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2099 return 0;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2100
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2101 helper = rcu_dereference(help->helper);
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2102 if (!(helper->flags & NF_CT_HELPER_F_USERSPACE))
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2103 return 0;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2104
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2105 switch (nf_ct_l3num(ct)) {
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2106 case NFPROTO_IPV4:
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2107 protoff = skb_network_offset(skb) + ip_hdrlen(skb);
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2108 break;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2109 #if IS_ENABLED(CONFIG_IPV6)
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2110 case NFPROTO_IPV6: {
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2111 __be16 frag_off;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2112 u8 pnum;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2113
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2114 pnum = ipv6_hdr(skb)->nexthdr;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2115 protoff = ipv6_skip_exthdr(skb, sizeof(struct ipv6hdr), &pnum,
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2116 &frag_off);
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 @2117 if (protoff < 0 || (frag_off & htons(~0x7)) != 0)
^^^^^^^^^^^Unsigned.
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2118 return 0;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2119 break;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2120 }
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2121 #endif
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2122 default:
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2123 return 0;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2124 }
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2125
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2126 if (test_bit(IPS_SEQ_ADJUST_BIT, &ct->status) &&
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2127 !nf_is_loopback_packet(skb)) {
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2128 if (!nf_ct_seq_adjust(skb, ct, ctinfo, protoff)) {
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2129 NF_CT_STAT_INC_ATOMIC(nf_ct_net(ct), drop);
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2130 return -1;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2131 }
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2132 }
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2133
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2134 /* We've seen it coming out the other side: confirm it */
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2135 return nf_conntrack_confirm(skb) == NF_DROP ? - 1 : 0;
ee04805ff54a63f Pablo Neira Ayuso 2020-05-24 2136 }---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org