Skip to contentSkip to conversation

drivers/infiniband/hw/hfi1/netdev_rx.c:335 hfi1_netdev_free() error: use free_netdev() here instead of kfree(dd->dummy_netdev)

PATCH New Dan Carpenter 1 participant 1 message May 27, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 10689/12912 drivers/infiniband/hw/hfi1/netdev_rx.c:335 hfi1_netdev_free() error: use free_netdev() here instead of kfree(dd->dummy_netdev)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   b0523c7b1c9d0edcd6c0fe6d2cb558a9ad5c60a8
commit: 370caa5b5880cd988645735c2d5d1d597c258e39 [10689/12912] IB/hfi1: Add rx functions for dummy netdev

config: x86_64-randconfig-m001-20200526 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0

If you fix the issue, kindly add following tag as appropriate

smatch warnings:
drivers/infiniband/hw/hfi1/netdev_rx.c:335 hfi1_netdev_free() error: use free_netdev() here instead of kfree(dd->dummy_netdev)

# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=370caa5b5880cd988645735c2d5d1d597c258e39
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout 370caa5b5880cd988645735c2d5d1d597c258e39
vim +335 drivers/infiniband/hw/hfi1/netdev_rx.c

370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11  328  void hfi1_netdev_free(struct hfi1_devdata *dd)
370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11  329  {
370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11  330  	struct hfi1_netdev_priv *priv;
370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11  331  
370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11  332  	if (dd->dummy_netdev) {
370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11  333  		priv = hfi1_netdev_priv(dd->dummy_netdev);
370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11  334  		dd_dev_info(dd, "hfi1 netdev freed\n");
370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11 @335  		kfree(dd->dummy_netdev);
                                                                ^^^^^^^^^^^^^^^^^^^^^^

kfree_netdev().

370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11  336  		dd->dummy_netdev = NULL;
370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11  337  	}
370caa5b5880cd9 Grzegorz Andrejczuk 2020-05-11  338  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org