Skip to contentSkip to conversation

habanalabs: fix error code in unmap_device_va()

PATCH In review Dan Carpenter 2 participants 2 messages May 28, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 habanalabs: fix error code in unmap_device_va()

Smatch complains that "rc" can be uninitialized on certain paths.

Fixes 8ff5f4fd40df ("habanalabs: handle MMU cache invalidation timeout")
---
 drivers/misc/habanalabs/memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/habanalabs/memory.c +1 -1
index 4b8eed1ca5130..47da84a177197 100644
@@ -1023,7 +1023,7 @@ static int unmap_device_va(struct hl_ctx *ctx, u64 vaddr, bool ctx_free)
 	struct hl_va_range *va_range;
 	enum vm_type_t *vm_type;
 	bool is_userptr;
-	int rc;
+	int rc = 0;
 
 	/* protect from double entrance */
 	mutex_lock(&ctx->mem_hash_lock);
Signature · 1 line
2.26.2
#1 lore raw

Thanks, we already have a patch ready for that in -fixes branch that will be applied in 5.8-rc2
Oded

Quoted 25 lines · Dan Carpenter

Smatch complains that "rc" can be uninitialized on certain paths.

Fixes 8ff5f4fd40df ("habanalabs: handle MMU cache invalidation timeout")
---
 drivers/misc/habanalabs/memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/habanalabs/memory.c +1 -2
index 4b8eed1ca5130..47da84a177197 100644
@@ -1023,7 +1023,7 @@ static int unmap_device_va(struct hl_ctx *ctx, u64 vaddr, bool ctx_free)
        struct hl_va_range *va_range;
        enum vm_type_t *vm_type;
        bool is_userptr;
-       int rc;
+       int rc = 0;
 
        /* protect from double entrance */
        mutex_lock(&ctx->mem_hash_lock);
--

2.26.2