ASoC: reduce verbosity of error messages for sof-dai and sof-link
PATCH 1/1 ASoC: reduce verbosity of error messages for sof-dai and sof-link
Recent changes result in multiple dmesg traces such as:
[ 14.410435] Audio Port: ASoC: error at snd_soc_link_startup on Audio
Port: 1
[ 14.410446] sst-mfld-platform sst-mfld-platform: ASoC: error at
snd_soc_dai_startup on media-cpu-dai: 1
These messages are not really errors, when dai and dai-link callbacks return the value of e.g. snd_pcm_hw_constraint_single() the result is "Positive if the value is changed, zero if it's not changed, or a negative error code"
Add a simple test to only log errors when the result is negative.
--- sound/soc/soc-dai.c | 7 ++++--- sound/soc/soc-link.c | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-)
sound/soc/soc-dai.c +4 -3
@@ -20,9 +20,10 @@ static inline int _soc_dai_ret(struct snd_soc_dai *dai,case 0 :break ;default : -dev_err (dai->dev, -"ASoC: error at %s on %s: %d\n" , - func, dai->name, ret); +if (ret <0 ) +dev_err (dai->dev, +"ASoC: error at %s on %s: %d\n" , + func, dai->name, ret); }return ret;
sound/soc/soc-link.c +4 -3
@@ -18,9 +18,10 @@ static inline int _soc_link_ret(struct snd_soc_pcm_runtime *rtd,case 0 :break ;default : -dev_err (rtd->dev, -"ASoC: error at %s on %s: %d\n" , - func, rtd->dai_link->name, ret); +if (ret <0 ) +dev_err (rtd->dev, +"ASoC: error at %s on %s: %d\n" , + func, rtd->dai_link->name, ret); }return ret;
base-commit: 4a0434502191347ba8f99468f2fb2cdddc20d381
Signature · 1 line
2.20.1
Hi Pierre-Louis
Quoted 13 lines
Recent changes result in multiple dmesg traces such as:
[ 14.410435] Audio Port: ASoC: error at snd_soc_link_startup on AudioPort: 1
[ 14.410446] sst-mfld-platform sst-mfld-platform: ASoC: error at
snd_soc_dai_startupon media-cpu-dai: 1These messages are not really errors, when dai and dai-link callbacks return the value of e.g.
snd_pcm_hw_constraint_single()the result is "Positive if the value is changed, zero if it's not changed, or a negative error code"
Quoted 5 lines
Add a simple test to only log errors when the result is negative.
Signed-off-by Pierre-Louis Bossart <[email protected]>---
Thank you for pointing it.
Some functions which has above rule isn't use soc_xxx_ret() actually. Anyway, more simply, how about this ?
----------
sound/soc/soc-dai.c +5 -1
@@ -14,10 +14,14 @@static inline int _soc_dai_ret (struct snd_soc_dai *dai,const char *func,int ret) { +/* Positive, Zero are not error */ +if (ret >=0 ) +return ret; + +/* Negative might be error */ switch (ret) {case -EPROBE_DEFER :case -ENOTSUPP : -case 0 :break ;default : dev_err(dai->dev,
----------
Thank you for your help !!
Best regards
---
Kuninori Morimoto
Quoted 19 lines · Kuninori Morimoto
Hi Pierre-Louis
Quoted 16 lines
Recent changes result in multiple dmesg traces such as:
[ 14.410435] Audio Port: ASoC: error at snd_soc_link_startup on AudioPort: 1
[ 14.410446] sst-mfld-platform sst-mfld-platform: ASoC: error at
snd_soc_dai_startupon media-cpu-dai: 1These messages are not really errors, when dai and dai-link callbacks return the value of e.g.
snd_pcm_hw_constraint_single()the result is "Positive if the value is changed, zero if it's not changed, or a negative error code"Add a simple test to only log errors when the result is negative.
Quoted 6 lines
Quoted 2 lines
Signed-off-by Pierre-Louis Bossart <[email protected]>---
Thank you for pointing it.
Some functions which has above rule isn't usesoc_xxx_ret()actually. Anyway, more simply, how about this ?
Sounds good, will send a v2 with your suggestion.
Quoted 30 lines
----------
sound/soc/soc-dai.c +5
-2@@ -14,10 +14,14 @@static inline int _soc_dai_ret (struct snd_soc_dai *dai,const char *func,int ret) { +/* Positive, Zero are not error */ +if (ret >=0 ) +return ret; + +/* Negative might be error */ switch (ret) {case -EPROBE_DEFER :case -ENOTSUPP : -case 0 :break ;default : dev_err(dai->dev, ----------Thank you for your help !!
Best regards
---
Kuninori Morimoto