watchdog: test_bit() => watchdog_active()
PATCH 1/1 watchdog: test_bit() => watchdog_active()
Use the dedicated function watchdog_active()
instead of the generic test_bit() function.
It is done using the following Coccinelle script:
@@
identifier wdd;
@@
- test_bit(WDOG_ACTIVE, &wdd->status)
+ watchdog_active(wdd)
Signed-off-by Bumsik Kim <[email protected]>
--- drivers/watchdog/watchdog_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/watchdog_dev.c +1 -1
@@ -916,7 +916,7 @@ static int watchdog_release(struct inode *inode, struct file *file)* or if WDIOF_MAGICCLOSE is not set. If nowayout was set then * watchdog_stop will fail. */ -if (!test_bit (WDOG_ACTIVE , &wdd->status)) +if (!watchdog_active (wdd)) err =0 ;else if (test_and_clear_bit (_WDOG_ALLOW_RELEASE, &wd_data->status) || !(wdd->info->options &WDIOF_MAGICCLOSE ))
Signature · 1 line
2.26.2
Quoted 5 lines · Bumsik Kim
Use the dedicated function
watchdog_active()
instead of the generictest_bit()function.It is done using the following Coccinelle script:
Quoted 7 lines
@@
identifier wdd;
@@
-test_bit(WDOG_ACTIVE, &wdd->status)
+watchdog_active(wdd)Signed-off-by Bumsik Kim <[email protected]>
Reviewed-by Guenter Roeck <[email protected]>
Quoted 20 lines
--- drivers/watchdog/watchdog_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/watchdog/watchdog_dev.c +1
-1@@ -916,7 +916,7 @@ static int watchdog_release(struct inode *inode, struct file *file)* or if WDIOF_MAGICCLOSE is not set. If nowayout was set then * watchdog_stop will fail. */ -if (!test_bit (WDOG_ACTIVE , &wdd->status)) +if (!watchdog_active (wdd)) err =0 ;else if (test_and_clear_bit (_WDOG_ALLOW_RELEASE, &wd_data->status) || !(wdd->info->options &WDIOF_MAGICCLOSE ))Signature · 1 line
2.26.2