Skip to contentSkip to conversation

net: ethernet: mtk-star-emac: remove unused variable

PATCH Applied Bartosz Golaszewski 2 participants 3 messages May 29, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: ethernet: mtk-star-emac: remove unused variable

From: Bartosz Golaszewski <[email protected]>

The desc pointer is set but not used. Remove it.

Fixes 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
---
 drivers/net/ethernet/mediatek/mtk_star_emac.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/net/ethernet/mediatek/mtk_star_emac.c +0 -3
index 8596ca0e60eb..7df35872c107 100644
@@ -746,15 +746,12 @@ mtk_star_ring_free_skbs(struct mtk_star_priv *priv, struct mtk_star_ring *ring,
 					   struct mtk_star_ring_desc_data *))
 {
 	struct mtk_star_ring_desc_data desc_data;
-	struct mtk_star_ring_desc *desc;
 	int i;
 
 	for (i = 0; i < MTK_STAR_RING_NUM_DESCS; i++) {
 		if (!ring->dma_addrs[i])
 			continue;
 
-		desc = &ring->descs[i];
-
 		desc_data.dma_addr = ring->dma_addrs[i];
 		desc_data.skb = ring->skbs[i];
 
Signature · 1 line
2.26.1
#1 lore raw

pt., 29 maj 2020 o 10:26 Bartosz Golaszewski <[email protected]> napisał(a):

Quoted 33 lines

From: Bartosz Golaszewski <[email protected]>

The desc pointer is set but not used. Remove it.

Fixes 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
---
 drivers/net/ethernet/mediatek/mtk_star_emac.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/net/ethernet/mediatek/mtk_star_emac.c +0 -4
index 8596ca0e60eb..7df35872c107 100644
@@ -746,15 +746,12 @@ mtk_star_ring_free_skbs(struct mtk_star_priv *priv, struct mtk_star_ring *ring,
                                           struct mtk_star_ring_desc_data *))
 {
        struct mtk_star_ring_desc_data desc_data;
-       struct mtk_star_ring_desc *desc;
        int i;
 
        for (i = 0; i < MTK_STAR_RING_NUM_DESCS; i++) {
                if (!ring->dma_addrs[i])
                        continue;
 
-               desc = &ring->descs[i];
-
                desc_data.dma_addr = ring->dma_addrs[i];
                desc_data.skb = ring->skbs[i];
 
--
Quoted 2 lines

2.26.1

Cr*p I forgot to tag it for net-next. David let me know if you want me to resend it.

Bartosz