Skip to contentSkip to conversation

mm: Remove misleading comment

PATCH Applied Matthew Wilcox 2 participants 2 messages May 29, 2020 – Jun 1, 2020

Subsystems (2)
Memory management Page cache
lore
Share & tools
lore

Matthew Wilcox

author maintainer
#0 lore raw

PATCH 1/1 mm: Remove misleading comment

From: "Matthew Wilcox (Oracle)" <[email protected]>

We no longer return 0 here and the comment doesn't tell us anything that we don't already know (SIGBUS is a pretty good indicator that things didn't work out).

Signed-off-by Matthew Wilcox (Oracle) <[email protected]>
---
 mm/filemap.c | 1 -
 1 file changed, 1 deletion(-)
mm/filemap.c +0 -1
index 23a051a7ef0f..fe079e9219d1 100644
@@ -2566,7 +2566,6 @@ vm_fault_t filemap_fault(struct vm_fault *vmf)
 	if (!error || error == AOP_TRUNCATED_PAGE)
 		goto retry_find;
 
-	/* Things didn't work out. Return zero to tell the mm layer so. */
 	shrink_readahead_size_eio(ra);
 	return VM_FAULT_SIGBUS;
Signature · 1 line
2.26.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 20 lines · Matthew Wilcox

From: "Matthew Wilcox (Oracle)" <[email protected]>

We no longer return 0 here and the comment doesn't tell us anything that we don't already know (SIGBUS is a pretty good indicator that things didn't work out).

Signed-off-by Matthew Wilcox (Oracle) <[email protected]>

---
mm/filemap.c | 1 -

1 file changed, 1 deletion(-)
mm/filemap.c +0 -0
index 23a051a7ef0f..fe079e9219d1 100644

mm/filemap.c vm_fault_t filemap_fault(struct vm_fault *vmf) · line 2570

Quoted 6 lines
mm/filemap.c +0 -1
@@ -2566,7 +2566,6 @@ vm_fault_t filemap_fault(struct vm_fault *vmf)
 	if (!error || error == AOP_TRUNCATED_PAGE)
 		goto retry_find;
 
-	/* Things didn't work out. Return zero to tell the mm layer so. */
 	shrink_readahead_size_eio(ra);
 	return VM_FAULT_SIGBUS;
Reviewed-by William Kucharski <[email protected]>