Skip to contentSkip to conversation

INSTALL: remove TODO section

PATCH In review Olaf Hering 3 participants 3 messages May 29, 2020 – Jun 2, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 INSTALL: remove TODO section

The default value '/' for DESTDIR is unusual, but does probably not hurt.

Fixes commit f2b40dababedcd8355bf3e85d00baf17f9827131 Fixes commit 8e986e5a61efeca92b9b268e77957d45d8316ee4

---
 INSTALL | 7 -------
 1 file changed, 7 deletions(-)
INSTALL +0 -7
index 72dc4b67dd..0d3eb89f02 100644
@@ -365,12 +365,5 @@ make XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- \
         DESTDIR=/some/path install
 
 
-TODO
-====
-
- - DESTDIR should be empty, not "/"
- - add make uninstall targets
- - replace private path variables as needed (SBINDIR/sbindir)
- - ...
 
 # vim: tw=72 et
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Olaf Hering

The default value '/' for DESTDIR is unusual, but does probably not hurt.

Fixes commit f2b40dababedcd8355bf3e85d00baf17f9827131 Fixes commit 8e986e5a61efeca92b9b268e77957d45d8316ee4

Based on the fact that you're the original author of this documentation. :-)

Cc Paul.

Quoted 21 lines
---
 INSTALL | 7 -------
 1 file changed, 7 deletions(-)
INSTALL +0 -7
index 72dc4b67dd..0d3eb89f02 100644
@@ -365,12 +365,5 @@ make XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- \
         DESTDIR=/some/path install
 
 
-TODO
-====
-
- - DESTDIR should be empty, not "/"
- - add make uninstall targets
- - replace private path variables as needed (SBINDIR/sbindir)
- - ...
 
 # vim: tw=72 et
#2 lore raw
Quoted 16 lines

-----Original Message-----
From: Wei Liu <[email protected]>
Sent: 02 June 2020 09:44
To: Olaf Hering <[email protected]>
Cc: [email protected]; Andrew Cooper <[email protected]>; George Dunlap <[email protected]>; Ian Jackson <[email protected]>; Jan Beulich <[email protected]>; Julien Grall <[email protected]>; Stefano Stabellini <[email protected]>; Wei Liu <[email protected]>; Paul Durrant <[email protected]>
Subject: Re: [PATCH v1] INSTALL: remove TODO section

Quoted 5 lines · Olaf Hering

The default value '/' for DESTDIR is unusual, but does probably not hurt.

Fixes commit f2b40dababedcd8355bf3e85d00baf17f9827131 Fixes commit 8e986e5a61efeca92b9b268e77957d45d8316ee4

Quoted 8 lines
Quoted 1 line

Based on the fact that you're the original author of this documentation. :-)

Cc Paul.

Quoted 22 lines
Quoted 22 lines
---
 INSTALL | 7 -------
 1 file changed, 7 deletions(-)
INSTALL +0 -7
index 72dc4b67dd..0d3eb89f02 100644
@@ -365,12 +365,5 @@ make XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- \
         DESTDIR=/some/path install
 
 
-TODO
-====
-
- - DESTDIR should be empty, not "/"
- - add make uninstall targets
- - replace private path variables as needed (SBINDIR/sbindir)
- - ...
 
 # vim: tw=72 et