Skip to contentSkip to conversation

bloat-o-meter: Support comparing library archives

PATCH Superseded Nikolay Borisov 1 participant 1 message May 31, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bloat-o-meter: Support comparing library archives

Library archives (.a) usually contain multiple object files so their output of nm --size-sort contains lines like:

<ommitted for brevity>
00000000000003a8 t run_test

extent-map-tests.o:
<ommitted for brevity>

bloat-o-meter currently doesn't handle them which results in errors when calling .split() on them. Fix this by simply ignoring them. This enables diffing subsystems which generate built-in.a files.

---
 scripts/bloat-o-meter | 2 ++
 1 file changed, 2 insertions(+)
scripts/bloat-o-meter +2 -0
index 8c965f6a9881..d7ca46c612b3 100755
@@ -26,6 +26,8 @@ re_NUMBER = re.compile(r'\.[0-9]+')
     sym = {}
     with os.popen("nm --size-sort " + file) as f:
         for line in f:
+            if line.startswith("\n") or ":" in line:
+                continue
             size, type, name = line.split()
             if type in format:
                 # strip generated symbols
Signature · 1 line
2.17.1