arm: allwinner: a20: Add Drejo DS167 initial support
Subsystems (3)
PATCH 1/1 arm: allwinner: a20: Add Drejo DS167 initial support
From: Sertac TULLUK <[email protected]>
Drejo DS167 is an Allwinner A20 based IoT device,
which support
- Allwinner A20 Cortex-A7
- Mali-400MP2 GPU
- AXP209 PMIC
- 1GB DDR3 RAM
- 8GB eMMC
- 10/100M Ethernet
- SATA
- HDMI
- 10.1inch and 7.0inch LVDS LCD and Touch screens
- CSI: OV5640 sensor
- USB OTG
- 2x USB2.0
- built-in KNX Transceiver
- 3x Dry Contact Input
- 3x Relay output
- IR RX/TX
- UART3
- SPI1
- RTC Battery
- 8x GPIO
- Analogue + Digital Microphone
- PAM8620 speaker Amplifier
- 12V DC power supply
- 3.7V Battery Operable
--- arch/arm/boot/dts/Makefile | 2 + .../boot/dts/sun7i-a20-drejo-ds167-emmc.dts | 69 +++++ arch/arm/boot/dts/sun7i-a20-drejo-ds167.dts | 288 ++++++++++++++++++ 3 files changed, 359 insertions(+) create mode 100644 arch/arm/boot/dts/sun7i-a20-drejo-ds167-emmc.dts create mode 100644 arch/arm/boot/dts/sun7i-a20-drejo-ds167.dts
arch/arm/boot/dts/Makefile +2 -0
@@ -1097,6 +1097,8 @@ dtb-$(CONFIG_MACH_SUN7I) += \ sun7i-a20-bananapro.dtb \ sun7i-a20-cubieboard2.dtb \ sun7i-a20-cubietruck.dtb \ + sun7i-a20-drejo-ds167.dtb \ + sun7i-a20-drejo-ds167-emmc.dtb \ sun7i-a20-hummingbird.dtb \ sun7i-a20-itead-ibox.dtb \ sun7i-a20-i12-tvbox.dtb \
arch/arm/boot/dts/sun7i-a20-drejo-ds167-emmc.dts new file +69 -0
69 lines not on this page · raw message
arch/arm/boot/dts/sun7i-a20-drejo-ds167.dts new file +288 -0
288 lines not on this page · raw message
Signature · 1 line
2.17.1
Hi,
Please make sure that all the proper recipients are in Cc. The linux-arm-kernel ML especially is missing, get_maintainers will give you the list.
Also, the prefix of your commit log is supposed to be
ARM: dts: sunxi: ...
Quoted 43 lines · On Sun, May 31, 2020 at 02:05:38PM +0300, [email protected] wrote:
From: Sertac TULLUK <[email protected]>
Drejo DS167 is an Allwinner A20 based IoT device,
which support
- Allwinner A20 Cortex-A7
- Mali-400MP2 GPU
- AXP209 PMIC
- 1GB DDR3 RAM
- 8GB eMMC
- 10/100M Ethernet
- SATA
- HDMI
- 10.1inch and 7.0inch LVDS LCD and Touch screens
- CSI: OV5640 sensor
- USB OTG
- 2x USB2.0
- built-in KNX Transceiver
- 3x Dry Contact Input
- 3x Relay output
- IR RX/TX
- UART3
- SPI1
- RTC Battery
- 8x GPIO
- Analogue + Digital Microphone
- PAM8620 speaker Amplifier
- 12V DC power supply
- 3.7V Battery OperableSigned-off-by Sertac TULLUK <[email protected]>--- arch/arm/boot/dts/Makefile | 2 + .../boot/dts/sun7i-a20-drejo-ds167-emmc.dts | 69 +++++ arch/arm/boot/dts/sun7i-a20-drejo-ds167.dts | 288 ++++++++++++++++++ 3 files changed, 359 insertions(+) create mode 100644 arch/arm/boot/dts/sun7i-a20-drejo-ds167-emmc.dts create mode 100644 arch/arm/boot/dts/sun7i-a20-drejo-ds167.dtsarch/arm/boot/dts/Makefile +0
-0
arch/arm/boot/dts/Makefile dtb-$(CONFIG_MACH_SUN7I) += \ · line 1101
Quoted 5 lines
arch/arm/boot/dts/Makefile +2
-0@@ -1097,6 +1097,8 @@ dtb-$(CONFIG_MACH_SUN7I) += \ sun7i-a20-bananapro.dtb \ sun7i-a20-cubieboard2.dtb \ sun7i-a20-cubietruck.dtb \ + sun7i-a20-drejo-ds167.dtb \ + sun7i-a20-drejo-ds167-emmc.dtb \
You indented with spaces here, instead of a tab.
Quoted 42 lines
arch/arm/boot/dts/Makefile +0
-0sun7i-a20-hummingbird.dtb \ sun7i-a20-itead-ibox.dtb \ sun7i-a20-i12-tvbox.dtb \arch/arm/boot/dts/sun7i-a20-drejo-ds167-emmc.dts new file +33
-0@@ -0,0 +1,69 @@ +/* + * Copyright 2020 Sertac TULLUK + * + * Sertac TULLUK <[email protected]> + * + * This file is dual-licensed: you can use it either under the terms + * of the GPL or the X11 license, at your option. Note that this dual + * licensing only applies to this file, and not this project as a + * whole. + * + * a) This file is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of the + * License, or (at your option) any later version. + * + * This file is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * Or, alternatively, + * + * b) Permission is hereby granted, free of charge, to any person + * obtaining a copy of this software and associated documentation + * files (the "Software"), to deal in the Software without + * restriction, including without limitation the rights to use, + * copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following + * conditions: + * + * The above copyright notice and this permission notice shall be + * included in all copies or substantial portions of the Software.
arch/arm/boot/dts/sun7i-a20-drejo-ds167-emmc.dts line 43
Quoted 10 lines
arch/arm/boot/dts/sun7i-a20-drejo-ds167-emmc.dts new file +10
-0+ * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR + * OTHER DEALINGS IN THE SOFTWARE. + */
You should use an SPDX tag here
arch/arm/boot/dts/sun7i-a20-drejo-ds167-emmc.dts line 45
Quoted 1 line
arch/arm/boot/dts/sun7i-a20-drejo-ds167-emmc.dts new file +1
-0+#include "sun7i-a20-drejo-ds167.dts"
Is there any reason not to have the emmc into the main DTS?
arch/arm/boot/dts/sun7i-a20-drejo-ds167-emmc.dts line 48
Quoted 2 lines
arch/arm/boot/dts/sun7i-a20-drejo-ds167-emmc.dts new file +2
-0+/ { + model = "drejo DS167-eMMC";
Drejo should have an uppercase?
arch/arm/boot/dts/sun7i-a20-drejo-ds167-emmc.dts line 49
Quoted 1 line
arch/arm/boot/dts/sun7i-a20-drejo-ds167-emmc.dts new file +1
-0+ compatible = "drejo,sun7i-a20-drejo-ds167-emmc", "allwinner,sun7i-a20";
This compatible should be documented.
Also, this can be something like drejo,ds167 (the vendor should be documented too )
Quoted 99 lines
arch/arm/boot/dts/sun7i-a20-drejo-ds167-emmc.dts new file +20
-0+ + mmc2_pwrseq: pwrseq { + compatible = "mmc-pwrseq-emmc"; + reset-gpios = <&pio 2 24 GPIO_ACTIVE_LOW>; + }; +}; + +&mmc2 { + vmmc-supply = <®_vcc3v3>; + bus-width = <4>; + non-removable; + mmc-pwrseq = <&mmc2_pwrseq>; + status = "okay"; + + emmc: emmc@0 { + reg = <0>; + compatible = "mmc-card"; + broken-hpi; + }; +};arch/arm/boot/dts/sun7i-a20-drejo-ds167.dts new file +73
-0@@ -0,0 +1,288 @@ +/* + * Copyright 2020 Sertac TULLUK + * + * Sertac TULLUK <[email protected]> + * + * This file is dual-licensed: you can use it either under the terms + * of the GPL or the X11 license, at your option. Note that this dual + * licensing only applies to this file, and not this project as a + * whole. + * + * a) This file is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of the + * License, or (at your option) any later version. + * + * This file is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * Or, alternatively, + * + * b) Permission is hereby granted, free of charge, to any person + * obtaining a copy of this software and associated documentation + * files (the "Software"), to deal in the Software without + * restriction, including without limitation the rights to use, + * copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following + * conditions: + * + * The above copyright notice and this permission notice shall be + * included in all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR + * OTHER DEALINGS IN THE SOFTWARE. + */ + +/dts-v1/; +#include "sun7i-a20.dtsi" +#include "sunxi-common-regulators.dtsi" + +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/input/input.h> +#include <dt-bindings/interrupt-controller/irq.h> + +/ { + model = "drejo DS167"; + compatible = "drejo,sun7i-a20-drejo-ds167", "allwinner,sun7i-a20"; + + aliases { + serial0 = &uart0; + serial1 = &uart3; + + spi0 = &spi1; + spi1 = &spi2; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; + + hdmi-connector { + compatible = "hdmi-connector"; + type = "a"; + + port {
arch/arm/boot/dts/sun7i-a20-drejo-ds167.dts line 83
Quoted 10 lines
arch/arm/boot/dts/sun7i-a20-drejo-ds167.dts new file +10
-0+ hdmi_con_in: endpoint { + remote-endpoint = <&hdmi_out_con>; + }; + }; + }; + + leds { + compatible = "gpio-leds"; + pinctrl-names = "default"; + pinctrl-0 = <&led_pins_ds167>;
You don't need a pinctrl node for the GPIOs
arch/arm/boot/dts/sun7i-a20-drejo-ds167.dts line 86
Quoted 3 lines
arch/arm/boot/dts/sun7i-a20-drejo-ds167.dts new file +3
-0+ + red { + label = "ds167-status";
This isn't the proper red name, it should be something like ds167:red:status
Quoted 192 lines
arch/arm/boot/dts/sun7i-a20-drejo-ds167.dts new file +192
-0+ gpios = <&pio 8 9 GPIO_ACTIVE_LOW>; /* PI9 STATUS LED NEAR A20 SERTAC */ + default-state = "on"; + }; + }; +}; + +&ahci { + target-supply = <®_ahci_5v>; + status = "okay"; +}; + +&codec { + status = "okay"; +}; + +&cpu0 { + cpu-supply = <®_dcdc2>; +}; + +&de { + status = "okay"; +}; + +&ehci0 { + status = "okay"; +}; + +&ehci1 { + status = "okay"; +}; + +&gmac { + pinctrl-names = "default"; + pinctrl-0 = <&gmac_mii_pins>, <&gmac_txerr>; + phy-handle = <&phy1>; + phy-mode = "mii"; + status = "okay"; +}; + +&hdmi { + status = "okay"; +}; + +&hdmi_out { + hdmi_out_con: endpoint { + remote-endpoint = <&hdmi_con_in>; + }; +}; + +&i2c0 { + status = "okay"; + + axp209: pmic@34 { + reg = <0x34>; + interrupt-parent = <&nmi_intc>; + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; + }; +}; + +&i2c2 { + status = "okay"; +}; + +&lradc { + vref-supply = <®_vcc3v0>; + status = "okay"; +}; + +&gmac_mdio { + phy1: ethernet-phy@1 { + reg = <1>; + }; +}; + +&mmc0 { + vmmc-supply = <®_vcc3v3>; + bus-width = <4>; + cd-gpios = <&pio 7 1 GPIO_ACTIVE_LOW>; /* PH1 */ + status = "okay"; +}; + +&ohci0 { + status = "okay"; +}; + +&ohci1 { + status = "okay"; +}; + +&otg_sram { + status = "okay"; +}; + +&pio { + gmac_txerr: gmac-txerr-pin { + pins = "PA17"; + function = "gmac"; + }; + + led_pins_ds167: led-pins { + pins = "PI9"; /* Status led, on schematic, this is LED_EN */ + function = "gpio_out"; + drive-strength = <20>; + }; +}; + +&pwm { + pinctrl-names = "default"; + pinctrl-0 = <&pwm0_pin>, <&pwm1_pin>; + status = "okay"; +}; + +#include "axp209.dtsi" + +&ac_power_supply { + status = "okay"; +}; + +&battery_power_supply { + status = "okay"; +}; + +®_dcdc2 { + regulator-always-on; + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <1400000>; + regulator-name = "vdd-cpu"; +}; + +®_dcdc3 { + regulator-always-on; + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <1400000>; + regulator-name = "vdd-int-dll"; +}; + +®_ldo2 { + regulator-always-on; + regulator-min-microvolt = <3000000>; + regulator-max-microvolt = <3000000>; + regulator-name = "avcc"; +}; + +®_ahci_5v { + status = "okay"; +}; + +®_usb0_vbus { + status = "okay"; +}; + +®_usb1_vbus { + status = "okay"; +}; + +®_usb2_vbus { + status = "okay"; +}; + +&spi1 { + pinctrl-names = "default"; + pinctrl-0 = <&spi1_pi_pins>, + <&spi1_cs0_pi_pin>; + status = "okay"; +}; + +&spi2 { + pinctrl-names = "default"; + pinctrl-0 = <&spi2_pc_pins>, + <&spi2_cs0_pc_pin>; + status = "okay"; +}; + +&uart0 { + pinctrl-names = "default"; + pinctrl-0 = <&uart0_pb_pins>; + status = "okay"; +}; + +&uart3 { + pinctrl-names = "default"; + pinctrl-0 = <&uart3_pg_pins>; + status = "okay"; +}; + +&usb_otg { + dr_mode = "otg"; + status = "okay"; +}; + +&usb_power_supply { + status = "okay";
arch/arm/boot/dts/sun7i-a20-drejo-ds167.dts line 288
Quoted 10 lines
arch/arm/boot/dts/sun7i-a20-drejo-ds167.dts new file +10
-0+}; + +&usbphy { + usb0_id_det-gpios = <&pio 7 4 (GPIO_ACTIVE_HIGH | GPIO_PULL_UP)>; /* PH4 */ + usb0_vbus_det-gpios = <&pio 7 5 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>; /* PH5 */ + usb0_vbus-supply = <®_usb0_vbus>; + usb1_vbus-supply = <®_usb1_vbus>; + usb2_vbus-supply = <®_usb2_vbus>; + status = "okay"; +};
Looks good otherwise, thanks!
Maxime