iommu: amd: Fix IO_PAGE_FAULT due to __unmap_single() size overflow
PATCH 1/1 iommu: amd: Fix IO_PAGE_FAULT due to __unmap_single() size overflow
Currently, an integer is used to specify the size in unmap_sg(). With 2GB worth of pages (512k 4k pages), it requires 31 bits (i.e. (1 << 19) << 12), which overflows the integer, and ends up unmapping more pages than intended. Subsequently, this results in IO_PAGE_FAULT.
Uses size_t instead of int to pass parameter to __unmap_single().
Reported-by Robert Lippert <[email protected]>
Signed-off-by Suravee Suthikulpanit <[email protected]>
---
Note: This patch is intended for stable tree prior 5.5 due to commit be62dbf554c5 ("iommu/amd: Convert AMD iommu driver to the dma-iommu api"), where the function unmap_sg() was removed.
drivers/iommu/amd_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/amd_iommu.c +1 -1
@@ -2670,7 +2670,7 @@ static void unmap_sg(struct device *dev, struct scatterlist *sglist,struct protection_domain *domain;struct dma_ops_domain *dma_dom;unsigned long startaddr; -int npages; +size_t npages; domain =get_domain (dev);if (IS_ERR (domain))
Signature · 1 line
2.17.1