Skip to contentSkip to conversation

mmc: sdhci: use PCI_IRQ_MSI_TYPES where appropriate

PATCH Applied Piotr Stankiewicz 4 participants 5 messages Jun 2, 2020 – Jun 3, 2020

Subsystems (2)

v1 of 4 Applied Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 11/15 mmc: sdhci: use PCI_IRQ_MSI_TYPES where appropriate

Seeing as there is shorthand available to use when asking for any type of interrupt, or any type of message signalled interrupt, leverage it.

---
 drivers/mmc/host/sdhci-pci-gli.c     | 3 +--
 drivers/mmc/host/sdhci-pci-o2micro.c | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)
drivers/mmc/host/sdhci-pci-gli.c +1 -2
index fd76aa672e02..d14997f9cbf9 100644
@@ -271,8 +271,7 @@ static void gli_pcie_enable_msi(struct sdhci_pci_slot *slot)
 {
 	int ret;
 
-	ret = pci_alloc_irq_vectors(slot->chip->pdev, 1, 1,
-				    PCI_IRQ_MSI | PCI_IRQ_MSIX);
+	ret = pci_alloc_irq_vectors(slot->chip->pdev, 1, 1, PCI_IRQ_MSI_TYPES);
 	if (ret < 0) {
 		pr_warn("%s: enable PCI MSI failed, error=%d\n",
 		       mmc_hostname(slot->host->mmc), ret);
drivers/mmc/host/sdhci-pci-o2micro.c +1 -2
index fa8105087d68..498c51207bfb 100644
@@ -470,8 +470,7 @@ static void sdhci_pci_o2_enable_msi(struct sdhci_pci_chip *chip,
 		return;
 	}
 
-	ret = pci_alloc_irq_vectors(chip->pdev, 1, 1,
-				    PCI_IRQ_MSI | PCI_IRQ_MSIX);
+	ret = pci_alloc_irq_vectors(chip->pdev, 1, 1, PCI_IRQ_MSI_TYPES);
 	if (ret < 0) {
 		pr_err("%s: enable PCI MSI failed, err=%d\n",
 		       mmc_hostname(host->mmc), ret);
Signature · 1 line
2.17.2
Acked-by on v1 11/15
#1 lore raw
Quoted 6 lines · Piotr Stankiewicz

Seeing as there is shorthand available to use when asking for any type of interrupt, or any type of message signalled interrupt, leverage it.

Kind regards
Uffe

Quoted 36 lines
---
 drivers/mmc/host/sdhci-pci-gli.c     | 3 +--
 drivers/mmc/host/sdhci-pci-o2micro.c | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)
drivers/mmc/host/sdhci-pci-gli.c +1 -2
index fd76aa672e02..d14997f9cbf9 100644
@@ -271,8 +271,7 @@ static void gli_pcie_enable_msi(struct sdhci_pci_slot *slot)
 {
        int ret;
 
-       ret = pci_alloc_irq_vectors(slot->chip->pdev, 1, 1,
-                                   PCI_IRQ_MSI | PCI_IRQ_MSIX);
+       ret = pci_alloc_irq_vectors(slot->chip->pdev, 1, 1, PCI_IRQ_MSI_TYPES);
        if (ret < 0) {
                pr_warn("%s: enable PCI MSI failed, error=%d\n",
                       mmc_hostname(slot->host->mmc), ret);
drivers/mmc/host/sdhci-pci-o2micro.c +1 -3
index fa8105087d68..498c51207bfb 100644
@@ -470,8 +470,7 @@ static void sdhci_pci_o2_enable_msi(struct sdhci_pci_chip *chip,
                return;
        }
 
-       ret = pci_alloc_irq_vectors(chip->pdev, 1, 1,
-                                   PCI_IRQ_MSI | PCI_IRQ_MSIX);
+       ret = pci_alloc_irq_vectors(chip->pdev, 1, 1, PCI_IRQ_MSI_TYPES);
        if (ret < 0) {
                pr_err("%s: enable PCI MSI failed, err=%d\n",
                       mmc_hostname(host->mmc), ret);
--

2.17.2

maintainer Acked-by on v1 11/15
#2 lore raw
In reply to Piotr Stankiewicz
Quoted 5 lines · Piotr Stankiewicz

Seeing as there is shorthand available to use when asking for any type of interrupt, or any type of message signalled interrupt, leverage it.

Quoted 34 lines
---
 drivers/mmc/host/sdhci-pci-gli.c     | 3 +--
 drivers/mmc/host/sdhci-pci-o2micro.c | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)
drivers/mmc/host/sdhci-pci-gli.c +1 -2
index fd76aa672e02..d14997f9cbf9 100644
@@ -271,8 +271,7 @@ static void gli_pcie_enable_msi(struct sdhci_pci_slot *slot)
 {
 	int ret;
 
-	ret = pci_alloc_irq_vectors(slot->chip->pdev, 1, 1,
-				    PCI_IRQ_MSI | PCI_IRQ_MSIX);
+	ret = pci_alloc_irq_vectors(slot->chip->pdev, 1, 1, PCI_IRQ_MSI_TYPES);
 	if (ret < 0) {
 		pr_warn("%s: enable PCI MSI failed, error=%d\n",
 		       mmc_hostname(slot->host->mmc), ret);
drivers/mmc/host/sdhci-pci-o2micro.c +1 -2
index fa8105087d68..498c51207bfb 100644
@@ -470,8 +470,7 @@ static void sdhci_pci_o2_enable_msi(struct sdhci_pci_chip *chip,
 		return;
 	}
 
-	ret = pci_alloc_irq_vectors(chip->pdev, 1, 1,
-				    PCI_IRQ_MSI | PCI_IRQ_MSIX);
+	ret = pci_alloc_irq_vectors(chip->pdev, 1, 1, PCI_IRQ_MSI_TYPES);
 	if (ret < 0) {
 		pr_err("%s: enable PCI MSI failed, err=%d\n",
 		       mmc_hostname(host->mmc), ret);
#3 lore raw
In reply to Piotr Stankiewicz
Quoted 5 lines · Piotr Stankiewicz

Seeing as there is shorthand available to use when asking for any type of interrupt, or any type of message signalled interrupt, leverage it.

So this crap now shows up piecemail on various lists? Indepent of that it seems like a bad idea to start with, bombing people with patches that apparently depend on something you did first but they are not Cced on is just an amazingly bad idea. Don't do that ever.

#4 lore raw
Quoted 14 lines

-----Original Message-----
From: Christoph Hellwig <[email protected]>
Sent: Wednesday, June 3, 2020 7:27 AM
To: Stankiewicz, Piotr <[email protected]>
Cc: Hunter, Adrian <[email protected]>; Ulf Hansson <[email protected]>; [email protected]; linux- [email protected]
Subject: Re: [PATCH 11/15] mmc: sdhci: use PCI_IRQ_MSI_TYPES where appropriate

Quoted 3 lines · Piotr Stankiewicz

Seeing as there is shorthand available to use when asking for any type of interrupt, or any type of message signalled interrupt, leverage it.

Quoted 7 lines
Quoted 2 lines

So this crap now shows up piecemail on various lists? Indepent of that it seems like a bad idea to start with, bombing people with patches that apparently depend on something you did first but they are not Cced on is just an amazingly bad idea. Don't do that ever.

I've sent the cover letter for the series to everyone question, to avoid spamming people with irrelevant patches, but so that they can find the rest if necessary. What would be a preferable thing to do?