hw/block/nvme: Verify msix_vector_use() returned value
PATCH 1/1 hw/block/nvme: Verify msix_vector_use() returned value
msix_vector_use() returns -EINVAL on error. Assert it won't.
Signed-off-by Philippe Mathieu-Daudé <[email protected]>
---
Notes taken while reviewing:
https://www.mail-archive.com/[email protected]/msg66831.html
Based-on: <[email protected]>
--- hw/block/nvme.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
hw/block/nvme.c +4 -1
@@ -613,6 +613,10 @@ static uint16_t nvme_del_cq(NvmeCtrl *n, NvmeCmd *cmd)static void nvme_init_cq (NvmeCQueue *cq,NvmeCtrl *n,uint64_t dma_addr,uint16_t cqid,uint16_t vector,uint16_t size,uint16_t irq_enabled) { +int ret; + + ret =msix_vector_use (&n->parent_obj, vector); +assert (ret ==0 ); cq->ctrl = n; cq->cqid = cqid; cq->size = size;
@@ -623,7 +627,6 @@ static void nvme_init_cq(NvmeCQueue *cq, NvmeCtrl *n, uint64_t dma_addr, cq->head = cq->tail =0 ;QTAILQ_INIT (&cq->req_list);QTAILQ_INIT (&cq->sq_list); -msix_vector_use (&n->parent_obj, cq->vector); n->cq[cqid] = cq; cq->timer =timer_new_ns (QEMU_CLOCK_VIRTUAL , nvme_post_cqes, cq); }
Signature · 1 line
2.21.3
Kevin Wolf
AppliedAm 02.06.2020 um 17:57 hat Philippe Mathieu-Daudé geschrieben:
Quoted 7 lines
msix_vector_use()returns-EINVALon error. Assert it won't.Signed-off-by Philippe Mathieu-Daudé <[email protected]>---
Notes taken while reviewing:
https://www.mail-archive.com/[email protected]/msg66831.html
Based-on: <[email protected]>
Thanks, applied to the block branch.
Kevin