Skip to contentSkip to conversation

drm/nouveau: gr/gk20a: Use firmware version 0

PATCH In review Thierry Reding 3 participants 3 messages Jun 3, 2020

Subsystems (4)
DRM drivers DRM misc Tegra architecture support nouveau
lore
Share & tools
lore

Thierry Reding

author
#0 lore raw

PATCH 1/1 drm/nouveau: gr/gk20a: Use firmware version 0

From: Thierry Reding <[email protected]>

Tegra firmware doesn't actually use any version numbers and passing -1 causes the existing firmware binaries not to be found. Use version 0 to find the correct files.

Signed-off-by Thierry Reding <[email protected]>
---
 drivers/gpu/drm/nouveau/nvkm/engine/gr/gk20a.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nvkm/engine/gr/gk20a.c +1 -1
index ec330d791d15..e56880f3e3bd 100644
@@ -352,7 +352,7 @@ gk20a_gr_load(struct gf100_gr *gr, int ver, const struct gf100_gr_fwif *fwif)
 
 static const struct gf100_gr_fwif
 gk20a_gr_fwif[] = {
-	{ -1, gk20a_gr_load, &gk20a_gr },
+	{ 0, gk20a_gr_load, &gk20a_gr },
 	{}
 };
Signature · 1 line
2.24.1
#2 lore raw
Quoted 9 lines · Emil Velikov
Quoted 7 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Tegra firmware doesn't actually use any version numbers and passing -1 causes the existing firmware binaries not to be found. Use version 0 to find the correct files.

Quoted 5 lines
Quoted 1 line
Signed-off-by Thierry Reding <[email protected]>
Fixes ef16dc278ec2 ("drm/nouveau/gr/gf100-: select implementation

based on available FW")

Reviewed-by Emil Velikov <[email protected]>

Oops, my bad. Merged.

Ben.

Quoted 6 lines

-Emil
_______________________________________________
Nouveau mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/nouveau