mmc: sdio: Return ret if sdio_disable_func() fails
PATCH 1/1 mmc: sdio: Return ret if sdio_disable_func() fails
From: Yue Hu <[email protected]>
We should return any possible error returned by mmc_io_rw_direct() rather than only -EIO in sdio_disable_func() failure path.
Signed-off-by Yue Hu <[email protected]>
--- drivers/mmc/core/sdio_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/core/sdio_io.c +1 -1
@@ -133,7 +133,7 @@ int sdio_disable_func(struct sdio_func *func) err:pr_debug ("SDIO: Failed to disable device %s\n" ,sdio_func_id (func)); -return -EIO ; +return ret; }EXPORT_SYMBOL_GPL (sdio_disable_func);
Signature · 1 line
1.9.1
Hi,
Quoted 10 lines · Yue Hu
From: Yue Hu <[email protected]>
We should return any possible error returned by
mmc_io_rw_direct()rather than only-EIOinsdio_disable_func()failure path.Signed-off-by Yue Hu <[email protected]>--- drivers/mmc/core/sdio_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Seems sane to me.
Reviewed-by Douglas Anderson <[email protected]>
Quoted 7 lines · Yue Hu
From: Yue Hu <[email protected]>
We should return any possible error returned by
mmc_io_rw_direct()rather than only-EIOinsdio_disable_func()failure path.Signed-off-by Yue Hu <[email protected]>
Applied for next, thanks!
Kind regards
Uffe
Quoted 20 lines
--- drivers/mmc/core/sdio_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/core/sdio_io.c +1
-2@@ -133,7 +133,7 @@ int sdio_disable_func(struct sdio_func *func) err:pr_debug ("SDIO: Failed to disable device %s\n" ,sdio_func_id (func)); -return -EIO ; +return ret; }EXPORT_SYMBOL_GPL (sdio_disable_func); --1.9.1