Skip to contentSkip to conversation

net/xdp: use shift instead of 64 bit division

PATCH In review Pavel Machek 2 participants 2 messages Jun 4, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/xdp: use shift instead of 64 bit division

64bit division is kind of expensive, and shift should do the job here.

---

Now with patch. Sorry about that.

net/xdp/xdp_umem.c +1 -1
index 3889bd9aec46..d6c91a43a1ee 100644
@@ -372,7 +372,7 @@ static int xdp_umem_reg(struct xdp_umem *umem, struct xdp_umem_reg *mr)
 	if ((addr + size) < addr)
 		return -EINVAL;
 
-	npgs = div_u64(size, PAGE_SIZE);
+	npgs = size >> PAGE_SHIFT;
 	if (npgs > U32_MAX)
 		return -EINVAL;
 
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html