Skip to contentSkip to conversation

mmc: sunxi-mmc: do not hide address in sunxi_mmc_irq()

PATCH In review Frank Lee 3 participants 5 messages Jun 5, 2020 – Jun 9, 2020

Subsystems (4)
lore
Share & tools
lore
author
#1 lore raw

PATCH 2/2 mmc: mediatek: do not hide address in msdc_request_timeout()

In reply to Frank Lee

From: Yangtao Li <[email protected]>

Using %px to show the actual address in msdc_request_timeout() to help us to debug issue.

---
 drivers/mmc/host/mtk-sd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/mtk-sd.c +1 -1
index 39e7fc54c438..28b4a136fc72 100644
@@ -1411,7 +1411,7 @@ static void msdc_request_timeout(struct work_struct *work)
 	/* simulate HW timeout status */
 	dev_err(host->dev, "%s: aborting cmd/data/mrq\n", __func__);
 	if (host->mrq) {
-		dev_err(host->dev, "%s: aborting mrq=%p cmd=%d\n", __func__,
+		dev_err(host->dev, "%s: aborting mrq=%px cmd=%d\n", __func__,
 				host->mrq, host->mrq->cmd->opcode);
 		if (host->cmd) {
 			dev_err(host->dev, "%s: aborting cmd=%d\n",
Signature · 1 line
2.24.0

Frank Lee

author
#0 lore raw

PATCH 1/2 mmc: sunxi-mmc: do not hide address in sunxi_mmc_irq()

From: Yangtao Li <[email protected]>

Using %px to show the actual address in sunxi_mmc_irq() to help us to debug issue.

---
 drivers/mmc/host/sunxi-mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sunxi-mmc.c +1 -1
index 5e95bbc51644..dcd30c3e1fac 100644
@@ -574,7 +574,7 @@ static irqreturn_t sunxi_mmc_irq(int irq, void *dev_id)
 	idma_int  = mmc_readl(host, REG_IDST);
 	msk_int   = mmc_readl(host, REG_MISTA);
 
-	dev_dbg(mmc_dev(host->mmc), "irq: rq %p mi %08x idi %08x\n",
+	dev_dbg(mmc_dev(host->mmc), "irq: rq %px mi %08x idi %08x\n",
 		host->mrq, msk_int, idma_int);
 
 	mrq = host->mrq;
Signature · 1 line
2.24.0
#3 lore raw
Quoted 9 lines · Maxime Ripard

Hi,

Quoted 5 lines · Frank Lee

From: Yangtao Li <[email protected]>

Using %px to show the actual address in sunxi_mmc_irq() to help us to debug issue.

Quoted 8 lines
Quoted 2 lines

I'm fairly sure this hash is on purpose, and both the commit log of the %px introduction (ad67b74d2469) and the checkpatch message are pretty explicit about it.

What issue were you trying to solve here?

There doesn't seem to be a strong requirement to force this to be printed out, I just think that ____ptrval____ is very unpleasant.

Or delete %p directly?

Yangtao

#4 lore raw
Quoted 13 lines · Frank Lee
Quoted 12 lines · Maxime Ripard

Hi,

Quoted 7 lines · Frank Lee

From: Yangtao Li <[email protected]>

Using %px to show the actual address in sunxi_mmc_irq() to help us to debug issue.

Quoted 8 lines
Quoted 5 lines

I'm fairly sure this hash is on purpose, and both the commit log of the %px introduction (ad67b74d2469) and the checkpatch message are pretty explicit about it.

What issue were you trying to solve here?

There doesn't seem to be a strong requirement to force this to be printed out, I just think that ____ptrval____ is very unpleasant.

That should happen only at boot when the system doesn't have enough entropy iirc, after a while it prints out hashes.

Quoted 1 line

Or delete %p directly?

You mean the message in the driver? I'd be fine with that too.

Maxime