overlay: remove not necessary lock check.
PATCH 1/1 overlay: remove not necessary lock check.
dir is always locked until "out_unlock" label.
So lock check is not needed.
Signed-off-by youngjun <[email protected]>
--- fs/overlayfs/super.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
fs/overlayfs/super.c +1 -5
@@ -615,10 +615,8 @@ static struct dentry *ovl_workdir_create(struct ovl_fs *ofs,struct dentry *work;int err;bool retried = false; -bool locked = false;inode_lock_nested (dir,I_MUTEX_PARENT ); - locked = true; retry: work =lookup_one_len (name, ofs->workbasedir,strlen (name));
@@ -680,9 +678,7 @@ static struct dentry *ovl_workdir_create(struct ovl_fs *ofs, goto out_err; } out_unlock: -if (locked) -inode_unlock (dir); - +inode_unlock (dir);return work; out_dput:
Signature · 1 line
2.17.1
Quoted 3 lines · youngjun
dir is always locked until "
out_unlock" label.
So lock check is not needed.
Thanks, applied.
Miklos