drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM
Subsystems (3)
PATCH v2 1/1 drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM
There is no need to select DRM_RCAR_WRITEBACK if DRM=n which just make the generated .config a bit ugly.
# ARM devices
#
# end of ARM devices
CONFIG_DRM_RCAR_WRITEBACK=y
#
# Frame buffer Devices
Let DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU instead.
--- drivers/gpu/drm/rcar-du/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/rcar-du/Kconfig +1 -0
@@ -48,3 +48,4 @@ config DRM_RCAR_VSP config DRM_RCAR_WRITEBACK bool default y if ARM64 + depends on DRM_RCAR_DU
Signature · 1 line
2.21.0 (Apple Git-122.2)
Hi Qian,
Thank you for the patch.
Quoted 1 line · Qian Cai
There is no need to select
DRM_RCAR_WRITEBACKif DRM=n which just make
s/DRM=n/DRM_RCAR_DU=n/ here.
Quoted 6 lines
the generated .config a bit ugly.
# ARM devices
## end of ARM devices
Quoted 8 lines
CONFIG_DRM_RCAR_WRITEBACK=y#
# Frame buffer DevicesLet
DRM_RCAR_WRITEBACKdepend onDRM_RCAR_DUinstead.Signed-off-by Qian Cai <[email protected]>
No need to submit a v3 if you agree with the above change, I'll fix it in my tree.
Quoted 13 lines
--- drivers/gpu/drm/rcar-du/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/rcar-du/Kconfig +1
-0@@ -48,3 +48,4 @@ config DRM_RCAR_VSP config DRM_RCAR_WRITEBACK bool default y if ARM64 + depends on DRM_RCAR_DU
Signature · 3 lines
Regards, Laurent Pinchart
Hi Qian,
I forgot to mention, I think the subject line should be
drm/rcar-du: Make DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU
Could you please let me know if you're OK with these two small changes ?
Quoted 38 lines · Laurent Pinchart
Quoted 1 line · Qian Cai
There is no need to select
DRM_RCAR_WRITEBACKif DRM=n which just makes/DRM=n/DRM_RCAR_DU=n/ here.
Quoted 6 lines
the generated .config a bit ugly.
# ARM devices
## end of ARM devicesQuoted 8 lines
CONFIG_DRM_RCAR_WRITEBACK=y#
# Frame buffer DevicesLet
DRM_RCAR_WRITEBACKdepend onDRM_RCAR_DUinstead.Signed-off-by Qian Cai <[email protected]>Reviewed-by Laurent Pinchart <[email protected]>No need to submit a v3 if you agree with the above change, I'll fix it in my tree.
Quoted 13 lines
--- drivers/gpu/drm/rcar-du/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/rcar-du/Kconfig +1
-0@@ -48,3 +48,4 @@ config DRM_RCAR_VSP config DRM_RCAR_WRITEBACK bool default y if ARM64 + depends on DRM_RCAR_DU
Signature · 3 lines
Regards, Laurent Pinchart
Quoted 9 lines · Laurent Pinchart
I forgot to mention, I think the subject line should be
drm/rcar-du: Make
DRM_RCAR_WRITEBACKdepend onDRM_RCAR_DUCould you please let me know if you're OK with these two small changes ?
Yes, I am fine with those.
Kieran Bingham
Reviewed-byHi Qian, Laurent,
Quoted 4 lines · Qian Cai
Quoted 4 lines · Laurent Pinchart
Quoted 8 lines
Quoted 5 lines
I forgot to mention, I think the subject line should be
drm/rcar-du: Make
DRM_RCAR_WRITEBACKdepend onDRM_RCAR_DUCould you please let me know if you're OK with these two small changes ?
Yes, I am fine with those.
With the fixups,
--
Kieran
Quoted 7 lines · Laurent Pinchart
Hi Qian,
I forgot to mention, I think the subject line should be
drm/rcar-du: Make
DRM_RCAR_WRITEBACKdepend onDRM_RCAR_DUCould you please let me know if you're OK with these two small changes ?
Laurent, this patch is still not in the latest linux-next. Can you take a look?
Quoted 45 lines · Laurent Pinchart
Quoted 38 lines · Qian Cai
Quoted 1 line
There is no need to select
DRM_RCAR_WRITEBACKif DRM=n which just makes/DRM=n/DRM_RCAR_DU=n/ here.
Quoted 6 lines
the generated .config a bit ugly.
# ARM devices
## end of ARM devicesQuoted 8 lines
CONFIG_DRM_RCAR_WRITEBACK=y#
# Frame buffer DevicesLet
DRM_RCAR_WRITEBACKdepend onDRM_RCAR_DUinstead.Signed-off-by Qian Cai <[email protected]>Reviewed-by Laurent Pinchart <[email protected]>No need to submit a v3 if you agree with the above change, I'll fix it in my tree.
Quoted 13 lines
--- drivers/gpu/drm/rcar-du/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/rcar-du/Kconfig +1
-0@@ -48,3 +48,4 @@ config DRM_RCAR_VSP config DRM_RCAR_WRITEBACK bool default y if ARM64 + depends on DRM_RCAR_DUSignature · 3 lines
Regards, Laurent Pinchart
Hi Qian,
Quoted 10 lines · Qian Cai
Quoted 7 lines · Laurent Pinchart
Hi Qian,
I forgot to mention, I think the subject line should be
drm/rcar-du: Make
DRM_RCAR_WRITEBACKdepend onDRM_RCAR_DUCould you please let me know if you're OK with these two small changes ?
Laurent, this patch is still not in the latest linux-next. Can you take a look?
Sorry for the delay. It will be included in the pull request I send this week.
Quoted 39 lines
Quoted 39 lines · Laurent Pinchart
Quoted 38 lines · Qian Cai
Quoted 1 line
There is no need to select
DRM_RCAR_WRITEBACKif DRM=n which just makes/DRM=n/DRM_RCAR_DU=n/ here.
Quoted 6 lines
the generated .config a bit ugly.
# ARM devices
## end of ARM devicesQuoted 8 lines
CONFIG_DRM_RCAR_WRITEBACK=y#
# Frame buffer DevicesLet
DRM_RCAR_WRITEBACKdepend onDRM_RCAR_DUinstead.Signed-off-by Qian Cai <[email protected]>Reviewed-by Laurent Pinchart <[email protected]>No need to submit a v3 if you agree with the above change, I'll fix it in my tree.
Quoted 13 lines
--- drivers/gpu/drm/rcar-du/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/rcar-du/Kconfig +1
-0@@ -48,3 +48,4 @@ config DRM_RCAR_VSP config DRM_RCAR_WRITEBACK bool default y if ARM64 + depends on DRM_RCAR_DU
Signature · 7 lines
Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel