Skip to contentSkip to conversation

virtio-mem: drop unnecessary initialization

PATCH In review Michael S. Tsirkin 4 participants 4 messages Jun 8, 2020 – Jun 9, 2020

Subsystems (2)
lore
Share & tools
lore

Michael S. Tsirkin

author maintainer
#0 lore raw

PATCH 1/1 virtio-mem: drop unnecessary initialization

rc is initialized to -ENIVAL but that's never used. Drop it.

Fixes 5f1f79bbc9e2 ("virtio-mem: Paravirtualized memory hotplug")
---
 drivers/virtio/virtio_mem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/virtio/virtio_mem.c +1 -1
index f658fe9149be..2f357142ea5e 100644
@@ -1768,7 +1768,7 @@ static void virtio_mem_delete_resource(struct virtio_mem *vm)
 static int virtio_mem_probe(struct virtio_device *vdev)
 {
 	struct virtio_mem *vm;
-	int rc = -EINVAL;
+	int rc;
 
 	BUILD_BUG_ON(sizeof(struct virtio_mem_req) != 24);
 	BUILD_BUG_ON(sizeof(struct virtio_mem_resp) != 10);
Signature · 1 line
MST
Acked-by on v1 1/1
#1 lore raw
Quoted 14 lines · Michael S. Tsirkin

rc is initialized to -ENIVAL but that's never used. Drop it.

Fixes 5f1f79bbc9e2 ("virtio-mem: Paravirtualized memory hotplug")
---
  drivers/virtio/virtio_mem.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/virtio/virtio_mem.c +0 -0
index f658fe9149be..2f357142ea5e 100644

drivers/virtio/virtio_mem.c static void virtio_mem_delete_resource(struct virtio_mem *vm) · line 1774

Quoted 8 lines
drivers/virtio/virtio_mem.c +1 -1
@@ -1768,7 +1768,7 @@ static void virtio_mem_delete_resource(struct virtio_mem *vm)
  static int virtio_mem_probe(struct virtio_device *vdev)
  {
  	struct virtio_mem *vm;
-	int rc = -EINVAL;
+	int rc;
 
  	BUILD_BUG_ON(sizeof(struct virtio_mem_req) != 24);
  	BUILD_BUG_ON(sizeof(struct virtio_mem_resp) != 10);

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Acked-by on v1 1/1
#2 lore raw
In reply to Michael S. Tsirkin
Quoted 15 lines · Michael S. Tsirkin

rc is initialized to -ENIVAL but that's never used. Drop it.

Fixes 5f1f79bbc9e2 ("virtio-mem: Paravirtualized memory hotplug")
---
 drivers/virtio/virtio_mem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/virtio/virtio_mem.c +0 -0
index f658fe9149be..2f357142ea5e 100644

drivers/virtio/virtio_mem.c static void virtio_mem_delete_resource(struct virtio_mem *vm) · line 1774

Quoted 8 lines
drivers/virtio/virtio_mem.c +1 -1
@@ -1768,7 +1768,7 @@ static void virtio_mem_delete_resource(struct virtio_mem *vm)
 static int virtio_mem_probe(struct virtio_device *vdev)
 {
 	struct virtio_mem *vm;
-	int rc = -EINVAL;
+	int rc;
 
 	BUILD_BUG_ON(sizeof(struct virtio_mem_req) != 24);
 	BUILD_BUG_ON(sizeof(struct virtio_mem_resp) != 10);
Signature · 3 lines
Thanks,

David / dhildenb
Reviewed-by on v1 1/1
#3 lore raw
In reply to Michael S. Tsirkin
Quoted 14 lines

rc is initialized to -ENIVAL but that's never used. Drop it.

Fixes 5f1f79bbc9e2 ("virtio-mem: Paravirtualized memory hotplug")
---
 drivers/virtio/virtio_mem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/virtio/virtio_mem.c +0 -0
index f658fe9149be..2f357142ea5e 100644

drivers/virtio/virtio_mem.c static void virtio_mem_delete_resource(struct virtio_mem *vm) · line 1774

Quoted 8 lines
drivers/virtio/virtio_mem.c +1 -1
@@ -1768,7 +1768,7 @@ static void virtio_mem_delete_resource(struct virtio_mem *vm)
 static int virtio_mem_probe(struct virtio_device *vdev)
 {
        struct virtio_mem *vm;
-       int rc = -EINVAL;
+       int rc;
 
        BUILD_BUG_ON(sizeof(struct virtio_mem_req) != 24);
        BUILD_BUG_ON(sizeof(struct virtio_mem_resp) != 10);