Skip to contentSkip to conversation

rk3399: Add BOOTENV_SF command

PATCH In review Jagan Teki 4 participants 6 messages Jun 8, 2020 – Jun 27, 2020 Arm Rockchip

lore
Share & tools
lore

Jagan Teki

author
#0 lore raw

PATCH 1/1 rk3399: Add BOOTENV_SF command

Add missing BOOTENV_SF command in rk3399 config.

Fix it.

---
 include/configs/rk3399_common.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/rk3399_common.h +1 -0
index f0ae6e67a7..e63ebb14f7 100644
@@ -67,6 +67,7 @@
 	"partitions=" PARTS_DEFAULT \
 	ROCKCHIP_DEVICE_SETTINGS \
 	BOOTENV \
+	BOOTENV_SF \
 	"altbootcmd=" \
 		"setenv boot_syslinux_conf extlinux/extlinux-rollback.conf;" \
 		"run distro_bootcmd\0"
Signature · 1 line
2.20.1
#2 lore raw
Quoted 6 lines · Jagan Teki
Quoted 5 lines · Jagan Teki

Add missing BOOTENV_SF command in rk3399 config.

Fix it.

Quoted 7 lines
Quoted 5 lines
Fixes f263b860acf8 ("rk3399: Enable SF distro bootcmd")

---

Can someone push this fix patch to master?

Kever, do you want me to pick this up? Do you have some objection? FWIW, include/configs/rk3399_common.h should get listed under some MAINTAINER entry directly. Thanks!

Signature · 1 line
Tom
#3 lore raw

Hi Tom,

Quoted 11 lines · Tom Rini
Quoted 10 lines · Jagan Teki
Quoted 9 lines · Jagan Teki

Add missing BOOTENV_SF command in rk3399 config.

Fix it.

Fixes f263b860acf8 ("rk3399: Enable SF distro bootcmd")

---

Quoted 4 lines
Quoted 1 line

Can someone push this fix patch to master?

Kever, do you want me to pick this up? Do you have some objection? FWIW, include/configs/rk3399_common.h should get listed under some MAINTAINER entry directly. Thanks!

I will apply this patch and send to fix RP.

Thanks,

- Kever

Reviewed-by on v1 1/1
#4 lore raw
In reply to Jagan Teki
Quoted 8 lines · Jagan Teki

Add missing BOOTENV_SF command in rk3399 config.

Fix it.

Fixes f263b860acf8 ("rk3399: Enable SF distro bootcmd")

Thanks,
- Kever

Quoted 16 lines
---
  include/configs/rk3399_common.h | 1 +
  1 file changed, 1 insertion(+)
include/configs/rk3399_common.h +1 -0
index f0ae6e67a7..e63ebb14f7 100644
@@ -67,6 +67,7 @@
  	"partitions=" PARTS_DEFAULT \
  	ROCKCHIP_DEVICE_SETTINGS \
  	BOOTENV \
+	BOOTENV_SF \
  	"altbootcmd=" \
  		"setenv boot_syslinux_conf extlinux/extlinux-rollback.conf;" \
  		"run distro_bootcmd\0"
#5 lore raw
In reply to Jagan Teki
Quoted 8 lines · Jagan Teki

Add missing BOOTENV_SF command in rk3399 config.

Fix it.

Fixes f263b860acf8 ("rk3399: Enable SF distro bootcmd")

Applied to u-boot-rockchip master branch.

Quoted 16 lines
---
  include/configs/rk3399_common.h | 1 +
  1 file changed, 1 insertion(+)
include/configs/rk3399_common.h +1 -0
index f0ae6e67a7..e63ebb14f7 100644
@@ -67,6 +67,7 @@
  	"partitions=" PARTS_DEFAULT \
  	ROCKCHIP_DEVICE_SETTINGS \
  	BOOTENV \
+	BOOTENV_SF \
  	"altbootcmd=" \
  		"setenv boot_syslinux_conf extlinux/extlinux-rollback.conf;" \
  		"run distro_bootcmd\0"