hwmon: (bt1-pvt) Mark is_visible functions static
Guenter Roeck
maintainerPATCH 1/1 hwmon: (bt1-pvt) Mark is_visible functions static
0-day reports:
drivers/hwmon/bt1-pvt.c:303:16: warning:
no previous declaration for 'pvt_limit_is_visible'drivers/hwmon/bt1-pvt.c:308:16: warning:
no previous declaration for 'pvt_alarm_is_visible'
Declare both functions static.
Reported-by kernel test robot <[email protected]>
Fixes 87976ce2825d("hwmon: Add Baikal-T1 PVT sensor driver")
Cc Serge Semin <[email protected]>
Signed-off-by Guenter Roeck <[email protected]>
--- drivers/hwmon/bt1-pvt.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/hwmon/bt1-pvt.c +4 -4
@@ -300,12 +300,12 @@ static irqreturn_t pvt_soft_isr(int irq, void *data)return IRQ_HANDLED ; } -inline umode_t pvt_limit_is_visible (enum pvt_sensor_type type) +static inline umode_t pvt_limit_is_visible (enum pvt_sensor_type type) {return 0644 ; } -inline umode_t pvt_alarm_is_visible (enum pvt_sensor_type type) +static inline umode_t pvt_alarm_is_visible (enum pvt_sensor_type type) {return 0444 ; }
@@ -462,12 +462,12 @@ static irqreturn_t pvt_hard_isr(int irq, void *data)#define pvt_soft_isr NULL -inline umode_t pvt_limit_is_visible (enum pvt_sensor_type type) +static inline umode_t pvt_limit_is_visible (enum pvt_sensor_type type) {return 0 ; } -inline umode_t pvt_alarm_is_visible (enum pvt_sensor_type type) +static inline umode_t pvt_alarm_is_visible (enum pvt_sensor_type type) {return 0 ; }
Signature · 1 line
2.17.1
Quoted 8 lines · Guenter Roeck
0-day reports:
drivers/hwmon/bt1-pvt.c:303:16: warning:
no previous declaration for 'pvt_limit_is_visible'drivers/hwmon/bt1-pvt.c:308:16: warning:
no previous declaration for 'pvt_alarm_is_visible'Declare both functions static.
Seems reasonable. Thanks.
Reviewed-by Serge Semin <[email protected]>
Quoted 46 lines
Reported-by kernel test robot <[email protected]>Fixes 87976ce2825d("hwmon: Add Baikal-T1 PVT sensor driver")Cc Serge Semin <[email protected]>Signed-off-by Guenter Roeck <[email protected]>--- drivers/hwmon/bt1-pvt.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/hwmon/bt1-pvt.c +4
-4@@ -300,12 +300,12 @@ static irqreturn_t pvt_soft_isr(int irq, void *data)return IRQ_HANDLED ; } -inline umode_t pvt_limit_is_visible (enum pvt_sensor_type type) +static inline umode_t pvt_limit_is_visible (enum pvt_sensor_type type) {return 0644 ; } -inline umode_t pvt_alarm_is_visible (enum pvt_sensor_type type) +static inline umode_t pvt_alarm_is_visible (enum pvt_sensor_type type) {return 0444 ; }@@ -462,12 +462,12 @@ static irqreturn_t pvt_hard_isr(int irq, void *data)#define pvt_soft_isr NULL -inline umode_t pvt_limit_is_visible (enum pvt_sensor_type type) +static inline umode_t pvt_limit_is_visible (enum pvt_sensor_type type) {return 0 ; } -inline umode_t pvt_alarm_is_visible (enum pvt_sensor_type type) +static inline umode_t pvt_alarm_is_visible (enum pvt_sensor_type type) {return 0 ; }Signature · 1 line
2.17.1