Skip to contentSkip to conversation

xfs/096: filter out the "Discarding..." output

PATCH In review Zorro Lang 2 participants 2 messages Jun 9, 2020

lore
Share & tools
lore

Zorro Lang

author
#0 lore raw

PATCH 1/1 xfs/096: filter out the "Discarding..." output

Latest xfsprogs mkfs.xfs prints "Discarding blocks...Done" if the disk supports the trim. That breaks the golden image, cause unexpected failure, so filter out it.

---
 tests/xfs/096 | 1 +
 1 file changed, 1 insertion(+)
tests/xfs/096 +1 -0
index ef6136af..04bc7b7d 100755
@@ -78,6 +78,7 @@ mkfs_filter()
 	-e 's/ ftype=[01]//' \
 	-e '/^log stripe unit.*too large/d' \
 	-e '/^log stripe unit adjusted/d' \
+	-e '/Discarding/d' \
    | grep -v parent
 }
 
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Zorro Lang

Latest xfsprogs mkfs.xfs prints "Discarding blocks...Done" if the disk supports the trim. That breaks the golden image, cause unexpected failure, so filter out it.

Seems reasonable to me...

--D

Quoted 19 lines
---
 tests/xfs/096 | 1 +
 1 file changed, 1 insertion(+)
tests/xfs/096 +1 -0
index ef6136af..04bc7b7d 100755
@@ -78,6 +78,7 @@ mkfs_filter()
 	-e 's/ ftype=[01]//' \
 	-e '/^log stripe unit.*too large/d' \
 	-e '/^log stripe unit adjusted/d' \
+	-e '/Discarding/d' \
    | grep -v parent
 }
 
Signature · 1 line
2.20.1